From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D66CFC83F04 for ; Wed, 2 Jul 2025 14:00:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 79271900007; Wed, 2 Jul 2025 10:00:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 742EA900005; Wed, 2 Jul 2025 10:00:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5E3AF900007; Wed, 2 Jul 2025 10:00:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 477F3900005 for ; Wed, 2 Jul 2025 10:00:23 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 2AE681213AB for ; Wed, 2 Jul 2025 14:00:22 +0000 (UTC) X-FDA: 83619484284.04.2769D52 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf03.hostedemail.com (Postfix) with ESMTP id 1363C20008 for ; Wed, 2 Jul 2025 14:00:19 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=uyMj+XKz; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=ztdvVxzF; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=uyMj+XKz; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=ztdvVxzF; spf=pass (imf03.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751464820; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KonS7cv/G9gzTUrpW1rGIG1iuK5W8/1IKztK8Mu1XO4=; b=Qja1cYX9HFuR01snKBvepxHWwfTbEwKG0Rm1ecYhcdRhOhKH14IiBqwmIklgF2dm+5nCWR 351QQ93VXmikHIuISNjczfqH0waQV55Jv0fc+28EPWdrEYwQMS2rZYRPsiQ31+rmVZsI5t UBVNTrMQ3LwOpaKJyCFhkyrGQtgVhu8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751464820; a=rsa-sha256; cv=none; b=WiJpuAp4UoZyULZGeIbGBP/KuHlISt817QMTEJnpZOOxP7SF8x9hWEskFhQmToqAOtd7eY OR+t5iCKHjWqUs35Yw1NQzY5fBtx/ObhODolO0GyI/5qzXOJNfwK5OUOQBMTwVYphsECol B+j5nbl8xoYvwBzF4eUE2JgCKeUZnFQ= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=uyMj+XKz; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=ztdvVxzF; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=uyMj+XKz; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=ztdvVxzF; spf=pass (imf03.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 72BB31F38D; Wed, 2 Jul 2025 14:00:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1751464818; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KonS7cv/G9gzTUrpW1rGIG1iuK5W8/1IKztK8Mu1XO4=; b=uyMj+XKz39UxrdzMtyrBsFtS95teaCi94Xxf49fDUQLfiycJ2ec5JOAAREHGLgFVb96S5d 4TCa5pe1fCdXt+kLhLW07IMIBQO+zP6CpHxZw5XD4v+A4i2+5zxUCo71lZKYTMlfzIwWZh EubwWx4ev/qmgG8APO9ClCue91oEtVM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1751464818; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KonS7cv/G9gzTUrpW1rGIG1iuK5W8/1IKztK8Mu1XO4=; b=ztdvVxzFzrBrPPHs14FmGsYmlixiWnvLiMdwom9ORka3RFw+Tj1vdDd38fxYB8/mCjRFYn ESb63tVyzZQNwQDw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1751464818; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KonS7cv/G9gzTUrpW1rGIG1iuK5W8/1IKztK8Mu1XO4=; b=uyMj+XKz39UxrdzMtyrBsFtS95teaCi94Xxf49fDUQLfiycJ2ec5JOAAREHGLgFVb96S5d 4TCa5pe1fCdXt+kLhLW07IMIBQO+zP6CpHxZw5XD4v+A4i2+5zxUCo71lZKYTMlfzIwWZh EubwWx4ev/qmgG8APO9ClCue91oEtVM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1751464818; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KonS7cv/G9gzTUrpW1rGIG1iuK5W8/1IKztK8Mu1XO4=; b=ztdvVxzFzrBrPPHs14FmGsYmlixiWnvLiMdwom9ORka3RFw+Tj1vdDd38fxYB8/mCjRFYn ESb63tVyzZQNwQDw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 3F46A13A24; Wed, 2 Jul 2025 14:00:17 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 6XWBDHE7ZWhGPAAAD6G6ig (envelope-from ); Wed, 02 Jul 2025 14:00:17 +0000 Date: Wed, 2 Jul 2025 16:00:11 +0200 From: Oscar Salvador To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , "Liam R. Howlett" , Lorenzo Stoakes , Vlastimil Babka , Jann Horn , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Pedro Falcato , Rik van Riel , Harry Yoo , Lance Yang Subject: Re: [PATCH v2 4/4] mm: remove boolean output parameters from folio_pte_batch_ext() Message-ID: References: <20250702104926.212243-1-david@redhat.com> <20250702104926.212243-5-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250702104926.212243-5-david@redhat.com> X-Rspamd-Action: no action X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 1363C20008 X-Stat-Signature: 9bu84764re73qxa7s7jizmm5b9godxxq X-HE-Tag: 1751464819-801322 X-HE-Meta: U2FsdGVkX18o30nT0MT1ZZyoNZs7Q5DXurSkuCa2mGSV0XEOA410AFouQ23FOLxgUqYtPu06CImBwcuipsHuV7nDTHEe5x16gBQEAJYACWCJhJUd0ZaV3ilwH9q/CVr8yVRq0rWWpMFTdsXHGXVrGXFpiOhuPOPvQ1YZCMwAO73HJAS/cep92JNu3+GJc4v0PL18JgbjT9l44zPSyk/rI4poBNnqGfKkYyP3s5DGekfG0DbJ/3uLIYOCF4ZILZiT+0Zr6l/nT6QB7bapwzN2jaKoi/fJUH71a5ZalE5U/lGJvftyTUGN9vDeR3OqUqOwl7E1c0QbD+fzIWl5sWbevkl3ay6C5Y6Qn0RpJktYPqyhdyHSKYFeV8tBElqKlracZqaeS31XUxqybREZgr1sCasDDqxLf9WxDsL+Zp1Tpo6sQXwO5bJjT/jyNvZ9NY87qEEGfLoKyqfc7zTh2K2nAC0mHOxLPTEN+YWusndtghJV99ZrOLnIgDZbfX2MSxj9waqv1SuGoSQT/KHIOQXfhg2Op6/e4WUL6oenChMy4WJQQ4is5Cn9tSH1WM/DcEsDFHXqOLrT+l8qJMrRE9K4c+BHjI8k3A46MY5P/T+fdUTQEmn5W2QJ2iGvC9YSpsyTvSIaELDj+oem8fkjzvdfmhw3s4xCmI85yq65Q+WC+N9Q7goslppXegaOQ2wgQTF5BfmaDtjhUV3GYhYfivk3hWcoA0xeR6bCjRBpfYerQxN7zTwU5+vHtNuzbnaEAQlESWPNoTHcsf6pWljFn0w6vH/ISsjIZNAnr+30eX94TWcu8lrCFDfSQjtsi1hzNlJ+ruCf19l2tTRMayMhAhY5eSIfROhORq9Nkw/CGfW4c9dQE5H7eVzDYA2J/v+MbSSPa+gxVu668jUQWHBzMl9QWCPBHzgy5i+HOaskThWyQ/I5YMppSSOl+Og971lYshas+p76STKFiaoYMvjpXl8 vY9DkHTm upr82bJY6UUJGRcEnN6aJuxwyjqyZZMRsHocm/E17HuqzalIvbzW0Vhm28g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 02, 2025 at 12:49:26PM +0200, David Hildenbrand wrote: > Instead, let's just allow for specifying through flags whether we want > to have bits merged into the original PTE. > > For the madvise() case, simplify by having only a single parameter for > merging young+dirty. For madvise_cold_or_pageout_pte_range() merging the > dirty bit is not required, but also not harmful. This code is not that > performance critical after all to really force all micro-optimizations. Seems a bit odd to me to have the dirty-young bit being treat as "one". You mention that this is done because the only user of it doesn't really care about dirty vs non-dirty and it's not harmful eitherway, so micro-optimizing this isn't worth at this moment. But what if we grop another user which wants to make this distinction and where it matters dirty vs non-dirty/young vs not-young. Wouldn't be better to have it separated from the start? And I'm not talking about micro-optimizing, because that's clear that it doesn't matter, but for clarity purposes. It seems a lot more organic/natural/obvious to me. -- Oscar Salvador SUSE Labs