From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29A5DC83F03 for ; Wed, 2 Jul 2025 19:47:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AB8266B00A7; Wed, 2 Jul 2025 15:47:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A8FD16B00A8; Wed, 2 Jul 2025 15:47:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9A55E6B00A9; Wed, 2 Jul 2025 15:47:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 884B66B00A7 for ; Wed, 2 Jul 2025 15:47:06 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 2444580432 for ; Wed, 2 Jul 2025 19:47:06 +0000 (UTC) X-FDA: 83620358052.10.E21CC56 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf22.hostedemail.com (Postfix) with ESMTP id D5519C0016 for ; Wed, 2 Jul 2025 19:47:03 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Pz0cCSSZ; spf=pass (imf22.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751485623; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=07wb+yqC9K/rdBl3pwRiwTzUWSDQF/Wht+95iFS/6Ec=; b=GAMcyTNGL/ZqOhX7tcV0NF3IuVEbwO0MmFUwLG2o4sQ29MxIzd2bi57cn3j+v3Yzp9mPx/ MQFVXE1ndhXxQCgIqtsFgKiX4pBdMEqbH3nj5Uw9jLxE2ScHATbfMNJjfrgFfTwHVEp+Yz 5uR/zip2RdEH97D9jivO2Up0s9feP1U= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Pz0cCSSZ; spf=pass (imf22.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751485624; a=rsa-sha256; cv=none; b=dzSc6hsiGKQFoUOcgY47flLNpQN8oYALnJVSD6y4+Xlzs2J9KHsPjrGzs+WYFRGKlNgBRj wJeDJ/kteQDpHg2Y/5ibenPofBT8bUFljo4ZRmidF9Ovsujj25X4gxRTpBMyh/6hN2UDaP HyBwr0lf1sNKmTXNR465GKRfeLgT4Qc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751485623; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=07wb+yqC9K/rdBl3pwRiwTzUWSDQF/Wht+95iFS/6Ec=; b=Pz0cCSSZ7jcCCQPicNdHp7twmmCRZ/p5LkOgv02P1DzrPNGBRn6qj+Fni8KBVKCREQr/hY ZcRAgHAyXGkBwsIKb3DKpCqvpmGeQ0VE42Ozrocoq5xsXJiyqGvZG/rOvXjLsVk3axs5zp r3M9rgWA8DqBaHDtHSD93fv94ixIcjs= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-665-slgk3UlBO9iQrjrl3PucFA-1; Wed, 02 Jul 2025 15:47:02 -0400 X-MC-Unique: slgk3UlBO9iQrjrl3PucFA-1 X-Mimecast-MFC-AGG-ID: slgk3UlBO9iQrjrl3PucFA_1751485622 Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-4a7f2ca9536so248891501cf.2 for ; Wed, 02 Jul 2025 12:47:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751485621; x=1752090421; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=07wb+yqC9K/rdBl3pwRiwTzUWSDQF/Wht+95iFS/6Ec=; b=Xa/MNLUkWm0QHVySvPfdqKbDoZr4kTIKOWrb+ScsPcgzfLFSek+5uXEaAMVdKCg0xK J9d/J/g2WZ45+XhwVOqS6BDXYD8+z51UwPJQZbHugnakEByYpjSRR8/odhBHzTpTxS2W 4x+lc8U3B6ILbjK3fWM0WK1bZtI7rxI5BSwFK+J869hrVDHN6sQzJhW+FfWR0GjPbJDC fGtCvxTx15LCCKV1i4XD73pPiaNSTJ/MSex9TLq8aiyMDIiFlSOJJTXKlLDCWN9SeJUO lU2auYONnF7fGpgge+Zsz0uWiIa3ZcJA8B2md0jdym6NLy6c9FooeO+Z88w//Bks5wKq a1Yw== X-Forwarded-Encrypted: i=1; AJvYcCUOcIU0Q4jCVShVpBgb+ZnvmP1GZZWnohgruZrRPDDnArk0cO8bd9H6Rkfkt5YQaIhi4lQ9EWnKDQ==@kvack.org X-Gm-Message-State: AOJu0YzKINfa+ONvQ9ZMXYJtlBPjxKpj5XBO1Zg1wpvDRo1un/ZBq/ox uYWOhe6RAlxvK8+pahS8t0s4CksHT/NQnO/v7EVYlBsewDTXYfLoyhEEe86NXmokhKXhX97eIm2 wJ+Fpw5zbckGycUUZ8PGO5/JwkLrbzaw/Gzq6PIrWca43Puh6YvTk X-Gm-Gg: ASbGnctskZDJYXTIh0YKxjV00P3qjlFYGIUw2XrUaJZWJhDu/q/oaIQhi4FOTWVbxmo qou3xGYiQlodH4W0hblgCCDZnhYgl9LD1kmjQFqCSjJE5i4Z00/f7KFqqIjUM3i4K5YtaWYoPOT mRsWMKm7OlIyLY0dLryCUM+lSEJy2GBJKKZDoYhU9iaEjmvBA6gzUJAMiqF7O1+6boa2kLHE04d PKYJKltJMK2mtmBrtPCpAlTTFzNs9gN2HbbCiJVNLBFq+4b8flJzqkEtt7+lQ6QJu0gH4hgrDoL PqeVO45qh6ZOjA== X-Received: by 2002:ac8:5709:0:b0:4a7:7ffc:ac95 with SMTP id d75a77b69052e-4a987a8514cmr7754821cf.40.1751485621477; Wed, 02 Jul 2025 12:47:01 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHQsdqobNy1mQb0XaE938BY0WHKtWgjgIrwcvEIFIU6s57XVVumAspQqrPvI9ljbZHCTGkS8Q== X-Received: by 2002:ac8:5709:0:b0:4a7:7ffc:ac95 with SMTP id d75a77b69052e-4a987a8514cmr7754491cf.40.1751485620976; Wed, 02 Jul 2025 12:47:00 -0700 (PDT) Received: from x1.local ([85.131.185.92]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4a7fc13abf0sm96184911cf.30.2025.07.02.12.46.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Jul 2025 12:47:00 -0700 (PDT) Date: Wed, 2 Jul 2025 15:46:57 -0400 From: Peter Xu To: Mike Rapoport Cc: Nikita Kalyazin , Lorenzo Stoakes , Suren Baghdasaryan , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Vlastimil Babka , Muchun Song , Hugh Dickins , Andrew Morton , James Houghton , "Liam R . Howlett" , Michal Hocko , David Hildenbrand , Andrea Arcangeli , Oscar Salvador , Axel Rasmussen , Ujwal Kundur Subject: Re: [PATCH v2 1/4] mm: Introduce vm_uffd_ops API Message-ID: References: <20250627154655.2085903-1-peterx@redhat.com> <20250627154655.2085903-2-peterx@redhat.com> <982f4f94-f0bf-45dd-9003-081b76e57027@lucifer.local> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: obVz15_K7ytbGMPAxYPQ34nkPXGePpehL3rm4VuIunY_1751485622 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: D5519C0016 X-Stat-Signature: m4guywsacgx9h5ke4gcriamy3xqyjtox X-Rspam-User: X-HE-Tag: 1751485623-5843 X-HE-Meta: U2FsdGVkX1+dZfTbqhTWriu4YW1ZbHEmcTHlhQIIxuxBptsYNH5ERafxiOw0Iwh2oZvLzTzUgRAj/NY0vi4msu2lkrpFBZnzqBQCN60ZfyDkSfaY4yZgmZNGgFDLvewDcMRNBlIWWNgoBO7s7XFtNDXr6kVuLnbppXbCIB6bchAm0IVSU7MrUbmUGkboIOIPh6ABWPQsiodaYV97D3dfTagkwxgjjHeOQeI8lKpR2hjSoRLR6BAWuR2xJ4AkFGfyXGB3/01FypnOCq9TO1SJaZBxkgIMxAyui8dfiFcH9/fzEz6MCa8LpU9V1gAGmwBRUgt5fcZoC8ec3Meo4RjdtFRd7Iacx9nw2tSYMLF03DAXUfCIE97EOhpa/ofq/rEAMdzQO9MWgPDC+1GjDYI4TudoCoxSRrOxnYu0EXDJG3HNUDihfNbC/Phy1JPRLuLrRNNNj/U50wUyEEnTWcYjH+g9vRxy6/eoozX7DoaVpKel9U6kfwdyfvfH2VKMYPpJGuOOZRnkhHLOACbI1fZdBeClTJKiJjo/qaKLLIDJm+mfgpw6lBmpVDnineF9wHRfjdNQgtKkmB3I7ZydnFM7aTHnbuiTr07BOb7AowGQFS3LTKMe25MhgKyI14mQq20kIhItA35SybeO+h936MuZ2rmNQoahlXXMNfPUcAM1V0AudGcNJEokPHayLFdG3LkCY1tC9GJzgIxrnuqDhWfwBtoyakfHPqFR0Dzbhq3fzYiIcG099D5Ao1B7TTrzDQXXaXNaXfVdU7n4p0LM8sIbRZcAAndpOYTaaZT64IsRhV0TOkdQSrlbzn9XjIP0gd3cIy6boTCLOuQ8gZGyj5zg9RgHvnmf6+lxVuQ/C80SfsBbkKUFvrwHXh6D4Bk+U0CyKhqiuq7LUJtA+aImcfw7Dxdk6p5qDhPr+cQWeo5xJ+gaju93l4Owl5C/zqA+sc+rZlwRZyq8sCiGavRoRxR ljCb75rn 75kxKVd8hFzT+kgHABj/5QV+O0b7epqKU2az7HEY6zEFkW3cPCw53HYhKDTK2153tXF2oC1QGeGiUCKhMYQMsGq4fVa2uPl2rOCDfyeFp5xM0XIxB054rWQY6VV3lZSyZ+R/xq4ZYStPiw7Gmspc8MSU4OPaVwPVsaeV7qyd3dCPrewQ1fDxPw7kTX7FhON8UlE+Xz3RbW+j7eLX7Pz56ZagPlxuPmSn9/ewuq2trtZiW5YDwaGsuF60/xanILGsAjaGCkWhbo2/9ZkjOn6fQsaZUd0Ooj9ekMJCHcJcKUoPMvKCfYGVvhdhxNx5/fvJIG64PjzYlSPJ5BvMDM7rC4aMKzJc1PN88Yn9wLVXW1v9kILiZgstq08SCIXGqpsTgHShqalRScJqn6h1Ge43UUoaSVD65UZzv1a3l77tzjzyKM4eTG7P3O4NpS4JJliBwknjYjD0qpcfDsn2Qww0+Pi+7hA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 02, 2025 at 08:39:32PM +0300, Mike Rapoport wrote: [...] > > The main target of this change is the implementation of UFFD for > > KVM/guest_memfd (examples: [1], [2]) to avoid bringing KVM-specific code > > into the mm codebase. We usually mean KVM by the "drivers" in this context, > > and it is already somewhat "knowledgeable" of the mm. I don't think there > > are existing use cases for other drivers to implement this at the moment. > > > > Although I can't see new exports in this series, there is now a way to limit > > exports to particular modules [3]. Would it help if we only do it for KVM > > initially (if/when actually needed)? > > There were talks about pulling out guest_memfd core into mm, but I don't > remember patches about it. If parts of guest_memfd were already in mm/ that > would make easier to export uffd ops to it. Do we have a link to such discussion? I'm also curious whether that idea was acknowledged by KVM maintainers. Having an abstraction layer for userfaultfd memtypes within mm always makes some sense on its own to me, so as to remove separate random checks over either shmem or hugetlb. E.g. after the series applied, we can drop the shmem header in userfaultfd code, which should also be a step forward. Thanks, > > > [1] > > https://lore.kernel.org/all/114133f5-0282-463d-9d65-3143aa658806@amazon.com/ > > [2] > > https://lore.kernel.org/all/7666ee96-6f09-4dc1-8cb2-002a2d2a29cf@amazon.com/ > > [3] https://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git/commit/?h=kbuild&id=707f853d7fa3ce323a6875487890c213e34d81a0 -- Peter Xu