From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD1C6C83F04 for ; Thu, 3 Jul 2025 14:28:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6E1FD6B016D; Thu, 3 Jul 2025 10:28:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6931E6B016E; Thu, 3 Jul 2025 10:28:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 581436B016F; Thu, 3 Jul 2025 10:28:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 46E886B016D for ; Thu, 3 Jul 2025 10:28:37 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B6F885805C for ; Thu, 3 Jul 2025 14:28:36 +0000 (UTC) X-FDA: 83623184232.03.E6290BF Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf05.hostedemail.com (Postfix) with ESMTP id 8EEB1100013 for ; Thu, 3 Jul 2025 14:28:34 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=UCX+Pa5e ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751552915; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=W1Tq/L6ZAbocFgEmsUnCZvw0L6N9KDtQzADck8JeSDg=; b=3yX/RzSDO16iiOiKJul+xzQHlxCX0ELTyFSLE3nTgOUg0JUg4gGs0gakK1A5Cx+Afv/RGV 0UMPjBX1EWSHWbdLd9egrzPT4cd8c7opxHg8PC6gvgyt/j9Jk+QLQXOkngidHLU7aE2Caw 6QSZ2LufFPJNQ16rbabpeHYLFfFbfqY= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=UCX+Pa5e; spf=none (imf05.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751552915; a=rsa-sha256; cv=none; b=gWBKr3Zq2LqkXTDnI9Clx373aR1rnCtzL2CZvOvPuNdYqNm91n9ZAZ5vuTlsYw+eHCCH1z 6DcrAADhhA+qxu+yTFoPn8roEdDaJMBMihGxxUT+9tx8fNIicfxtc1dqbTpjml/fbqKjXo 1hGsku+Rx1jOETdO2tyFAW1SwBoDN5c= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=W1Tq/L6ZAbocFgEmsUnCZvw0L6N9KDtQzADck8JeSDg=; b=UCX+Pa5eicmX2gXGXrzeTPpqJ4 33TmXxTL2Abo8OGhmCQ8Xj4xu9ygu9fKREIhq9pHNbhGFDHDt8UB8YhfdfH3n2DLMOW48FRH/gpX6 wstvY/0WV9nUuU5dbIkx9PkljRGmcy1byyCeEk7M7tETgyZ3scd3/9KUDWYJ1DRYo4AQ42kMc1R0Y RsmQXRHodgeaXh3Xi+DZ7oecgz6caa5lMHsI9CuU3k0gfTJzUaxPRG7gLs9LATUCZ3jedCRdszpQD beDIcdsDODbgyj6RtFYNIv0P7mDA78fNfqeiXL0E445RkTTJrySTEkVtvzj6i/9NYxnkuGikjXrC9 p/DqQ8dA==; Received: from willy by casper.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uXKvH-0000000DM6m-1vam; Thu, 03 Jul 2025 14:28:23 +0000 Date: Thu, 3 Jul 2025 15:28:23 +0100 From: Matthew Wilcox To: Frederic Weisbecker Cc: LKML , Andrew Morton , Ingo Molnar , Marcelo Tosatti , Michal Hocko , Oleg Nesterov , Peter Zijlstra , Thomas Gleixner , Valentin Schneider , Vlastimil Babka , linux-mm@kvack.org Subject: Re: [PATCH 6/6] mm: Drain LRUs upon resume to userspace on nohz_full CPUs Message-ID: References: <20250703140717.25703-1-frederic@kernel.org> <20250703140717.25703-7-frederic@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250703140717.25703-7-frederic@kernel.org> X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 8EEB1100013 X-Stat-Signature: 8zsxjr8h5j6wa75jnj4ob1f43ohpeok4 X-HE-Tag: 1751552914-475505 X-HE-Meta: U2FsdGVkX18z2mYvs1Ngj0sjiLCTwDJkoN/TDA/IW2z3BsdTCMoexJmeyt2hN+1X7CokGZLis2nN9aXBgWwW13MmOoMIdSh91h6nTMYcTonWWhErpR4WCjsAWh7HBA13fsrp+kQj32NLvITlFa6V4xQL4saZbCky2WEn4hzqXeMF3Eb+9FVqbM+5F9Ije5RTZv/eoXhj8WxNjzV4yId0Ua/KtX+sBzpUyRwE4KSHaNQbMuATX1LGfdobaKKKkP1izCDA5y2Z89w2QP+WpOyLjQiF4P6G6wtQx9s7NTr593Ij35lEN2XIfxh3DPiAZES8SJpZ659pAp/RSm6yaKgTCUB9JTD4cJi2pJl/3tDu/Eh2/LEYJkqVwCi09wJ1ZkoBP0687gLzV1nA6UvzVlLlmMbUPWWCf1AhDQmISANF4zLkCjsko73TKjvrMg5GEWLxuHYmn4OT8uSLRxXzYOUd5oOxoLfqGuc2KFB33suV4h3ty8Xa+igYxl2bB9SmOsF/cF1P2rzf0BtnXScn8EFKLnP//skh64AdRPyJe54mKNAFg3vh14Ap6qc9Ds9AD3seTFoq6Vp7cyZvgLeNrkm8Kxh1q17VeBtvrGRPbwBNZfaSdJswfojgHoHwVdYfEE1xF4Zb5z+TzHQlsk1GByPDcRkY+i7KQ5L6tBeTS4kpgploOVqnLyxgRXM2wvZKn3hlVxkya/Khw+msxQmfVyZSUCSRPUq5VBvHWuoFcbrxhSeM0BCPAZJ/x06bUZzsTWD0H7Fnotu9/1+5L0psAjhkOa+ybdtIKAiU+ez9YSnd1AV5nbectOSXmbiIGD+vvHrymEedSs5eIeVqmBUwnojtCz7o4SkTxRN91xWHYx894VxNFPGo2fjOIs9xb1f/U6G78xz5ik61yVj4rsTU3Ss/GPlk6uIA2/QLzREAnXDqxD8fpSxYNt0kYktB+oUfC54R1aX6Ya/ZUfFBgcmZEJP JmT5d6mK lIo3AycGzJvl1fp0hNirUz9DsbUiwK79dFb1NDG5cHt/vM1Etx0NvPze4WwFP+ydY34PUUGl68VrrvBYB5uGVQ0tNoSACNuu6n+bKB1FjgwEaw3wtWC8PLxsYBo/0uCigPNKALuE9NZ0HUR4YrjRd0O7hNW+vWJWLPXuKaq+bzqpwz8Gx3yuC1zGJZHlcjhfhtH0btxd7fMm7pQhkSurGLDekLmTGgQc9ggXB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jul 03, 2025 at 04:07:17PM +0200, Frederic Weisbecker wrote: > +unsigned int folio_batch_add(struct folio_batch *fbatch, > + struct folio *folio) > +{ > + unsigned int ret; > + > + fbatch->folios[fbatch->nr++] = folio; > + ret = folio_batch_space(fbatch); > + isolated_task_work_queue(); Umm. LRUs use folio_batches, but they are definitely not the only user of folio_batches. Maybe you want to add a new lru_batch_add() abstraction, because this call is definitely being done at the wrong level.