From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93608C83F03 for ; Fri, 4 Jul 2025 16:20:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E99646B0125; Fri, 4 Jul 2025 12:20:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E70F56B0127; Fri, 4 Jul 2025 12:20:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D60436B012B; Fri, 4 Jul 2025 12:20:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C5E6C6B0125 for ; Fri, 4 Jul 2025 12:20:52 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 3BF02122F60 for ; Fri, 4 Jul 2025 16:20:52 +0000 (UTC) X-FDA: 83627095944.12.798A84F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf01.hostedemail.com (Postfix) with ESMTP id DB6EB4000C for ; Fri, 4 Jul 2025 16:20:49 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DvJw7Kh1; spf=pass (imf01.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751646050; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=E/Z64A1L91eoVM0oVYxeXCv31/CXTq/WMm33nMh52sU=; b=nwp7aeLcSbaGMLwq7abe5D1pR3EsGUSqCi7IJmWvawNt0VgTL0DGQwEg/+lQ+EX2p+njHj 9lI7iQd6VWXxVc+Uy+WigVsd1xbuSWJ4i8DIeSDqiX5Cb3uYb5v0ACynW8uHUqHZEwvQDV EWEnxDp7BOUHDA+bp/GoIot/HhWlgrs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751646050; a=rsa-sha256; cv=none; b=2hlfkh9Ju/O9GCFeYEke2Y9nOBiR6krXF20bLgHxTqUYqdGNGku6zU2w22BV9IUtmbP6QF ZGleIw/7PZIVKYkhIcWXUUxh65d/NJ129Os+qlGd1uNKONhH7mw+7mUBPRaJdHb3J8Cf4y ZcXAE0FIqnTqNLjnrq9p1g1gIMOz2n0= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DvJw7Kh1; spf=pass (imf01.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751646049; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=E/Z64A1L91eoVM0oVYxeXCv31/CXTq/WMm33nMh52sU=; b=DvJw7Kh1UvHpwv2HtEO3kjc4fxhwVPAjMs3+0YcjkyEtVbUQNXWbZxBJJYyB98br4fCUMY ZvXVOpTskSZypK627Y13QZouqO0VvrcrJeZB9h+vudE+2ZiKly+yBOXVhCGit4VxzXbBmF qvMD3+dCfaHgJxYr795bRG0+TrwMF+0= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-441-f2XIqzQoNlK0K_oAvx1m3Q-1; Fri, 04 Jul 2025 12:20:48 -0400 X-MC-Unique: f2XIqzQoNlK0K_oAvx1m3Q-1 X-Mimecast-MFC-AGG-ID: f2XIqzQoNlK0K_oAvx1m3Q_1751646047 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-6fb5f71b363so15227556d6.2 for ; Fri, 04 Jul 2025 09:20:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751646047; x=1752250847; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=E/Z64A1L91eoVM0oVYxeXCv31/CXTq/WMm33nMh52sU=; b=orhhmvhJlnpIpXXyFSt63C7ThAvD7W1EeElni0gW86leWzHw+ttlTxC5seD3Hh0fUD zgZ1LPx+3h0ia1CSYLjwyspFxIqdQ5kKNJ8vW1tHe/wd6etMc/MmcRGgO0RXSvO8TKo5 MK0Od4atMT/wIS2EP9Z2WZ/MbHGDRQXF7yQMp6fcHi1snORrb7DWjbxAB6P+cGttCXUN aNpZnx/r7WMidLOf9kIJjasa6/R/eqgy0c2PpVuxdfkGsD78WNUALFHbWoXNp9Md2mQ8 undwznOUowN9BwWfJvpMybx0QU24KEH9nt2EWI1nHpke6G0AiD/K8SefFPnK7MqD4lSs e/8Q== X-Forwarded-Encrypted: i=1; AJvYcCVTXv4XoDsIVGARSEMJauEtsn1EwZiIdLx/i3keYyBuV3FeOht5bdwHmJDMuO5D8ocSQvTC/LvwNQ==@kvack.org X-Gm-Message-State: AOJu0YxsNim7+7BNKBCGufaheBPAmUjm32iWCyOIglz2siGUpMYszrZm jrg6RHqScOyoRIPgWsGxVy1oT8Iyj+JhzOeOmI2IF6BlRIvWLvO/jcKCgGSYZ1v1YMePW591owd rrlmB33kaeGRQbG03AhJJcMsTm5d7mswcC3/W24mJr5GGPTxoYrgg X-Gm-Gg: ASbGncvkqG6bJljSeC77AIvXxPQcfDtodDNJH6S3gLwPnmjiC6R8XqjLedbhh01s9g4 /3PmrgM4EXFoi38z9Tj9eUrJRwvEEXMIQLxWQbWz0bOzxiq9KH5425k58w0GiWsQxVOoyE+rf2N ILQ0XMiy6aoqp8oGCtFzdfVPszEwWQY7gCVckGuVHQS1LPqFBcA8CUnFxAy3y2JEahWuEzAgSul jPKlpu9y35AfCQ1JHDbY4hujmwFYLJvy24WH9hnvOyP5PU+GrIyIQOHW0cpGGO6ElzgQaKba6lk fU6PLh59MvnXqg== X-Received: by 2002:ad4:574e:0:b0:6f5:106a:270e with SMTP id 6a1803df08f44-702c8cd9c14mr31160136d6.44.1751646047393; Fri, 04 Jul 2025 09:20:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF3QKwHLNjLHITPK4hmbCxjyMhaRZnObLUF7+e4ri5Ww0N5q0etFpJdEt757O7D8qHEJZMJGA== X-Received: by 2002:ad4:574e:0:b0:6f5:106a:270e with SMTP id 6a1803df08f44-702c8cd9c14mr31159896d6.44.1751646047084; Fri, 04 Jul 2025 09:20:47 -0700 (PDT) Received: from x1.local ([85.131.185.92]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7d5dbeb3186sm166607085a.109.2025.07.04.09.20.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Jul 2025 09:20:46 -0700 (PDT) Date: Fri, 4 Jul 2025 12:20:43 -0400 From: Peter Xu To: Ujwal Kundur Cc: akpm@linux-foundation.org, shuah@kernel.org, jackmanb@google.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 1/1] selftests/mm/uffd: Refactor non-composite global vars into struct Message-ID: References: <20250501163827.2598-1-ujwal.kundur@gmail.com> <20250702152057.4067-1-ujwal.kundur@gmail.com> MIME-Version: 1.0 In-Reply-To: <20250702152057.4067-1-ujwal.kundur@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: wsaZYBzTslpqaLxnWD0Ajs1loIjSl9MdV5BtipAIyfI_1751646047 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: DB6EB4000C X-Stat-Signature: 9ueqdf9k9twqkqcdxo8pqpofgmjxgooh X-HE-Tag: 1751646049-526703 X-HE-Meta: U2FsdGVkX18iTz/bv37upsbxZ5/5onrQOniu8sBvrLSZXHn3n9Em0vVtnaQ5O3zZFvrAOZ0VuMEtJVGTsMf8K/xp6IkK5qayS8PKWCqzWW+sAxuZF7HGhSHRaQiLsY4oiE6iYi6QP1/vzjBgAg48WJttxAO13X6E+p4VBbNne/pVEuxKzD6rPq1Yetefd98sa4A6EldU5DirCHiRZsjJvjiXQATsbz9QxqplNy7QmGNggrcHj5elGMPzpH8sRb/V0QHVAv/PxpJI0Y0mug3+aVEfVhrWpHIRCXAeDptqON6HqgvVdZ2o0r+CHsskqGzGYA6Vrmdh8XlyahqvksN/iA6h5JUdoYaBOeZ0akT/IuJMeuIVIbgufSfoZd/TUcC4x2E9MHtnJb47iGyIxkzEZn+cWjoCFNJyNmiLR0+aTUKPGw1e4BiU8jRviRdYugywbat7FvyU0iFa+Ws6tqHO0jfS6dX3XaBAnZb2vRs8VONGQwBqwv2BTy9QldDhEwz5tWhrjWiqZH3/CiGv9OmgBGp6ku4LieXFRuOBSHtNAa36EJSFWupasmGXKZGULgJC2F++xw+uK1BagB2HFHG9Z932g1ZE8/z7YFAaPoH2LK65QSF/pdY3+y2YLREP0ugaJuWqkuDKhCVLy5mPoqnA1G7hiWdYwJ1vDHvNP1JAz+BNkpQblh8T+Xc80WvFSj+Sd5aPrfrmswNGCffQESO2+C03NleZbeXDE4xm8Qu16T2XKSYS7ES1OFGiBUBWGKy0MeEl4lMRlLVIOY6xqfMhUrgL20070xbpb+yi+zSohDiPODCazaaUtcEzbFOAMTMzmqWUXgd1xPAdbIBO/t0An3aTBMhj3yy0UlnQVndeH5xanmanqu/CfdUTotpXzrVjasKKnx/PJ+gjAr5uIzog7oHPu3KjXBcPJFLsiwJyj6DFVLG3RzXbnHEUpqMp64NjTug8EnQKr754daSvCFZ RTKgR/5W FNwCSU2cqROVwRwnjzUpZc3FkbPGkH80faRdZNGNwynjFNo/WjHI5vmdXDpYF+SASIDWYrmMvMcG6U7+dsIfZEGrw8kXcJXYuaUoHxNhg/Bj7vmh+hTsrFlXrK4hV+tT+QcR7fAY8Ce6fFzQLGmD6xYHQ4qeyMR+snXS7IP6mL3tf//rtYAXSDdjRQ0z+tCLj21AvPEH9YMkX4h9ti83rYTddPnHQtEsp9bB78skGwzKuPZbQ54k+Fjn2yHDgZv7shTAop3zwHVG3K8U3v+d1aBpXdjECthWn8bl92xxyrt5KYl8V+RUp2M4cHei3HPhs5RV0RVuzYEdSj2T8TTOaGE6eRXdYFosmPBrTbUF411edLNQviY2gpBQ1oSg9ZuF1wrXl8VAA8iA9BomSHH0D5Zo9c/Aqo7nfwXD5dEka/Qi+s0m79Cdh+WVHAHuRrQhgMsmUkWhFFsI3kFLGmpEr9/SBzhjk7DR80AAb/OnZ7oXEGPln5T/uSlq6Ss7j1vffyytU+kYi2HgExDGgmKuBQIGfCsEQvkrpUL2gIgHW6/dLe5M= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 02, 2025 at 08:50:57PM +0530, Ujwal Kundur wrote: > Refactor macros and non-composite global variable definitions into a > struct that is defined at the start of a test and is passed around > instead of relying on global vars. > > Signed-off-by: Ujwal Kundur It runs all fine here now. I didn't check line-by-line, but I keep thinking this is in general good. Acked-by: Peter Xu Thanks, -- Peter Xu