From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B110C83F03 for ; Mon, 7 Jul 2025 00:51:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 873196B035F; Sun, 6 Jul 2025 20:51:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7FC106B0360; Sun, 6 Jul 2025 20:51:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6EA336B0361; Sun, 6 Jul 2025 20:51:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 532B56B035F for ; Sun, 6 Jul 2025 20:51:53 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id B29F81D8776 for ; Mon, 7 Jul 2025 00:51:52 +0000 (UTC) X-FDA: 83635641264.28.9CD3FBE Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf06.hostedemail.com (Postfix) with ESMTP id 21E4A180005 for ; Mon, 7 Jul 2025 00:51:50 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=none; spf=pass (imf06.hostedemail.com: domain of cmarinas@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751849511; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=X3irXDp6N1mLMLI+A2HiDkSvIQrKjc11+W2KC82uC3s=; b=aAgQ1y1TT9yyw13G74xBx7YrdOIGKIeXouMsL8TLqIyVR4vIWYoEhjwfFJ9qhmIdm45Pd9 bErzh87CoTfu/eh7Ujyx3pFVU5A3GH5HJr00m+EKDQI0HjRWHKB409gmr5sQWMeomppfJ+ ufdEko0zr+QtOdvGqQaeh5iP8Qtmdvs= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=none; spf=pass (imf06.hostedemail.com: domain of cmarinas@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751849511; a=rsa-sha256; cv=none; b=qLhw+WMBVgmo7szz0ycroW56yqgD+Nd/IhFWcLZ9dY2LC6Z1Ut/tDqYvbSRL2yLskvICY0 pzEhEd9C2bFbgnkzn8QBOkCojKiIQCDYU2of9DilGdJvIPI7jtkKruYCUiONqpAkkNachj OuD+kmi/8qurtKnPXQmcKrjurLJgpUA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 42210A4D58F; Mon, 7 Jul 2025 00:51:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EA322C4CEED; Mon, 7 Jul 2025 00:51:14 +0000 (UTC) Date: Sun, 6 Jul 2025 19:51:13 -0500 From: Catalin Marinas To: ankita@nvidia.com Cc: jgg@nvidia.com, maz@kernel.org, oliver.upton@linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, will@kernel.org, ryan.roberts@arm.com, shahuang@redhat.com, lpieralisi@kernel.org, david@redhat.com, ddutile@redhat.com, seanjc@google.com, aniketa@nvidia.com, cjia@nvidia.com, kwankhede@nvidia.com, kjaju@nvidia.com, targupta@nvidia.com, vsethi@nvidia.com, acurrid@nvidia.com, apopple@nvidia.com, jhubbard@nvidia.com, danw@nvidia.com, zhiw@nvidia.com, mochs@nvidia.com, udhoke@nvidia.com, dnigam@nvidia.com, alex.williamson@redhat.com, sebastianene@google.com, coltonlewis@google.com, kevin.tian@intel.com, yi.l.liu@intel.com, ardb@kernel.org, akpm@linux-foundation.org, gshan@redhat.com, linux-mm@kvack.org, tabba@google.com, qperret@google.com, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, maobibo@loongson.cn Subject: Re: [PATCH v10 1/6] KVM: arm64: Rename the device variable to s2_force_noncacheable Message-ID: References: <20250705071717.5062-1-ankita@nvidia.com> <20250705071717.5062-2-ankita@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250705071717.5062-2-ankita@nvidia.com> X-Rspam-User: X-Rspamd-Queue-Id: 21E4A180005 X-Rspamd-Server: rspam09 X-Stat-Signature: xwkzxwy1ecjatpwdgd4ofrrwoinkpu7t X-HE-Tag: 1751849510-263659 X-HE-Meta: U2FsdGVkX1/fTikITYvuNr5DaUyPS0hOOuFCufAaVLFv8EY9TsekLLzC2NyefZJ9gA2VXaJxvA+TrOdD7WF6B9qn5Tp1Dho4NztxZUjRTvkOZ6IWbORkKK3IlQK7WCJwijuKCfePjwPG9TPvGodlrrFzn9kTgpp0AFRp2fl8nG6vlHbM+8NNYh+EJAYu3aySPdN14odUXgJpFQM0+qg96A1im7RImQB5tA17a03dJvsg2cN6wSIf1yY2V7jtB2qNX5cDp6A5LWbjTJqswcawf+368WPxR1Rc5xgS4azJbhYedZhN++shf21xcZoRknIIksrXwPo0sqTJ2RnGJqKsMo3gQC4P2p6f0fS5F5q2iSmzn/PQC5+ZKFlrm6Vc5jpvjs2s9jmMXFuf4mmKvoLQio4qpDHCQiYgfOT/85XKr8DTsiHLZbfiRg6bQOzMCTIuf82d9lyXnL4UuHfP5vReNcOicfzg2lbZhKdYIJqTAbVyVDqQILt51/azg+v+N/Aw82dRi7ZaFQZAXUMs2N+p4sw5NJkg+hJwWK51+6hnuqtKXXCqqvb8AQeiZI2VGEoeXrkn4zPWDMnFRvmqynxMHcfnndj8OR1JmtBABJZuD5Da/tQvPfw6vfw6X7XnBuAbWoi4X3zquNfdQrjjw2o1ziWGKCddFJUHWtp2XaqJT+egt5caZaAyE7hbLuxj8zxKNqBtvc4YCqW6Vfm0eIpnZwvAcNmZw/06EkaWZ0yxOCOjiwuz0HwK9N9PmkiH2Dl4hzTbNGWOnHpNb5duyTp73hTwTl1sBcytz8Wt8YjC4ii133+djcOj3gzEN5vs5nXJlXBqEhJdapJQ+fzK8LV9foe5DlnVSLOm3XV9NNzZMiPq8IhRPxFcyb+VojPukTSuZDkKXeVPFF/xaFvfr+p4HNh0yN2Vq82uf+x7ymSef9Mgb/MEphP5Anvvie3U3QaNtqA4kXfjU85f7QFvG7m 5t9OCflu WKa4PDHaTK5eRKVwloenvxsRncSDXJOBWRERjefglM07TdwIMrs5y/doTAgkE6eyQySHxY1J2YPo3rkHPj9Ib2Kkm6dz5dvClKxpghEI3Y9dPuhbAOHPfbLDHStKUP+Lk0HnUdPJd/ma6aHgaEsIGx7EHquGKnW0BV/3NTg2SrkPBXy8HjMzSeSte+ISafEEHSP8kpNxAJt0XGvU6usVgYYjC1ppK1E6i5LW8cvpvk4WIWRNTAu4ziaaYPeeby8Y6EIzeN6nnzS21hkmWtVUbX2PjJbzEUI3HW8RBlXtnFAdwbZs1Kgc7FifKpCwiCyWoZhiAs27fFInMKvkhUEwaSyDntdaSWuQ2zcA+INgSZuRwkq7tZvrwvCtRQ2gBZyz2lN1RkihRQNC7w1uyrWXC1QGhzLPiFnWXPw8QsNygNEuZBDuTKaDmbGRcAYjEBHSgI5DTPbVAggvpqNfltRg8uYGeIHawbtwtpZStUPkjsf7nmB6E+++bTwsxZQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Jul 05, 2025 at 07:17:12AM +0000, ankita@nvidia.com wrote: > From: Ankit Agrawal > > For cache maintenance on a region, ARM KVM relies on that > region to be mapped to the Kernal virtual address as CMOs > operate on VA. > > Currently the device variable is effectively trying to setup > the S2 mapping as non cacheable for memory regions that are > not mapped in the Kernel VA. This could be either device or > Normal_NC depending on the VM_ALLOW_ANY_UNCACHED flag in the > VMA. > > Thus "device" could be better renamed to s2_force_noncacheable > which implies that it is ensuring that region be mapped as > non-cacheable. > > CC: Catalin Marinas > Suggested-by: Jason Gunthorpe > Reviewed-by: Jason Gunthorpe > Reviewed-by: David Hildenbrand > Tested-by: Donald Dutile > Signed-off-by: Ankit Agrawal Reviewed-by: Catalin Marinas