From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91067C83F07 for ; Mon, 7 Jul 2025 00:54:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 20F736B03F8; Sun, 6 Jul 2025 20:54:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1C05F6B03F9; Sun, 6 Jul 2025 20:54:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D65B6B03FA; Sun, 6 Jul 2025 20:54:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id EFFB96B03F8 for ; Sun, 6 Jul 2025 20:54:57 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 71B46160298 for ; Mon, 7 Jul 2025 00:54:57 +0000 (UTC) X-FDA: 83635649034.24.5CC7CED Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf03.hostedemail.com (Postfix) with ESMTP id D60412000E for ; Mon, 7 Jul 2025 00:54:55 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751849695; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DXwLXpgMqwmjSqIwN+HfmJc4KmxY5n1eY796n5sJNvA=; b=bF5vCDq0WgyIf2fjF+Brzub5Jorl/QqPDzFJFWXHCC8dPYIiQIDwZPuZsQq8NEQMg6X7nt 5coHhuu9HIbpG5IqWXtl6PT59RiVdWCLXiZKoY1Ji7Z2ALQbcaT+G8EOoMCky4bbRwvGil I2zukjoPtpYh9coalCSXp+zQcy73uKk= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751849695; a=rsa-sha256; cv=none; b=MFwVmMnnJYlZQCeYex7+GgDh1T27JVV3JC+0/2XMvIxn46ybEvHBjvh7BnOKtyYAW81QQp 9BpVzGyWro/p//QjXpBvYuS8Cehm1MY0sZsU/L9Co1ZRoA4pQUFLMjV0DyDKrPbo4+Re8k VuT+znLOsMmp5jAKJYm3bnlcdfBPNXo= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id A5AE75C5530; Mon, 7 Jul 2025 00:54:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AC3CBC4CEEF; Mon, 7 Jul 2025 00:54:18 +0000 (UTC) Date: Sun, 6 Jul 2025 19:54:18 -0500 From: Catalin Marinas To: ankita@nvidia.com Cc: jgg@nvidia.com, maz@kernel.org, oliver.upton@linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, will@kernel.org, ryan.roberts@arm.com, shahuang@redhat.com, lpieralisi@kernel.org, david@redhat.com, ddutile@redhat.com, seanjc@google.com, aniketa@nvidia.com, cjia@nvidia.com, kwankhede@nvidia.com, kjaju@nvidia.com, targupta@nvidia.com, vsethi@nvidia.com, acurrid@nvidia.com, apopple@nvidia.com, jhubbard@nvidia.com, danw@nvidia.com, zhiw@nvidia.com, mochs@nvidia.com, udhoke@nvidia.com, dnigam@nvidia.com, alex.williamson@redhat.com, sebastianene@google.com, coltonlewis@google.com, kevin.tian@intel.com, yi.l.liu@intel.com, ardb@kernel.org, akpm@linux-foundation.org, gshan@redhat.com, linux-mm@kvack.org, tabba@google.com, qperret@google.com, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, maobibo@loongson.cn Subject: Re: [PATCH v10 3/6] KVM: arm64: Block cacheable PFNMAP mapping Message-ID: References: <20250705071717.5062-1-ankita@nvidia.com> <20250705071717.5062-4-ankita@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250705071717.5062-4-ankita@nvidia.com> X-Stat-Signature: c9dmxfuejr4aegd9a7rnp9p31kce8dxp X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: D60412000E X-HE-Tag: 1751849695-839752 X-HE-Meta: U2FsdGVkX19hioDV7aLKI9AjDIqJdrQ0FTyxy0YMG2X/cXxrYyvzoqlkgAL3t6EF19JFtEvDoc2t6bgb2Cj6u3DK8X5Kg3Yj+xj657LtcJN4bn0ceVUh8uUf8wDYp1MjqKHj3MwIT4ZVULI4zVO92Ws0C674Qa/jL0JmRoNgJHNye/GXPCwTnLimEw5C2Th4YjOELiRZpYWNmluB3nQQ0vw0Tm6VKr4Ix9VqkNqo1ouUQsvQEil3wrgBTXJgsjmg6UvgLSZgmMbprYVtdUvIqUOAo16hrVlKNg8vNC8HSC9Ztxl7a1Xu9k81Q7V0AYS/paQsu9StbpYzM2lTRM48rTijbmuVkUj0TbgdTmnG1tZWXeni/9v+xWOfYrnFxvNJGfrJUJIDozTNdf03jFr+kKfT3QrPkj7N4Hf0aqiCz26yFTVgOaOXuDQ/9LATN7J0ZjfykfBko2r1i8pGj00e5m5W3EqyJ68I0o0fuQaB4Lz3ms5aRkjQI9DbqCbMNvGMrDpTodfTNEyWLfe3EAS+jVniAsH9CBQQhKDJSSQG2Vh5853UTl3U43mhtQKXWrknCComCyiWubZvcG/TnM9atiiwsrGBaFATmPAbGCXOD7SI1DZ0rJk8MEMxvVv9O4O87gxP1WqwrZxXCDoHMKEm/lMOm68CEPgdWcjIuc9p7syUA0RxqK6MiI5mawUjCgTQEO9DZgo+0ewnxxmeon6GV7gzr3TDDHJ+L82uQkgHaBWHjtcyIlkfXBRll39/6pR7ph5W0LCTOnT8zL9/SWRAnyPq1agnWISrpPvfQ61pvuvfMkCOyL0lL5gB9lSrC6PLpdRuGV0JN8+VTdfWrefkCWi705j14TUzB/a0t0309YicvJKEN9lARC5UHiEqQlFomBR2iPbMm9+zSp5YaukWvCa6WmtPcHcj44MwRPGUefL96o6LhUmsv9jahzdyvWxw7ttr8icWzQC0BqcmO6J dm15dOI4 WqbDCqLZvLWnecAFDIijiMMwJGtMFRscIITmUYzSdgdRjdeVYO5HR6qPjh159P0S2DpPEJIfBQBoRQQs7CVk0LkcXMBVntip36hluam08pOJ5Vj+l65VF9d30wWBqpMXhB0YLuM6d5XBJp+fH03+x01y2kT+woUvrdCJEGaw6HxPBZ4xxVRrhHuku6fFI/ZStIdeP7ribSG1aGdDeyp3ez70ga0YKxO0w3Y8zO+DvincDtLX3fsNj7MewI6Znef13r5Ac4NGvQ4t3LyGSe2OZkA/TBoT9lPXX9npf31QQ+YwUJsaKrLLMGBUQoiE67wHE1O2xXh8n0rpSz6JMzZ2/ER96LfNMz88tkIicwDyqMmm2JSx23r79OvYICFSH47TIuFoRhV3Vqnz4aRwDATZ0BgMHhxY1Qo5GTcQoXJ9nMKOL06iEd7jxgLqtnShzXUUSOk+4W3Maj22ePUKW2Veko4xyA9Vkpk7aePVG X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Jul 05, 2025 at 07:17:14AM +0000, ankita@nvidia.com wrote: > From: Ankit Agrawal > > Fixes a security bug due to mismatched attributes between S1 and > S2 mapping. > > Currently, it is possible for a region to be cacheable in the userspace > VMA, but mapped non cached in S2. This creates a potential issue where > the VMM may sanitize cacheable memory across VMs using cacheable stores, > ensuring it is zeroed. However, if KVM subsequently assigns this memory > to a VM as uncached, the VM could end up accessing stale, non-zeroed data > from a previous VM, leading to unintended data exposure. This is a security > risk. > > Block such mismatch attributes case by returning EINVAL when userspace > try to map PFNMAP cacheable. Only allow NORMAL_NC and DEVICE_*. > > CC: Oliver Upton > CC: Catalin Marinas > CC: Sean Christopherson > Suggested-by: Jason Gunthorpe > Reviewed-by: Jason Gunthorpe > Reviewed-by: David Hildenbrand > Tested-by: Donald Dutile > Signed-off-by: Ankit Agrawal Reviewed-by: Catalin Marinas