From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD027C83F0C for ; Mon, 7 Jul 2025 14:54:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4DC388D000C; Mon, 7 Jul 2025 10:54:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4B5BC8D0003; Mon, 7 Jul 2025 10:54:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3F01D8D000C; Mon, 7 Jul 2025 10:54:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 302AE8D0003 for ; Mon, 7 Jul 2025 10:54:55 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id ADFAA109D83 for ; Mon, 7 Jul 2025 14:54:54 +0000 (UTC) X-FDA: 83637765708.02.6A22668 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf07.hostedemail.com (Postfix) with ESMTP id 7300740008 for ; Mon, 7 Jul 2025 14:54:52 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=dzLlM0hU ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751900093; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=o/+i29+EsaHRjTzivT96VVcgGobCX8dLFJXYN29x5S0=; b=0F7BZ4WlU28UKP0FhEzenv/hUu5k7oikyt8EXL7yLlKY1MbOBktlaiFHxBWJXdammI1QbC X4G4p2/dIP6RU0ep0LJQ7zjhi5vUZUXYaPKRRcTP8GOlIKew0yFoJ8XyYJsbQjsmnHxJss aoxrV2BvPnzKtD8hkoRIl+VzRKaPjwc= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=dzLlM0hU; spf=none (imf07.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751900093; a=rsa-sha256; cv=none; b=BZZQ5MDGIU3pggdJvvGjpIe6hxcQmlc3wVqzS5wO7XE2TtpdnbJFanq6U4Vf/A8EmhUEgD H/zAGNi1SMSfMIB3FjZyQZgXGSxsxTr0Ecxc5yNvSwudUlEfCjfm5jln81Zcrg9P6b6wLt kAyPsOtVGjRP3oqt/KOO2BEqLTVstWY= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=o/+i29+EsaHRjTzivT96VVcgGobCX8dLFJXYN29x5S0=; b=dzLlM0hUZ6iClIBOvZOKXBqq2C E+u6WgXHMDatqhaFYT9DdBAsUvrJjBRgmCufxUccg7Ddlr8RI5+RqFOfxeQ7SULeoE/ttv6qtPi79 PMnphhz4vZu/BGyg9DF5KbWGTH5EFGB1GWGJ1qTRCdDkIqXo59u6NRG4KLeO/Mv626pnjHXYNpCuo LLPCNwfiLl6JUdeas3gqP5it3rgyFRu2il+fOheOCmaYOeq8YegBZDuKgqUVYw6KyC+VekTOg+AAV luqptV/g6COpriR6jZHeFGHPBY7hwh0/fSQBHyR81gGP6XUixw0hd63szAfYMVfU4PY0+xQTTrFeQ aBx8DwuQ==; Received: from willy by casper.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uYnEu-0000000DVBX-0MLk; Mon, 07 Jul 2025 14:54:40 +0000 Date: Mon, 7 Jul 2025 15:54:39 +0100 From: Matthew Wilcox To: =?utf-8?B?6ZmI5rab5rab?= Taotao Chen Cc: "tytso@mit.edu" , "hch@infradead.org" , "adilger.kernel@dilger.ca" , "brauner@kernel.org" , "jani.nikula@linux.intel.com" , "rodrigo.vivi@intel.com" , "tursulin@ursulin.net" , "airlied@gmail.com" , "linux-fsdevel@vger.kernel.org" , "linux-ext4@vger.kernel.org" , "linux-block@vger.kernel.org" , "intel-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "linux-mm@kvack.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "chentao325@qq.com" , "frank.li@vivo.com" Subject: Re: [PATCH v4 4/5] mm/filemap: add write_begin_get_folio() helper function Message-ID: References: <20250707070023.206725-1-chentaotao@didiglobal.com> <20250707070023.206725-5-chentaotao@didiglobal.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250707070023.206725-5-chentaotao@didiglobal.com> X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 7300740008 X-Rspam-User: X-Stat-Signature: 8bc3hegfairbpioh764a3dj7booaqi1w X-HE-Tag: 1751900092-822753 X-HE-Meta: U2FsdGVkX1+W9t3/WzDn5FLLsB5CDlg8FayES/jFREn3be49ea/nL160CJSisaa7A5c2/kb8O+KbplkqBkvdqS4jMeeQyRISYHhFkZ2VhIKOAYZa0k1dADRISc1DPGQrWqFY4Gf7B38YanVsN/weirLY+UATrMcwWjDw6Q5ZwyHwIHU8Dq0W3+xL3QaCUbhZ9cJkgPu8CiqqY6EgCxWWoONaLeHWImmDh+HXZ2diKoFYQ2D4xXRAap5wKU5kmaQnFLkH/HAge3xlK7jiXbKu4tiw7Of7PAR6XV6JTZTYca/c8yDh6Kl4IZKQxumPzvQkqpYVGN6dcEunxT+bCPVasnnWFZ4AF38yX10dEPGCPLHhZbrDTCecG1/HvOC+vExzxZxEzIZCLUh9ZDt0qDXWG9dTmb1EMj7ScO4Lfe3TpWdao98SCK7wUEmT5ip0O8dNbSXkeHc5+ARkQhP/EZTD32LoRrWHMhBmRIIq5iCU32fKfCvEHv4svgK5+ID8ie55WFTI0Zlgh5RAJeccVVd9oJ2o/jc94yZ98bQUVo2S0a64dAP/Eeg2Dvoj+tyHhmk2l4qzbgKPp2DKBHvap9G5ZF0r+evFxHFj8Bu4iQ9gtdOXq6+bAbH75eL3/G6VfTEKR7XRGetKrvOcyJRrv1iH3e/h8ECfx4Ja79sj3QJ2VD97QeMj0ADEfqiLXQEhH+7Alq+vAg8rihWf9Rn17Mi1AMNCbch5VYj7R76PNJuJH2zUElkIKWtD12E5jCKoBcFjdo/gzFPSZrqN9kfraALpDf17lpHYH++rjx6MjorU38wVz3CLL6zLlKJ9/Vl/a8UyPUp2weNE/RcWeoKImMIbntaMkBf67EGMmhPToh4wNlAN1DWSYNb7NEyPWK0S1syE1G/WR21+xU0CPM02jvCqSEp4veK0ngYusk+JwIw/ycVCHiA9vkG5sGsP0jmKfhnSw/0PkJdkEq4uSHvXdKc bJ2ijAfT cn0M7jlJXqcjO2ltdQ+GmcrGB7zhlqDhf6HiOK1fb04ke0xWPzVv/+EcLDrjv9d8ItblmrTB4mlatx4Q/pH9aiiDf2kUgh8GbTzPYzV8hHYu3bxgu2BsdoFKUYww+8kqUmnR+DG0GwnhGWJRC56QFBK8to7YbypeIihFisiA1mzS6XdP1h7pCdVHwfB836EK02mUuTJfJPso4j9ilkZjxQiZBMKwUBby4w0A2HyIBxTaAR8235B0pjFtL/E0YJbPt5arD1R9gAUaSzMLb0Zufwx4+KZM0MTxcWsZv X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jul 07, 2025 at 07:00:33AM +0000, 陈涛涛 Taotao Chen wrote: > +++ b/mm/filemap.c I think this should be a static inline function. I don't think it's worth moving out of line. Of course if you have measurements that show differently, you can change my mind. > +/** > + * write_begin_get_folio - Get folio for write_begin with flags > + * @iocb: kiocb passed from write_begin (may be NULL) > + * @mapping: the address space to search in > + * @index: page cache index > + * @len: length of data being written > + * > + * This is a helper for filesystem write_begin() implementations. > + * It wraps __filemap_get_folio(), setting appropriate flags in > + * the write begin context. > + * > + * Returns a folio or an ERR_PTR. We prefer: * Return: A folio or an ERR_PTR as this gets its own section in the kernel-doc output.