From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08E1CC83F1A for ; Mon, 21 Jul 2025 15:57:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 96C886B008A; Mon, 21 Jul 2025 11:57:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 91CCF6B008C; Mon, 21 Jul 2025 11:57:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 832956B0092; Mon, 21 Jul 2025 11:57:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 74B5A6B008A for ; Mon, 21 Jul 2025 11:57:45 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id EFEB51D9B87 for ; Mon, 21 Jul 2025 15:57:44 +0000 (UTC) X-FDA: 83688727248.13.5F7E842 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf23.hostedemail.com (Postfix) with ESMTP id 0C97D14000B for ; Mon, 21 Jul 2025 15:57:42 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=none; spf=pass (imf23.hostedemail.com: domain of catalin.marinas@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=catalin.marinas@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1753113463; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mCzTE0/M04ZrBoYlaj7sUzSG2J5ofpFGwGe0LtgTQEg=; b=ebnnjQO1ba/4ZL+a46qqY66YS10fRiZru3gNXKinkch4dNt8rr43TmR5Wg1O5pg4QFhbVR +Q275dii5cxMkFVxS3u5awE1VPbUuZJXFpzbsktZ5Zku4JnGLOTOEGyOn8+/q+ndbC8GC0 ldDMRgyqNMCrWW9mx00VZ10cKnXat9g= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; spf=pass (imf23.hostedemail.com: domain of catalin.marinas@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=catalin.marinas@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1753113463; a=rsa-sha256; cv=none; b=x53wCXuUgtAbbcdzAOn/J1eA61i+rlP4rpqSEeAOBixytZzK5buGvMSNQetFP7ENbepWyf IHTKGKBEgxyK490EAdpRkkuwWSWUdMcZbncmFZil95CapzqvWJFkD1aE1sqb8yn0UnCj2m HhtldDCJLVi8Z/dKNKOPi7hjIOi78L8= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 34CDD153B; Mon, 21 Jul 2025 08:57:36 -0700 (PDT) Received: from arm.com (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D597F3F66E; Mon, 21 Jul 2025 08:57:35 -0700 (PDT) Date: Mon, 21 Jul 2025 16:57:32 +0100 From: Catalin Marinas To: Dev Jain Cc: akpm@linux-foundation.org, ryan.roberts@arm.com, david@redhat.com, willy@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, will@kernel.org, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, vbabka@suse.cz, jannh@google.com, anshuman.khandual@arm.com, peterx@redhat.com, joey.gouly@arm.com, ioworker0@gmail.com, baohua@kernel.org, kevin.brodsky@arm.com, quic_zhenhuah@quicinc.com, christophe.leroy@csgroup.eu, yangyicong@hisilicon.com, linux-arm-kernel@lists.infradead.org, hughd@google.com, yang@os.amperecomputing.com, ziy@nvidia.com Subject: Re: [PATCH v5 7/7] arm64: Add batched versions of ptep_modify_prot_start/commit Message-ID: References: <20250718090244.21092-1-dev.jain@arm.com> <20250718090244.21092-8-dev.jain@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250718090244.21092-8-dev.jain@arm.com> X-Stat-Signature: hm45uq5cmzjpoum9fd97afp9hxaaypas X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 0C97D14000B X-Rspam-User: X-HE-Tag: 1753113462-407563 X-HE-Meta: U2FsdGVkX18Naq/xbCexOdsx26D2ifPezlZlYLKvTcLM3/QOymJKQ1iVs3WRxOO7IBqhlBOI1pxBHQJ2t+e+JJhQDYkr0/CmpBPfKjZ+8ArzMnEespL5otpmwCnlR7GPOoyakTVbRvse5YcSLYv2Kf9TZOjqDULBnf1zSpWJCuu43EUB+6y61DYmpsrhU3zqPORqwD3tFTWgZhpt7YDCkN7ZhkV9ruWbaZZW1rf17RV6qT/NzBENPstF8urwCLZ0AscfVsZ4zlRH459x9vk9oneunNWYvf499Ryy3IcSOBFnNaKJ0h5RPKargAOduHNA/RnBAbr47XxKaWBEyMLD6fUt/T87omxCcJUVqiAqo40EGO4jKgVwT1TZcX7ZTnqGdB25aU7XuBsA2Ajiro0I58xyt5+jmaILtGr1oxF0v2bgO1M1iVeHPonlbESQ46jaJvrZgk7fRzEFdHF6ZZVncxp9vJItVJFWdgE54vykXZY8A+aaonSGX2cuk9TH7WOwZ2oZyNGts8/mbMlQ1/OIXG87XCOAbS681wZ9ODbGE4/adB7VEMzPk/ygw215KHfHD7lBx5zHRtfHPzuBiTQctYJGZf3tk18dkqnWxyo5fpcnYxkVi5cvx/UN3+6RNdOSBOMMrRU9npoUXRhz7gMp/oS0iMEObgKkvawtpmYzuYpHRkOo4KPkmdpUdyMkoJbzmfG9ENJmnJ+SwJqpMP9trh252uuMRACeztqkfn83tU74NS9OJauENog1GuAGoir8oF4/vFScVK1Di7E9dPsUcf0QmSKwwYPnuP+U3gEdWy9Eo3d4vdnPrw9X5mfFp7oBvhBCSLDli+rxzwvietiFbc9biRpee9iH77lvw1YOHiBaQ17ayy7SxnXB0TQV4GNLAYXCITEmwI8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jul 18, 2025 at 02:32:44PM +0530, Dev Jain wrote: > Override the generic definition of modify_prot_start_ptes() to use > get_and_clear_full_ptes(). This helper does a TLBI only for the starting > and ending contpte block of the range, whereas the current implementation > will call ptep_get_and_clear() for every contpte block, thus doing a > TLBI on every contpte block. Therefore, we have a performance win. > > The arm64 definition of pte_accessible() allows us to batch in the > errata specific case: > > #define pte_accessible(mm, pte) \ > (mm_tlb_flush_pending(mm) ? pte_present(pte) : pte_valid(pte)) > > All ptes are obviously present in the folio batch, and they are also valid. > > Override the generic definition of modify_prot_commit_ptes() to simply > use set_ptes() to map the new ptes into the pagetable. > > Reviewed-by: Ryan Roberts > Signed-off-by: Dev Jain The arm64 changes look fine to me: Reviewed-by: Catalin Marinas