From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9B59C8303C for ; Fri, 11 Jul 2025 07:44:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 40FDD6B0088; Fri, 11 Jul 2025 03:44:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3ED3D6B0092; Fri, 11 Jul 2025 03:44:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 327E46B009D; Fri, 11 Jul 2025 03:44:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 20F0B6B0088 for ; Fri, 11 Jul 2025 03:44:26 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id D426DC0B59 for ; Fri, 11 Jul 2025 07:44:25 +0000 (UTC) X-FDA: 83651196090.16.C9E0F5B Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf08.hostedemail.com (Postfix) with ESMTP id B02D316000C for ; Fri, 11 Jul 2025 07:44:22 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Xjps7REC ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752219864; a=rsa-sha256; cv=none; b=O99DKr5sZ3VUfQWxVRT7qPGDQTdNfw0st9vRwt98Lv/r7394lFBU0gfvTR2CHjZ/1nP1HG mVIrlinGu1EwRC3rn4OKJOOWJEKPMfQ/1c4ng8u9xYrAI00p4UnVhF1SdWyhbWb6IJ/oLJ VrOdENnlueqeuUhzY0fyKv7vCwm+AsU= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Xjps7REC; dmarc=none; spf=none (imf08.hostedemail.com: domain of BATV+ed71352b9bc4c4c95692+7992+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+ed71352b9bc4c4c95692+7992+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752219864; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MuN+Al+ugsSZkiKtnKTZ8BlZNb3ssd//9YQiEWcYVm8=; b=ATCFvqpRYpH9bad3gG8REqCUhQp/RyXHo3/1pLVwR0WdYn9R4rf7W6PYjWFAQL3HN/7Oul tEzQor98CUHMxB0vjpwWa/I+9fxIl6wbTpTrGgGkESUPp5LWvY63eNt90he6Csi6W9ZQpa ekcFDpTUaWwAtscnfODEtg2jCuXdrNs= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=MuN+Al+ugsSZkiKtnKTZ8BlZNb3ssd//9YQiEWcYVm8=; b=Xjps7RECqthfJ6sxTSYVPLQiwL FzRrLdepGyG++mr80FZt1bYSukuJvqWcE28T7MklVGBReJeVe6c+cjEiR/3apon0YHkvo8aielt8q 2Jj8u5ZxARHYNrRD7yH3T+06pGXoSQ5AbLL4RQSwUe124QQb6uaitby2C1UcIAKGCN1FyCbQop8/r Sc/vTm3IZlrTeOS35wdoaqU3fHCpPLc/3ipSbwEAGTyhK6m2Qrn7b/TrJ37UQEF5qhm8nxu82sd31 kbFATO6xtLxdP72krGpxaIxtONWHCNqQBPSlkIPNECKna64yqGoD8op3+wjeduEja1pJZksxyxWps cnDDlHDw==; Received: from hch by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1ua8QU-0000000E0sc-16jE; Fri, 11 Jul 2025 07:44:10 +0000 Date: Fri, 11 Jul 2025 00:44:10 -0700 From: Christoph Hellwig To: Jinliang Zheng Cc: hch@infradead.org, alexjlzheng@tencent.com, brauner@kernel.org, djwong@kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-xfs@vger.kernel.org Subject: Re: [PATCH] iomap: avoid unnecessary ifs_set_range_uptodate() with locks Message-ID: References: <20250709033042.249954-1-alexjlzheng@tencent.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250709033042.249954-1-alexjlzheng@tencent.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: B02D316000C X-Stat-Signature: qkoa8x1tw7wnm3xw355h7jfogwdzkjfx X-HE-Tag: 1752219862-410183 X-HE-Meta: U2FsdGVkX18gaxDiQXLMS0sp9dmTDbMVampNCF360/SBSi9HXfY/Bwh7kveSQwTsuKEO2EdtGfUVRyRbDTKndWPl1KG9b8X3Y5AFh90t3cMns03NQkNN3UA6bW90+MzLL5TMQmqbWxR4yrXGPptgcDoAgFyQNVuVfd505L1Qd3r4UINIKa/oqr+tsOeaYIIhkqoHnIovd456FMhMjdLRfrgzvW7fQc+3jYbqc3MhfLEUF+didofrQwd/AF8EXVqpR0h5oLPly0A/e7QZTX1Lh14ZT+i97zdT6DSJvVoYPyurXB+dkdC18RfiF/UDACRcC5DJo2BWRv0y5hp7TPzXp4rKuqTYJZ5WnzVmxFuIW+bF/UwbkpCbEOICd+4UgJBltwjpktWMZvOc9gmmF8vI4cXF6iBHksS40iZSA82PZWfO1ZT8U7BaDZkfzgKBbS9IxRX/PMfOwXC3YUL2g4Veh97h3H+PbB+Fa6npnoMEz7kVLPz2W+th6XdNfHSMRSWxBVKK7Qauq5YZdsfs4E9ck5kF3k8oMi8s4Rg3LlJ2X4AguvVxzSuI4RLNzbTnckChIke44A1VGQ5iVBSNZz0HLvWzDumY2S5refp4xnE+PYwZzQEet/jGACGzYOQaS2IGYmuIjcrQmjm2hh1NflmizlK9ZyyVmLJm2imobAr5la+PPgimWvMd4Q8EnieX/KPYH6e+zpI/4CCn595G5n/YFBjoQunNavyz0hhFlIpC+J6ndi5F7l+khbLgnrh2cwWlKuVftNqD2PbM/dlILhNrKITYDrYnT2a0EtmdLIK46pkqeA1Oaj4kKgvBSG3zVr3J7UuMELQT4qo4uMpPrYfKO4NJTK27SPRzQrA0qGNJ09/rqklnr2/pIeKVKEVj7tPyGdgiAfvLY5iJE9tRqGU/V18lCNfk7QtsggVp06yKFXMjqZteNZHEJApVQlcpT+jeBcuG2JOruzfWu43qHwt LPuaWQQM EzB1p48labR4uWUgDGFC6mMYyoIFeTIG05IBV1dtopPAEBvOtlM7Uhhi9iKOki6hGAhtj3huJdHMbS9DzP6dh302mg+7nbzj8EUEFhFnEX9Vyd2qDN3FdNoUSD1Fsg5gfZdkZnOhtXu1HSz8TLctlP41ld5IVdQkJNEmU6e2l7ljFMLv0CgKtudqMGSTA5c2BvKOu7RgeVM+O3fFxbjR67JmBcWRMU6/DMF7WOgyAQDAAX1afqOiL1EvjBRo9GDLOmR/zYPnNZ43DPgsLC/6m0+B3x8ErOLAxMSvVX4UowXT2zWtuTvS9f/4NsuWL+FP+v3sr4tFzy3rIECrejmcRYzo5hEFJZprJ4+WLcElHCLeNvn6iYIHVGmls+h0zNV95Jy8OVjpTPRqQDUz/jda2J2esMGMvha5jwJ2Y/A6BKQFL3xT28RgnQa/QHQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 09, 2025 at 11:30:42AM +0800, Jinliang Zheng wrote: > In addition, what I want to say is that once folio_test_uptodate() is > true, all bits in ifs->state are in the uptodate state. So there is no > need to acquire the lock and set it again. This repeated setting happens > in __iomap_write_end(). Yes, that seems fine. Can you update the commit message with some of the insights from this discussion, and with that the patch should be fine.