From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43A04C83F10 for ; Sat, 12 Jul 2025 10:41:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6796A6B00B4; Sat, 12 Jul 2025 06:41:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 62AB66B00B6; Sat, 12 Jul 2025 06:41:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 519046B00B8; Sat, 12 Jul 2025 06:41:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 3B0526B00B4 for ; Sat, 12 Jul 2025 06:41:54 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id AAD1F8018F for ; Sat, 12 Jul 2025 10:41:53 +0000 (UTC) X-FDA: 83655272106.24.A5FC949 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf06.hostedemail.com (Postfix) with ESMTP id 1FD81180002 for ; Sat, 12 Jul 2025 10:41:51 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=awhjzOiK; spf=pass (imf06.hostedemail.com: domain of rppt@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752316912; a=rsa-sha256; cv=none; b=HvbyoYx51A826R5vJ9Zw5RUXUiMXO87iKJCcV7RTumIG1bTvzBlY9pQJ3yVSro8SZcAc4e sdt+oVMht+1sa3AVQmQLWsmlex2eE0QzAP3GUciq9leEHNg7fFiEntsOlxcoQJWUMK111H CdwLH2f9aRD2ip68GUeZZM26Bva3pYU= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=awhjzOiK; spf=pass (imf06.hostedemail.com: domain of rppt@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752316912; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ARH6/pSD1MmUMdGUwWzucBJKR1YjK2YE0CYevAgCDPw=; b=vFVB2OWOU9aDF9thdPHNHp34qBMKJHLEzhFhbbulRwElE4PIWUkBTsZT2fFwFaR67L6bXf 9SF8VigFrA3Har76BfcLzbxmCfvz9NF6SzfD2moTAsSMv+lNLgQ34vL1+BCNJv/1NyUf3O WlU4yNT1nQln8bhW8TAhCLVoOJcf7eA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 0C07860007; Sat, 12 Jul 2025 10:41:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C175EC4CEEF; Sat, 12 Jul 2025 10:41:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1752316910; bh=uhkko6lxzqS4fMuttaVaa4hYcvfET1Jjb/aEOaNG8qU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=awhjzOiKN9yS82/DPfNPKEZBLSnG5fAeiYvYyxQpZ5Qnp379MywJtNnCU2EpXhpQj HSyPbhi+X/el+Vyqy4tlgLHm2NnJYwsqFfv34zxieb5PkawZQAz8/vHf5YaNwTv59U H7jT/6PVDGiwT/zKASqWLKkquco9DEWyjwUMtzQnzY6tU2852LA+Th/rxuRiODnoAd d+qjtzAGaVCQg1oGgK3Us9MGFN8hEJk7GRCCZhTk4xPnLMGiy/bz407jNeuGxMjvTb O5Gq9ZRNHw2P1Mj7C7dOM3+oWa5RILXuXWrHFApdBBOi0OJ0nPvpTT46tcN/uawJ3k ttnwEaGIequtg== Date: Sat, 12 Jul 2025 13:41:40 +0300 From: Mike Rapoport To: Daniel Gomez Cc: Andrew Morton , Andy Lutomirski , Borislav Petkov , Christophe Leroy , Daniel Gomez , Dave Hansen , Ingo Molnar , "Liam R. Howlett" , Luis Chamberlain , Mark Rutland , Masami Hiramatsu , "H. Peter Anvin" , Peter Zijlstra , Petr Pavlu , Sami Tolvanen , Steven Rostedt , Thomas Gleixner , Yann Ylavic , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-trace-kernel@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v2 2/8] execmem: introduce execmem_alloc_rw() Message-ID: References: <20250709134933.3848895-1-rppt@kernel.org> <20250709134933.3848895-3-rppt@kernel.org> <784081fa-0fee-4df6-b8d5-6435eead877f@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <784081fa-0fee-4df6-b8d5-6435eead877f@kernel.org> X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 1FD81180002 X-Stat-Signature: n54ta9c6aeo4pixo1g65p8fdahop7qr6 X-HE-Tag: 1752316911-891566 X-HE-Meta: U2FsdGVkX180yXQ9sKPgoqDHnJrhGLGCCGabOt8nSDOb8D4lwkUuCyMINqe91X/YyasYfKNeznV3ZF3kXXucSQIT6r81l20AzL/1cNiWwpS4xasddJUCN/zESObKrMWpLX83FglVYjSrZK7JrNxiYDD3Ap9mYvDgQj1zppSpTXSnMDhRGcEzGmrtQ6SrGlv/urXw9WrxOYsMfe8za1ewe95aZNz9MHSIypTpLOnhj8wqIjw5QN6WmYS1WujLe/XArVopBok9JmepCXAvz01C0QBPPNndMZ9g6/0hgHu9oeW33WaEeTFDBDMhdnX1xEknavJ9ylfh4jxtu+ielQxuBD0+Zs7me9s3f4i60jssF28JemDl6ULQW8IQ1AZifPaZajJgBs2VRVwN7/EOoI7MXdMxNAdh6x53fKMXDXy7tSwvRTjY1xvYJCwarrRrorN1oEcuM/0qtooVZGIJ7WPzou8FKdCHh4lm3LoYZmeCAVzRJEiGSCHN2GChLTZp+mAXWXQvIhU2xeliXfYcXB/i9MNbrMK1hkuf07DResmk02tcurehXyeYYS+B3idrsY4vVVdN2OZJttaCO4/XN6OTl0xjnyI8XrCDQ7/9jvI3AmnyhcnsYFO3v/sPgf1fBjN4BqMf/c0nYKM6ZPbvm/xkktpgZ8xBf1lxS7zlS/+e/FQmgrGmDrQ9FAQ4IdrlTHXqO1XT3zIRIGQ0U1tNpY90GO+UIatsf5aMIyvmBd01GNlm76FLGMZw3X950O4Y2MKIKvjrGvFuI0DgrUQc5+vU9EKSG8uaNknKg0BQZhqPCK5qV/J8IWh86y9rRQwIKhHUNd5lwvc74fd8xaw0ZgGtyACRE9fUd+y9Sob2WrUflRwAuSwcEN8ang5HtLKAwms637u9+1igaW+sBgbgMCnXcJM0ksUm6jiVunfSRt0SwWK/pgdcx78cxFrPBHcfgl96viF/tZfy+zYuXUgzs+J Cn3H6iau WTIbFfMD+kSW4M+qgiXAyVcNbYiWdtiqmAVefrDshktWuLFmPIC0iDoRWgYt/5UIcGJ5FJE/jPMeJMt8Q83Nwu6ANC1TODNJIkbp4yD/KvWVP3yT7pNaTRMqyOzluFlSZx5v7IZdW6Q7wsQGmu8XVmV7HLwjCcfkEuUbnHFQ8sE6rUjOFQxxp36XwiP+DekrQlVyae2AszRnWqVQBNqXItoUKaKwtfo2pEPMGu9lAre7oTAaEGAYhXOhMSaiQBtGCVl8pU4CsjUe5v9P8J5l2HCCn24vbhwrxTg0iX9UVBvpF6jlvdj2G11wZ5AdcQ0EUDtgm2aWeoTJ6Shm7HshR7USreUoHEldI84e+fUp3cOKSoJTCeosn678V568gXVY6rdjbGrWnyT0o6RwWmiI4ToNgi2dpCrAScqjX X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jul 11, 2025 at 04:29:48PM +0200, Daniel Gomez wrote: > On 09/07/2025 15.49, Mike Rapoport wrote: > > From: "Mike Rapoport (Microsoft)" > > > > Some callers of execmem_alloc() require the memory to be temporarily > > writable even when it is allocated from ROX cache. These callers use > > execemem_make_temp_rw() right after the call to execmem_alloc(). > > > > Wrap this sequence in execmem_alloc_rw() API. > > > > Signed-off-by: Mike Rapoport (Microsoft) > > Reviewed-by: Daniel Gomez > > > --- > > diff --git a/mm/execmem.c b/mm/execmem.c > > index 0712ebb4eb77..6b040fbc5f4f 100644 > > --- a/mm/execmem.c > > +++ b/mm/execmem.c > > {...} > > > @@ -387,6 +397,21 @@ void *execmem_alloc(enum execmem_type type, size_t size) > > return kasan_reset_tag(p); > > } > > > > +void *execmem_alloc_rw(enum execmem_type type, size_t size) > > +{ > > + void *p __free(execmem) = execmem_alloc(type, size); > > + int err; > > + > > + if (!p) > > + return NULL; > > + > > + err = execmem_force_rw(p, size); > > + if (err) > > + return NULL; > > You don't need to save the error here. That, allows err declaration to be > dropped. I prefer to keep err = ... It's more explicit and clear this way. -- Sincerely yours, Mike.