From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 427EDC83F21 for ; Mon, 14 Jul 2025 13:23:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DA0926B00A7; Mon, 14 Jul 2025 09:23:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D77CF6B00A8; Mon, 14 Jul 2025 09:23:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C8E666B00A9; Mon, 14 Jul 2025 09:23:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B5C376B00A7 for ; Mon, 14 Jul 2025 09:23:06 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 0BD6AB6D06 for ; Mon, 14 Jul 2025 13:23:04 +0000 (UTC) X-FDA: 83662935888.20.BE8580A Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf04.hostedemail.com (Postfix) with ESMTP id 6F0C74000A for ; Mon, 14 Jul 2025 13:23:02 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=OLHUV3Ui ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752499382; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2uv57CtZpiuAjvDOswZuOxUwJAP5zphK+XJePPHH5gk=; b=c4Fk5Asl0cg0xwek4x2MrVp54er1tykY3fIJbZRkEKI9rCI4LGm5P+8h4ldUYW4M4g3V8d aj3Wrud7Z/POHLu3lojNyPWbnfz4xQgtE5FP9ryM/6yeVh2hYA1upvEF9DVQnEjQgrqMk5 eDIO+r1tvw4zgSgFDMEyHrauhl5qWbk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752499382; a=rsa-sha256; cv=none; b=CoXFC6E4RZhhr84EFVGEwk2Tk//EBKwW4PAqkI6Yl/W9SbCDMhLuwGtlQ1Xq3GhE+B49NS poWuSmZfHv7m/ABaSsRlcF7EMENZpMDjSBeTN9Kgf3cl6AqlysgabhKF5IEkBN+ojd5WXD kE0HXODBdS2gYCzh4ArXxTKqUhEaoxI= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=OLHUV3Ui; spf=none (imf04.hostedemail.com: domain of BATV+8a4ed83021dfd658536a+7995+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+8a4ed83021dfd658536a+7995+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=2uv57CtZpiuAjvDOswZuOxUwJAP5zphK+XJePPHH5gk=; b=OLHUV3Uic71jXM2HJSjq5EaZnL EuXIgZAn92tPI9T4uHGT0oQbOK9aXUo1aoxzaQZCjmgkSi4mE43+tNS3j/gbF542VLcmacz9NT/7z 4UrG4j5KiLJZxim0vrhcxzFTtc575k6nB0r2TFvsP+KTtNeLr9tEyyqkbZoOpZUVNkTvVNYuakesR A92l9s+FLdrPN/9R4yCs3lKtnwmvQ8enJMBJbq5tF7Hau9LNC5q2PbJzlQcrSsOLGG0/PStJGzHC0 Iljb6/RGnKVh5ZkjBIluAzrtY+KIGY2eaNlpQb330FuL6qciEYyOtCGOdB7TU46G+iTF3xtGscioP 5tjfqytg==; Received: from hch by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1ubJ93-00000002H6p-2R5f; Mon, 14 Jul 2025 13:23:01 +0000 Date: Mon, 14 Jul 2025 06:23:01 -0700 From: Christoph Hellwig To: Brian Foster Cc: linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, hch@infradead.org, djwong@kernel.org, willy@infradead.org Subject: Re: [PATCH v2 7/7] xfs: error tag to force zeroing on debug kernels Message-ID: References: <20250714132059.288129-1-bfoster@redhat.com> <20250714132059.288129-8-bfoster@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250714132059.288129-8-bfoster@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: 6F0C74000A X-Stat-Signature: dw7enwmo4kuzm8mddw3wqy69bc7r9rbs X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1752499382-4551 X-HE-Meta: U2FsdGVkX1+8mHIFYsdS35jTWsmrDV52dOThoEMv+vZ9ni9vhmDlxkieQsNtWAiTqK85c7DyKxsNf6GvjD2rmSrZZKmLmv/Y+9UJ5t7VVQG6Z0hk6bgtBENzdN68ul9jSg9cA0sY1pjgc/Y5zWBgEhjcWjlnBLhzzONuV1g01ezzIMexBgTb8ElpwPJSXjjyDvcVaut551b0wM9E3mtCGq5VP7wTL/vlCuIrygDwJ5O4mAm02FvGOtSnxomBl4i021t8vPBFoIUCj+gYjC5zhECdq9FhgEalUTmEH6AuoYbd+AiHBxgUMcjhgr3ydV1BHVEfvs5k2zQSSsfo9ar+0T62tmlHDOyXDmhJih1vsxoiVyeA6NSifSJOD4QprYHU8lif0LMtvvPDqtug1wWmlGKd+0oLJl0W/ZDMHQIUlWlSLwcKpm+CfoMFEtrplvIZaSuNJhek4UUzJFe2AillRSCkciswdUF6ot6qoMn27nyAUaTR6WbztMJjgrIcTajJdos1YPiu//YE3t08RFx2DW5BujkbnOH+lc6oWRy1D3fP2Wt/0CrcJLBN+5hyZ/fLSQ4PTMHzQDuiUcpUktX06m7G/13A2Pz6+WPbPA7g8ZQBY2/pFaVaFwt8br2LR/00H1k34zsAd9qCSZdFJpV99ub45sYofRz2hLF53pDlwlih4WRAXpZg5b4TF0m/+yLq69G7RYhv+1zI+Qzn6LhgzWzid11OEHXliAr7+gLqOQvb3xQZMkivWleW9jeOt6cG52ioDFBTQBfAr+zGA/0jX6uXAw5gDqJIEg5DB6lnYVfgvW/xq+OmWNWlQANkS+CCiwf78H2N+sw4AAHsWPjlDqAlGrM4Bb0JRHsw1U2DHWFDDKiCRkhMkd7kLpqbCItt/UOaEv0VOCz55iDVchddBNzU69dUkwBk5j32y0dmZlhPutt+GbbsSDGWTlBl4zcJGl+2Uz7zIwasqwIzHPl ZeZgWo9V Z7FJ/Qt+jko6ptiq1LNaheKId1ZkmYY7tk/TA20YVCCnHAPOuAtiXyCyVrT+5MOGlLjEaFQVS8IGbPpZrUkh6Q6z1HUBKIBC37H1KlZfp8K7sseS4rafqUJ/d74+HJYRCSfSl8uqKnXLeiTxIjHkvzX5oyF8DpgdXyfkMaU7EMpCFNuuhogKHsyWbrSfzuJ0XPdzhvRQc5+J735AHnmJ575jsyLlO7Z08GaEwr7CALTJWlLH/OUlEfPeHiYVrERbdPBR5HUKyA45FW8kpBphvx544scWeZns5tUOktnXjanOyBZqzxQILNRUg/W90JOOs46vn5zk0kcC0dKptAPrrDjLk1fO13sV5xejtVowGCn943qy7kn5tt5BfoujI7C3BYroHV4nMqXNd8kDrLEVEuuN8kGCwFxem0/Nk3GBbL9Yq1VY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jul 14, 2025 at 09:20:59AM -0400, Brian Foster wrote: > - error = xfs_free_file_space(XFS_I(inode), offset, len, ac); > - if (error) > - return error; > + /* randomly force zeroing to exercise zero range */ This comment feels very sparse for this somewhat confusing behavior. Can you add a shortened version of the commit message here explaining why this is useful? Otherwise looks good: Reviewed-by: Christoph Hellwig