From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8DA8C83F21 for ; Mon, 14 Jul 2025 13:39:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 422746B009A; Mon, 14 Jul 2025 09:39:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3F9846B009C; Mon, 14 Jul 2025 09:39:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 30F936B009F; Mon, 14 Jul 2025 09:39:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 23EE36B009A for ; Mon, 14 Jul 2025 09:39:06 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id E67191A01B7 for ; Mon, 14 Jul 2025 13:39:05 +0000 (UTC) X-FDA: 83662976250.28.B6CC9E3 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf06.hostedemail.com (Postfix) with ESMTP id 28701180009 for ; Mon, 14 Jul 2025 13:39:03 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QfmrUGV2; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf06.hostedemail.com: domain of bfoster@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bfoster@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752500344; a=rsa-sha256; cv=none; b=cMMkxDRlaZ9POaGaCtn0l61F0wg1eNRRK18ytyzt/4PbU9hACmdQiWDA6ZE1+YLJQLE6ZT 3H9hRIyGkU5E0ZM/X7T1GEM522702bEy/q3EZ5gdzFU99IJXmiQgFYmXb101mgtb20f0K5 UXqQ2ccF4Td71FCLt/9dE9831qmmeNA= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QfmrUGV2; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf06.hostedemail.com: domain of bfoster@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bfoster@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752500344; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=78ELezR9/WM68ny3VH62OCs9mnwuCAXrTRQ3vgvPl24=; b=DzL2UaLCG1CEdRJ7at4vY70jZZLukGdI2DqV55F6j5M2xGiynfCmenhHdRSs654nr6dp2m kZyFKfar214D6ZMQnR/jy8ZFD1T6fd4lPIfvPw4U/hNdiTaKEWJ2OsuFDeLMnTHjxrnRoa Btox+Zvw8oET51LSdfB7V7qePVMAhIo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752500343; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=78ELezR9/WM68ny3VH62OCs9mnwuCAXrTRQ3vgvPl24=; b=QfmrUGV26aEEIZ+cLl5FOhXIUpzfrUO4DFex4kjVkgcStYFZg0NfvjEHaCK/VasCVuzF06 oEagOkAzv0PMMUjqkXM65fa9E8uFooyOeJL6Jut4sG4AY+ebczeRiNJoALi8kqQdajUyO4 THZ8wemAbJu6X0a0rTwlNYT+sym94LM= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-203-eTBeY3LjNmy-M3LcqYZQdw-1; Mon, 14 Jul 2025 09:39:00 -0400 X-MC-Unique: eTBeY3LjNmy-M3LcqYZQdw-1 X-Mimecast-MFC-AGG-ID: eTBeY3LjNmy-M3LcqYZQdw_1752500337 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C03471955F41; Mon, 14 Jul 2025 13:38:57 +0000 (UTC) Received: from bfoster (unknown [10.22.64.43]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8CD3A180045B; Mon, 14 Jul 2025 13:38:56 +0000 (UTC) Date: Mon, 14 Jul 2025 09:42:38 -0400 From: Brian Foster To: Christoph Hellwig Cc: linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, djwong@kernel.org, willy@infradead.org Subject: Re: [PATCH v2 7/7] xfs: error tag to force zeroing on debug kernels Message-ID: References: <20250714132059.288129-1-bfoster@redhat.com> <20250714132059.288129-8-bfoster@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Rspamd-Queue-Id: 28701180009 X-Stat-Signature: czuzppiyngqpdit1rmac519suno6i1h5 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1752500343-290037 X-HE-Meta: U2FsdGVkX18LPHQO51PnmeJQeGw/1v60lQkvdaAhEfbkQEPqi1dnJF7y2ndPCAbeYws8sQwU7d4f8CXw8P7v5VQEj5uH1auSMxXcg6O6HBlrVI24Z6kJhWcf/vk//X/K0pCdhWSLjq3ZRr/sqqpNHO+GhbcDKJIJuf2buaBdrNI2ljrcNG1qLkiHIW4psEsNurjbu1d4WiGxBhkQvred3PAFA1jJDKn2irtz3npztjrpm9y+YpMWGbVwWaAASoyms8rZKeVtE7uNn4ghsmuWlUQelqQk96E0FmpDaDC25i1TaERj/17FEa3WPJV5QVTXufmUxrOZvuPg8tH98tVVeNoC6pA2mwb+7ZmxJU/hXaRgkRgDA6DmCs6FmeiSoWSSF7D4MaaOeSk5AiEWkl4nz3txgvuNiAMPN/hkeeq2bNM4E9ZsmieeCB5ulobLDcWg/51smIGj1veOyi2sNat+zz5rZTIdIBLRdPNZkGqD9H96mkeVaaYP5KloEBrUZd1mRfNtihTwIJpEUZhqy6UxDTWYgonRGHUsvS2To+zIxChVZ2XEOJ9eumC6XVcDKnCDHbY1WhnmQIGgjJzGwTqLuAaQXG0F+YMnkS8TLvG44LlTPzWpR8YRDGR3fIEoIBC3xYjwke6pVk56jZpHizv8J2L7xaLPmsiEzOojs+nUficfgzMrdXaLSSS/e4yLDkTDxMpd16j4wzUKSpDGYwWseLawzRqc2dK19WdoC2RcrSJpTTjXWo09hiV1HiTVQ21sor+XIbM14DkTwMimjvMcRpSRfZrgGFrzXfMqQobuqaZgJH7k9S3TnPcFuQCKX1TXwQRKxWbVmezQ4luhQQdpnnOI9BuPLSdAD6dTk5fpScPO3yyMuROKN1FCoYAUsSjFZCaVwR2nyVG2L9kxh1gc+heNhku/eSUhzuk53GapJVjZQpSXVCkDSQ/Pw84Uy0P7jEm0yrGwiCj9F+4YCOV Ny3Azjz8 iPJ/Cv4BpadjyFqt2zECrZflGLlzPX+BbXRLUVs8iPou/5j23IdhNcIrnXjI+BRbsJpUPAWxEPj/hkNuJiKNxXwGal8Bwbvz181G4HBha3ebCj/Aye3llkOPaMXPv7aIpfc5+VKKepO+Ye6UmjCBW72AUD7BPJhaMtejXU94WrAB28/eq5owCTe5UpFUIaDOKe3ky5mR2vrpL9vR+GLKJjbCsWm4ro3a4WCaagCfj2d8DugfJ3v45WaBkGSi4bFzgNiGbAQ8aAiQd5lvvUIJHg7qaS8pSMCLYNAonTuYbD1j/B/BQ8Kiv+GFiDMDir+LWvQ35+xfhB0FbWiFRCc6HMq8fr29ldwXDJUncyiDKZls3D/4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jul 14, 2025 at 06:23:01AM -0700, Christoph Hellwig wrote: > On Mon, Jul 14, 2025 at 09:20:59AM -0400, Brian Foster wrote: > > - error = xfs_free_file_space(XFS_I(inode), offset, len, ac); > > - if (error) > > - return error; > > + /* randomly force zeroing to exercise zero range */ > > This comment feels very sparse for this somewhat confusing behavior. > Can you add a shortened version of the commit message here explaining > why this is useful? > Sure, will fix. Brian > Otherwise looks good: > > Reviewed-by: Christoph Hellwig >