linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Harry Yoo <harry.yoo@oracle.com>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Jakub Kicinski <kuba@kernel.org>,
	Byungchul Park <byungchul@sk.com>,
	willy@infradead.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	kernel_team@skhynix.com, almasrymina@google.com,
	ilias.apalodimas@linaro.org, hawk@kernel.org,
	akpm@linux-foundation.org, davem@davemloft.net,
	john.fastabend@gmail.com, andrew+netdev@lunn.ch,
	asml.silence@gmail.com, toke@redhat.com, tariqt@nvidia.com,
	edumazet@google.com, pabeni@redhat.com, saeedm@nvidia.com,
	leon@kernel.org, ast@kernel.org, daniel@iogearbox.net,
	david@redhat.com, lorenzo.stoakes@oracle.com,
	Liam.Howlett@oracle.com, rppt@kernel.org, surenb@google.com,
	mhocko@suse.com, horms@kernel.org, linux-rdma@vger.kernel.org,
	bpf@vger.kernel.org, vishal.moola@gmail.com, hannes@cmpxchg.org,
	ziy@nvidia.com, jackmanb@google.com
Subject: Re: [PATCH net-next v7 1/7] netmem: introduce struct netmem_desc mirroring struct page
Date: Mon, 14 Jul 2025 22:58:31 +0900	[thread overview]
Message-ID: <aHUMwHft71cB8PFY@hyeyoo> (raw)
In-Reply-To: <92073822-ab60-40ca-9ff5-a41119c0ad3d@suse.cz>

On Mon, Jul 14, 2025 at 03:24:02PM +0200, Vlastimil Babka wrote:
> On 7/14/25 11:42, Harry Yoo wrote:
> > On Tue, Jul 01, 2025 at 04:45:08PM -0700, Jakub Kicinski wrote:
> >> Thanks a lot, this clarifies things for me.
> > 
> > You're welcome :)
> > 
> >> Unfortunately, I still think that it's hard to judge patches 1 and 7 
> >> in context limited to this series, so let's proceed to reposting just
> >> the "middle 5" patches.
> > 
> > Could you please share your thoughts on why it's hard to judge them and
> > what's missing from the series, such as in the comments, changelog, or
> > the cover letter?
> 
> I think we moved on in the discussion since then? "middle 5" patches are now
> merged, and 1+7 was, along with more patches (that make the context less
> limited hopefully), posted as v9/v10 now?

On v7 Jakub asked [1] [2] few questions about the patch series
and I answered [3].

[1] https://lore.kernel.org/linux-mm/20250626174904.4a6125c9@kernel.org
[2] https://lore.kernel.org/linux-mm/20250627173730.15b25a8c@kernel.org 
[3] https://lore.kernel.org/linux-mm/aGHNmKRng9H6kTqz@hyeyoo

To me Jakub's comment "Thanks a lot, this clarifies things for me"
and still "hard to judge patches 1 and 7 in context limited to this series"
after reading my clarification (which wasn't part of the series)
sounded like he wants some of the clarification to be added to
later versions of the patchset.

But I don't speak for Jakub, I'll leave the answer to him.
Maybe I just misinterpreted his reply.

-- 
Cheers,
Harry / Hyeonggon


  reply	other threads:[~2025-07-14 13:59 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-25  4:33 [PATCH net-next v7 0/7] Split netmem from struct page Byungchul Park
2025-06-25  4:33 ` [PATCH net-next v7 1/7] netmem: introduce struct netmem_desc mirroring " Byungchul Park
2025-06-27  0:49   ` Jakub Kicinski
2025-06-27  3:54     ` Byungchul Park
2025-06-28  0:37       ` Jakub Kicinski
2025-06-29 23:34         ` Harry Yoo
2025-07-01 23:45           ` Jakub Kicinski
2025-07-07  0:21             ` Byungchul Park
2025-07-07 18:42               ` Jakub Kicinski
2025-07-14  9:42             ` Harry Yoo
2025-07-14 13:24               ` Vlastimil Babka
2025-07-14 13:58                 ` Harry Yoo [this message]
2025-07-15  1:47                   ` Jakub Kicinski
2025-07-15  2:08                     ` Byungchul Park
2025-07-15 10:23                     ` Pavel Begunkov
2025-06-25  4:33 ` [PATCH net-next v7 2/7] page_pool: rename page_pool_return_page() to page_pool_return_netmem() Byungchul Park
2025-06-25  4:33 ` [PATCH net-next v7 3/7] page_pool: rename __page_pool_release_page_dma() to __page_pool_release_netmem_dma() Byungchul Park
2025-06-25  4:33 ` [PATCH net-next v7 4/7] page_pool: rename __page_pool_alloc_pages_slow() to __page_pool_alloc_netmems_slow() Byungchul Park
2025-06-25  4:33 ` [PATCH net-next v7 5/7] netmem: use _Generic to cover const casting for page_to_netmem() Byungchul Park
2025-06-25  4:33 ` [PATCH net-next v7 6/7] page_pool: make page_pool_get_dma_addr() just wrap page_pool_get_dma_addr_netmem() Byungchul Park
2025-06-25  4:33 ` [PATCH net-next v7 7/7] netmem: introduce a netmem API, virt_to_head_netmem() Byungchul Park
2025-06-27  0:49   ` Jakub Kicinski
2025-06-26  6:41 ` [PATCH net-next v7 0/7] Split netmem from struct page Byungchul Park
2025-06-27  0:50   ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aHUMwHft71cB8PFY@hyeyoo \
    --to=harry.yoo@oracle.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=almasrymina@google.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=asml.silence@gmail.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=byungchul@sk.com \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=david@redhat.com \
    --cc=edumazet@google.com \
    --cc=hannes@cmpxchg.org \
    --cc=hawk@kernel.org \
    --cc=horms@kernel.org \
    --cc=ilias.apalodimas@linaro.org \
    --cc=jackmanb@google.com \
    --cc=john.fastabend@gmail.com \
    --cc=kernel_team@skhynix.com \
    --cc=kuba@kernel.org \
    --cc=leon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=mhocko@suse.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=rppt@kernel.org \
    --cc=saeedm@nvidia.com \
    --cc=surenb@google.com \
    --cc=tariqt@nvidia.com \
    --cc=toke@redhat.com \
    --cc=vbabka@suse.cz \
    --cc=vishal.moola@gmail.com \
    --cc=willy@infradead.org \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).