From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A94C7C83F1B for ; Mon, 14 Jul 2025 14:09:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4CE326B009C; Mon, 14 Jul 2025 10:09:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 47F616B009F; Mon, 14 Jul 2025 10:09:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 394B26B00A2; Mon, 14 Jul 2025 10:09:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 29AE46B009C for ; Mon, 14 Jul 2025 10:09:00 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id EA9DD1601C2 for ; Mon, 14 Jul 2025 14:08:59 +0000 (UTC) X-FDA: 83663051598.23.FAB7084 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf04.hostedemail.com (Postfix) with ESMTP id 4575D4001A for ; Mon, 14 Jul 2025 14:08:58 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fqAR3gDt; spf=pass (imf04.hostedemail.com: domain of bfoster@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bfoster@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752502138; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OPs78cLbRWCJyfKDridU8XrYJR+Ht/I/0x3d9CFQm8s=; b=Jy8DLE8vmY/cO9HbokHb/uc6syqnqsVLQ6UHcfnIBF8nm0qwORSdaR4HZGYdYf1Tk7lqa1 zlbHGgwIb3CqGgefgOpzFSkFLrzlkp88ZvMIGdDAzcMvL5uZhEtHLZ+uaN0qfgN5X7Twlm kb1uJSfm1arbEVCs9rgmWbOu1Unn8sM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752502138; a=rsa-sha256; cv=none; b=P9BCCmNj5stbOQZ3UqGRx3xS26FDNme3YtPNFNihDug1A3pJOByLDwC/Q6Dhx3NZNlJw1L SdfBCM4zqTSYEbb6GHKRl7SC43GFbVQgnZfVnMwbv0xfUoC/V1AnHxFNV7wBWY0dxTFFPW xwRYIlomxdE8UH5Q8zmMZGF4b8mfB8s= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fqAR3gDt; spf=pass (imf04.hostedemail.com: domain of bfoster@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bfoster@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752502137; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OPs78cLbRWCJyfKDridU8XrYJR+Ht/I/0x3d9CFQm8s=; b=fqAR3gDtI2ofKWS/DeOuy2B44Tg987QVmvfWUeiT9urtMUaFyZr7oL6BNA22Ku36XO6XyA NibLx4ZgDdWsCqZD87fZYRetd0J8gbp+gh4K9cl1hDuFyFTTd3F+trDta0u3p9xnrBlvJz wAzxhAv0H4ood0ZKH8ew7xNgYRAu6FU= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-102-jGDTCNUAM7GXvePmG1kKig-1; Mon, 14 Jul 2025 10:08:55 -0400 X-MC-Unique: jGDTCNUAM7GXvePmG1kKig-1 X-Mimecast-MFC-AGG-ID: jGDTCNUAM7GXvePmG1kKig_1752502134 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7A9141809C86; Mon, 14 Jul 2025 14:08:53 +0000 (UTC) Received: from bfoster (unknown [10.22.64.43]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6CD28180045B; Mon, 14 Jul 2025 14:08:52 +0000 (UTC) Date: Mon, 14 Jul 2025 10:12:34 -0400 From: Brian Foster To: Christoph Hellwig Cc: linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, djwong@kernel.org, willy@infradead.org Subject: Re: [PATCH v2 7/7] xfs: error tag to force zeroing on debug kernels Message-ID: References: <20250714132059.288129-1-bfoster@redhat.com> <20250714132059.288129-8-bfoster@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Rspamd-Queue-Id: 4575D4001A X-Rspam-User: X-Rspamd-Server: rspam09 X-Stat-Signature: ywsrkcx3wsepmun1hu37byquotecxmqq X-HE-Tag: 1752502138-860959 X-HE-Meta: U2FsdGVkX19ZNCn0/ljJayrLP1x8/6Y3T17gSEWd/PtrHDFlJKGfH8c4+WgGP633QZEJPmNnU23dsUqYggYbpeGFSradPOuexyUBQGRUjR4c9e7G2DFxv7caTv0rjPrlnwzk8jVqUU5p3tuMm8IEU48DZ5v/CXt5gHlXDv5LjLDDlMqA76TW0Mg5sSMbkJ7KGpGv83/Z1VW+4DVRdu7r6bZp2uQj7dKaQPD4o1xovaeaGKUNcdahjaxKC8EWM4/tE1u9gzS95IR5RvcZfHypCaVkqlNaSUKfbAiyyP0NVOOFfk2mLeDEZ/1DcE38kWEeR56S6VSLXEYAR2sbv1OjOVpewFMYun3j/gMeKLSFby4rt4E2gm7gylTdyIsJ6zPAT06ce4Qfmr23zcPK3DJaCsaZWz8+GZRNCouE5Pyuu+MuPtxFNP+gebuDUEEh7uagI26kjpelv30ZBA/EfvP5COqmhjn7zDSe7+9lPVqYEkKYQ5EpTWYv8GKBG9kNclLV5eUfKz2BzGcjg1a8qZxkDYX4krCveHgtUkq+/gsFOwFdK7VpH+7m969V/q7MU6vgfD/fP2xwJLxrbJPfyE5TQQhWmG5DtFGn/8gBpor5V2d5pc1m6phM1CRuVE8/ybcRMayJnUflFTMrTeL+wijLXeyUCfXyIZqQ5pvE8iOCal1K9Vg2YkJp8O84ZI1dD/NIrdctIq2GQ+0ALxra72tcFRjtyi0oFebMjR9TIGI5rb+6pf0/w8xmNPD7PHqBEnF0Ik98OycwZfD1d/zPuXQRh2EYS3r2ptm2/xLptlJCaDYLW7+mJ8FDh0a6Mi4qMGpVe2pjUo4Zbyqxtu9eOMqfQzSeC8+dLP6YEtU0knwSWUbKbkjP0tU5JqIyo4q2yjAWNXeI5UN22ny0s6OHSPm4umZyTNE7HaHCw2k4Cnw6MB6PGJyR43nH8x4Tp5czVVYguF0c5sa1L58y0N/Xi04 tKNLVKIp OfPnONs4hdjQr1ssNdkCLWkEzWV7MeJAMld59ejhKR5s742urla6gZsfSPQj+QY49E0U4 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jul 14, 2025 at 06:23:01AM -0700, Christoph Hellwig wrote: > On Mon, Jul 14, 2025 at 09:20:59AM -0400, Brian Foster wrote: > > - error = xfs_free_file_space(XFS_I(inode), offset, len, ac); > > - if (error) > > - return error; > > + /* randomly force zeroing to exercise zero range */ > > This comment feels very sparse for this somewhat confusing behavior. > Can you add a shortened version of the commit message here explaining > why this is useful? > I replaced the comment with: /* * Zero range implements a full zeroing mechanism but is only used in * limited situations. It is more efficient to allocate unwritten * extents than to perform zeroing here, so use an errortag to randomly * force zeroing on DEBUG kernels for added test coverage. */ Unless I hear further comments I'll post an update with this by the end of the day. Brian > Otherwise looks good: > > Reviewed-by: Christoph Hellwig >