From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BA48C83F21 for ; Tue, 15 Jul 2025 13:31:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3062D8D0011; Tue, 15 Jul 2025 09:31:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2903D8D0001; Tue, 15 Jul 2025 09:31:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 10A3E8D0011; Tue, 15 Jul 2025 09:31:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id EC9478D0001 for ; Tue, 15 Jul 2025 09:31:25 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id A3E0D1604B8 for ; Tue, 15 Jul 2025 13:31:25 +0000 (UTC) X-FDA: 83666585730.01.24EF43D Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf30.hostedemail.com (Postfix) with ESMTP id 235A28000C for ; Tue, 15 Jul 2025 13:31:21 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2025-04-25 header.b="CqOBW/Jy"; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=PzxEf0uc; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf30.hostedemail.com: domain of harry.yoo@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=harry.yoo@oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1752586282; a=rsa-sha256; cv=pass; b=2ivwCRIR7gAfBlL0s7iAH3fOVtAVpcxzXM2XUl05mvsAzqLD9QH/0XBgpJDIlwbPqncpeQ 3oD2CsgtsvVkBmR/DgGrwrR5G3bt44cJ3U3h9EZHY7tH8xb+YKroUSTOjHtG3uqvvPgamA HaI4MkHoRII05Q8QKBcEhZryxL4jVKU= ARC-Authentication-Results: i=2; imf30.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2025-04-25 header.b="CqOBW/Jy"; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=PzxEf0uc; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf30.hostedemail.com: domain of harry.yoo@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=harry.yoo@oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752586282; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WWhfI7xafSk2Jys4RK44giQNhKRDd84fTA0IK6NA6jc=; b=aVU9vZNF88oi9vqIwieRpMm6+6pW+x1yz3/IeumD4I5Q2p+EM8hbt5ttAOpgbLTC5kXp0U 8YtHuHUKOWumOchOmLtSY7iCizXHeToZJt45yeLwow2kR8x6fXuFmXllo3yIHR0TER7c3p 7tjH0FbIraYUIqqFQXQ1BqxsekeMvNU= Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56F9ZKhT022726; Tue, 15 Jul 2025 13:31:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2025-04-25; bh=WWhfI7xafSk2Jys4RK 44giQNhKRDd84fTA0IK6NA6jc=; b=CqOBW/JyReTeB4Y+QiHTwj3g/kVbue7L0Q DEyyHd+LtktwXLEbvvPPLufFmelBjn6mGMucGBY5Ys/oapPWv8AUbEknVAW8XTKv FBDiaNNd87XNlQEO/uSOuaT/GqU3qMhG6bvZX/X16VZrt6C+ugCITOqsd6YG2pc8 iMxMszEuzghweg+gDcxeCtYEKk00JZ9xWMHqOXp9OhxrIQ8DEGpp/OU83dAJNKuV ous/GDGL/5cihcQO63CMnetvqRCllaEyBqtDxus+qi0dbRCwmlaXrz3CTeuRfQ/t 3C5Q/GGRw5ARAmHIsUw09eDqKXsM16M2sT2Zb6B5V2znhoGi1n1A== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 47uk66xd8q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 15 Jul 2025 13:31:16 +0000 (GMT) Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 56FDU85S029669; Tue, 15 Jul 2025 13:31:01 GMT Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10on2063.outbound.protection.outlook.com [40.107.94.63]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 47ue59y0dd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 15 Jul 2025 13:31:01 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=q9lKYHwN6ZR+nGq0xM+Qn/09wO3Ity2o7SKcyVIfiSQeT5yb2KJMo9jhZAaqtUbbxHndSnGjXeQaGrCivG1BAZFqOpJp6KnXsUluCEG+/D17Yl9NboCapjQq7Kke0fW271qD8APgp4Rc2jrpkEWIyOnkEzSnRRsl832iosoXqeF/4wtlHiSp1n/MRiwmYqjy9dBXdSu4LNO9yASd7pBlazasOdAmZtw80cpVhnLwJ2yzQmDLY1koxcFD/3lbOAnnVvya/Vkvg5QFqV4efCoOU6vg5E79T2txIZjlDDur79ApJbk7d2ad7rZ8Btm2hPrwmT7cbens2R00t9XBO+JlGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WWhfI7xafSk2Jys4RK44giQNhKRDd84fTA0IK6NA6jc=; b=dysd6krZWGAUf5u3v8mJcaxxHMESwVjbLIXWUmRU9rLK7ARWuLZsJkpsqtau9pTv7JZ0GULKeJtbF2V6e6yxC8l8RpFtov5Bsz1B3XeXEKzZKPmGD+/mqeTcvlYjL1iHYh0tI1DmqyODnuVzEDblaawcQJDOI+gBLEUFAUzDAKxhq0aHkL6RuaT/j7io2V/WY2UWRADRQqpk4N505B2M1aXHuThMIDgw5+mmLvHnKxodsB33it2LFZxM4nEfvWC2Mxr2RcUbxkoKnWGETjXJ+JbmdtJYdFAZXUOz+bWASiEDt2aqfgaBiU5wMVqfPAYBDSWtiEDRF16QBn+t5+FBcg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WWhfI7xafSk2Jys4RK44giQNhKRDd84fTA0IK6NA6jc=; b=PzxEf0ucZoxmUYGFBxT67kKU5ngp0g/zMXFJXE6hGO7XkP0JaqKwWBetjVdesz4Kg5yhzZdDn6+9JiPJ9TXxL+d8M3mp1loNGpRjN3ronOI2Kyos027OeyXbhQF/KyygmUJgXkw/X0zmgrgPlneKH1HR9YqrO96+2HkN+kisVCg= Received: from CH3PR10MB7329.namprd10.prod.outlook.com (2603:10b6:610:12c::16) by CY5PR10MB6239.namprd10.prod.outlook.com (2603:10b6:930:41::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8901.23; Tue, 15 Jul 2025 13:30:59 +0000 Received: from CH3PR10MB7329.namprd10.prod.outlook.com ([fe80::c2a4:fdda:f0c2:6f71]) by CH3PR10MB7329.namprd10.prod.outlook.com ([fe80::c2a4:fdda:f0c2:6f71%4]) with mapi id 15.20.8901.033; Tue, 15 Jul 2025 13:30:58 +0000 Date: Tue, 15 Jul 2025 22:30:30 +0900 From: Harry Yoo To: David Hildenbrand Cc: Andrew Morton , Matthew Wilcox , David Rientjes , Christoph Lameter , Roman Gushchin , linux-mm@kvack.org, Vlastimil Babka Subject: Re: [PATCH v3 mm-new] fs/proc/page: avoid anon folio checks on typed pages except hugetlb Message-ID: References: <20250715120748.9290-1-harry.yoo@oracle.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: SL2PR04CA0019.apcprd04.prod.outlook.com (2603:1096:100:2d::31) To CH3PR10MB7329.namprd10.prod.outlook.com (2603:10b6:610:12c::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PR10MB7329:EE_|CY5PR10MB6239:EE_ X-MS-Office365-Filtering-Correlation-Id: ccf08b18-6a07-4b93-ee8f-08ddc3a3d3a6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?RaQUpMnn9v/HYY80mE18TWAWDb32oBw8+I4N6jubkFyPZR5U1WCgAC0+AD9K?= =?us-ascii?Q?59yyAa+WAIEhtmue4JwPmrV12GuGiopPYJrXB92wXmQ6J7lLVAQApDwRf+xA?= =?us-ascii?Q?k1YRYiAq0GvQHhA1pMVHKxsRfCjBbcZdLJeJqQfaQRLAQjoV8ZGnzSdNCtw/?= =?us-ascii?Q?AGAQDULC5QFbP6nIDxMA74ROs3UQJl5jKI1Jh+gZ/cVDiW8xdtPgr81EXyg9?= =?us-ascii?Q?ssLMn2vpfg71jQwobPwOteYeiHA8YJAFIQXWPWdJhhC9Qn0q0JJc+hnUJJII?= =?us-ascii?Q?Jrq0QiUSyEhTNIJzVvHEoOB34WtvgE2vU+7hcj0LgfebV/Lr60Ei4apMvP9Q?= =?us-ascii?Q?1c4PkQh9vO7ZIUcZ0wn1Jx8mDol04BxXfiynPIeusmFOhxbl4NgnblqrCs+2?= =?us-ascii?Q?aOiRdSjWZmmVSRp9m6EbekxyhwR5fiZeI7wHZZ+g3ZRef51/uKqf2ziiGBh8?= =?us-ascii?Q?LUNZMhGxPMoTs2MlqxerTzH0Zmd5O+vjSFp8E1r3I3T08UbZXjddW5ln10tZ?= =?us-ascii?Q?4xSG4OUAXtGIJYBJ7NieES3I35431+XB7RMrCME1YfBIUatBjwonGMe0F1cO?= =?us-ascii?Q?4o2Nvww8dsdVmfL4SREmDz4S/4awD1dX2Zwr0VTFKIA6Tjp8YNx5J0Stnp6X?= =?us-ascii?Q?BjYVCn3kxNrKVH1H7DfkkJ0aJCcUFITZ2TPR8ltypW+OCWPOaAnvUMcPjiA2?= =?us-ascii?Q?53shUKdCnLHQQw+/oavGX9+1Zlx9QioZMXXORQpCAix1hkMqdwy+/81hS1al?= =?us-ascii?Q?la+02gbgEv/IYOObcfe2RbGSa86WdGJ0fapbt9/YYAEi+yf+whC+9bHMOxbm?= =?us-ascii?Q?3MHt6+PqyM+i40KqLzvaPMV7zZUbKjYC1hrbFtaUw5xkVPOAUutQDq4xltSU?= =?us-ascii?Q?m+Cp8uIeQq9z5m7xlhI+G6u5SERofoErmz630M/sVa+aQBtqU+ljGjH+qZuL?= =?us-ascii?Q?2s+q56yuAxevFN6tYwN1tQXd7v9T/9VzEfqvoAhpBYt7oliRip2iMe4HrBqc?= =?us-ascii?Q?dSwVKtFPltdTJvhmfJ6cNpgkWs4cy1FEIIdacCoiJiYNbW8+ZUjEyHQ4DgT5?= =?us-ascii?Q?i/Hp5O7x92o0plVJqnSNNxKPIo7/+tlwKiMbl8LQt7MEsPoIt85VIKohsBUY?= =?us-ascii?Q?KGBYMEjfwPAOKx1Do84qRCi+PyeZ0i7nimB/8zDzBehS4QzhLAmAgoxxAIpK?= =?us-ascii?Q?Dts36hsVBiyyHh6sajp8+mfXHBM8FrwslXn1FcTnE1vzv1jgj/N0E5PiDWBQ?= =?us-ascii?Q?D+vZeeKxdKi1wgKZf3BeQRf0q2SjZhtIPqqcESpeij1Z5TizpBzM35f65vIP?= =?us-ascii?Q?J/2MXod0kXe7TmoCCVc36gZevkwEejOoO1iRLGgnCHExO6PTnhhhtkQOPHOf?= =?us-ascii?Q?o8aR4HdlnfWFGCFwg9AlW86P7gmReOy3upmci0zb84UVnAE3kIwyi8xDdihN?= =?us-ascii?Q?eTHUUDbABa8=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH3PR10MB7329.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?RoOGLq94IxuwVPGMPeI/QAcbjL6SxvdsPbeCsPnrRxTjM0kenlsi0qTxyoiq?= =?us-ascii?Q?sjApEQ4G0JfSaa26Ta2M1qS3rNCr3tyqELADvLifAOvjsrOTJeRgeMF4cEty?= =?us-ascii?Q?VEwSm1XWDbzLM/EWPiYC05YkGp0V3L0o2RQHL5z8pHSpcgltr7Jk9XEn6O7s?= =?us-ascii?Q?NP4NnTO4gfxvgdYcasEWCSlaE8ZwWrqfzULk362cSBnZwg4E51c2HxT0L9jF?= =?us-ascii?Q?BraWF6IITThKPHwShgWbxck6VkQGKObEg5oxbtLB20YtMzbRycvGwjBRkzfa?= =?us-ascii?Q?4Q2SvILeqq02k4L+RTiQJdSWFh9FMjKW4kJlzNjKhGiBQIWCOPp2JP1WR6u7?= =?us-ascii?Q?yh/60HNV6ChXwnpTjcjxz5WiBIbqHdgNykT2dBZ10MRBGAa45Bk0dHeCZMcH?= =?us-ascii?Q?8NUhv842yWfnEq3loXZcKPvk/nHgziNJjVvd7JVZYnuSQlLFEExQwzeu2h4e?= =?us-ascii?Q?QtA6y62pMmO/4gP2k70cRtGHnPocLLwmkjncXFZq/9h6HbfLnN4ZvcrrvgK8?= =?us-ascii?Q?fbbyA/7nxGty6vfuZVio/9eFAMDsu8D4Zuq4exkZ45gL6u9iIJcAyyPkFCiB?= =?us-ascii?Q?FnH8uFDvEsNoaSXxODV05s+shbdCSPt+po9rogv2OfqU2/YzSgHB7R39pRDq?= =?us-ascii?Q?KpaEXCRZvWf3FOPXe46r+sfUV4lLM+3HwWH/f+0eApr1XaNDdYI/OohASOm8?= =?us-ascii?Q?5hI2+cBuf23hWAspwEeMiJepTm1vzMyH7dcZE+TN00yN6ug+KqWcIQ//pRpP?= =?us-ascii?Q?hB3TCl0hWkbu+2yR0YyGAbk0uhvddCvdSvP5BhKkyTkKaXQJkZOfbd9EVVG9?= =?us-ascii?Q?2Ez6svkyY34VkczcOVYrEhywiU57zfFi7vN9TMroQg1t3Idwkppl96veIpYE?= =?us-ascii?Q?pfZmU14MIpi4JunJjmHfuZH0xccqt7ps6UQMb5pXnUVPl0DmNCK4yXdPlTuA?= =?us-ascii?Q?VXxDOMSZPgNbfcxL4FXu41rZmEcznT1t5p+/fu9hVpkU2smlEcK5FuJLFCTq?= =?us-ascii?Q?6JwgTuwfUCriVCmSlAfU0qHS3BqKS9xHULoo87sO9enegaY/f310+kiGh8jl?= =?us-ascii?Q?hYX5N8DCVeNYqVqAETmN7t8uoqrahHDjGqpk3b4GGQlhZhFEKzC8rGzCdEci?= =?us-ascii?Q?rgs/Q0YZEmx+sA5Ev/NP2fbri50ZrsYFm+V3qNxwQgLSLkzxTT9zg9WdBe7F?= =?us-ascii?Q?9drBDB6K8xtxtcIAn9lTQrHCXA8gUS6MDextN9fY7HTjUc3P7V/HGKCR5tys?= =?us-ascii?Q?nigv+zUZFVXV88M5Q+OgrB4rDbmZeRlWSYGsKgs3VlqoEKykMetTQZYvDyb2?= =?us-ascii?Q?jks1txaAqOun8gxKTcr2uB+yE41jYZHO6AtHCR3YcQbMSncBqVaXEE20bzin?= =?us-ascii?Q?gO8fxa7EtSvznaqhmc1L+obtnPmjkcXcOZt+bH58MEkL0UUk0AZz39zqkJD0?= =?us-ascii?Q?paRYAW/MXe5OyCaBpntufFut72VeMqht++IVtM5nGPsNyEk+vAvgzK2MNNTm?= =?us-ascii?Q?Nf4+HKWilSeiwEnpTrnw2365pZLor6qOp7pk70BBoIZP9odRg1bCZnynqA+y?= =?us-ascii?Q?QAuvUH3qANLy4ccqh+R9Pl3MP9Hhqe2rvUHFebpj?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: HvPa3gHc2yVDCHvlmiKasr0LY5v7ChEWw/0UfSx/l8CDtTev0MXs8IlHy/KasCVdaMMm4OUtgGYF6gOYwV24yUEtTDDlc6+LfFaYAFeVX1ZfoCUPJfbBA4ua1ngk+96IdMHS2C8Kb73QJthr196c16qB30aNsimFB1T7NhJ0ZgpOAbNkijV8C19CNWEopyUdcRK+F4alM5nur8uHSc5V9zT4z6OtQ38zviUTZ0ZqVH1n5aTgG1o3ZLIiOoQOuZwRKrbOfi7FlGS1aoC5S5Dbdu/nYTVgJl7HAzWtZkULeUf53E6bYM9dZzOz2aATu6ZNcjvPsysYUqkbrFmO7zbtBXBtimBriP1GZWnOxs8dIzhrYVRtNOTGXmtnIgI00pnqvq8AS4DFRWCznO/3Yy0lqHdHt/qW9kcwbmV1fADnXdFwy4U8wYkvWWpodnwpBeuNw0HixUvtk0HbhJeXLIdYLEqjrtW4BJvL3oT2i/N1IrI4N1NBY1FC9tQJ+8s3NZbbgOXuEJ02XccWzi++MQQId7JMMxHKLgGapb9gVIv0T11aB14NYasZXyebbFIKUaoaaLB9xAgarQ7LoXUXot5zY8Ej/adNOeyu+rtwFL9/UG0= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: ccf08b18-6a07-4b93-ee8f-08ddc3a3d3a6 X-MS-Exchange-CrossTenant-AuthSource: CH3PR10MB7329.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jul 2025 13:30:58.6492 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zmQE4lu4eOA4L9XiUjIsXEEJJI+pMit8ox6rDVPS/faUWgG4q+nLniD1DzeOYhrQ/Xt/GUqvlL3pO3xwT0KnTQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR10MB6239 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-07-15_03,2025-07-15_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 suspectscore=0 malwarescore=0 bulkscore=0 adultscore=0 spamscore=0 mlxlogscore=999 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2505160000 definitions=main-2507150123 X-Proofpoint-ORIG-GUID: pGSTqGS0n6gTfzTwjsq6sjdMHhlN-Xmw X-Authority-Analysis: v=2.4 cv=AZGxH2XG c=1 sm=1 tr=0 ts=68765824 cx=c_pps a=XiAAW1AwiKB2Y8Wsi+sD2Q==:117 a=XiAAW1AwiKB2Y8Wsi+sD2Q==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=kj9zAlcOel0A:10 a=Wb1JkmetP80A:10 a=GoEa3M9JfhUA:10 a=VwQbUJbxAAAA:8 a=yPCof4ZbAAAA:8 a=JfrnYn6hAAAA:8 a=kvPNYwgmVzIaQD12JeoA:9 a=CjuIK1q_8ugA:10 a=1CNFftbPRP8L7MoqJWF3:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzE1MDEyNCBTYWx0ZWRfX+zBtKQgdx17b r2LNhug2DUinyaxipE4gdplJSk/OkS9BPnWBjrVVzH+K8y+Lfds1moP+XbZ8afTYwaOhGmeV8n2 K0PBEjHIQY3Ugbu2GvtyKIUkNXqF8EhuWVHLLcFv87VejJKwWeWomytl94JEYURsCq3jkRSKcHO oWl+7NlsCTQPUi19xBUBFw1WjsJtodltWL1QeRYEbw3f6LcKKuDUBNmITYARQ6XQOIHYO8YgkFo KEGABdJ1ks3lgX/BICXejtvEsMJIG7go/fEtszN6QAvN90soUZ4FYTHdNOhG2JnAkxHCKH9Q1bV J9A7P5k2L5820j4TdhexKG4DUrf0r6AKYBQ7r2GYJ6XhW47ZdGBEdvpwZiaR9CM71AH8diJ0MPP GMuULvL/5LBIxSBq96P1BXLn1T6LJsMrAjl742COnN9CVGXbNnsGcWw0qZ2AZBAfdn6scZM8 X-Proofpoint-GUID: pGSTqGS0n6gTfzTwjsq6sjdMHhlN-Xmw X-Rspamd-Queue-Id: 235A28000C X-Stat-Signature: fpcku1gttqs7sc4584ajro9646ipro7o X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1752586281-70448 X-HE-Meta: U2FsdGVkX1+fink9r1j7XH2mqUNlFh9xe+UHYMhMUEB0G1Qid4hJwg9rOTZ7ftwMHXZv5o2Oj3XOL3Fx+zL/Lo5l7g50AUcEshaqinxMTZ2DjPCwGv7LReCli7bNsRPZvzpaCZsjxU/mIsyX99xz92ihxtGgYk+rHcyng2z7f8svdWj1Aqk7ZDX6G3w+4s/XzYBlTQZR53H7NZfE+F9pw8iMLYRhVO3+MkTwOHPud+iPqDgMjOV/Wj9L9pA2Z+rpdLrw0Rmq09U61HwKt+tMj9/kv8dz3yjWribTfRfoa5EfCp+ipWL7jUTx3/93d0yBEdnWaDZY+Zp605r3pZXmcC9zItORorX6BbV80CowusK3hpIWsv7GKCC8BMSRQk8uguyRWQL37Vq22yxV8uccTFg6u0wA76iaaHmVqrx2VbOllGsJ6rGyFv6BlZi021vflE1GuFzJoVc1XVtq1qEHF9z4R+ezqrvJVexrWcvOMwqGKAWMFIdOyDLUexjgp+cfoBb4O5iE4qsiu0szUlhc2CIFpcGt6pbD3uy7i0yHZmaJwui2C0ELbv04354MLGpEIqrXOMczDsfz0S9EUge6qDirANCToUh6JaK3/RNnksyrWTv+5L4PwDlPX3F3NdJ/2Ms/N9hSWcVc5+2/lO6KEoqbE2TgVPbKudzSFKO51G8fsQaeLbRTd/iwKmQ20hdPMaAwceDaR4xCMCaCuAJ9Nf6TRZIBDsN4vGbbd4O1Zj6Eu+ckBGkbe5cRiA0NVzZjg4RjWHpicr5an/XSxlMgIecdKGTv0v+SSaBjfZ9YrDLBTUaoApaNFgzylyLU40SO7/161mvTdyENHY3KPvCY4yFvlywqzmlJI+S99MxwNvDAkrShu3rQnhmOZvDo/MtvAw/7Vcc2uqphPWkM4D1K+uXgnxlQFLopn/WaQarfrls/x8tIbSoFcTUxoSokG9UydaIIKvhxgYAs8AcsRRk dGWZYgyh R1uh2EyLom2IumcgLAdnVigSHJEFiNBeQNoE9Pz2bydEkmer9SqGehdH1fvMa7omNWNYRpQ3e4aHUGtXHIj66n3uTI3a/ik59n9lKAvFs1wJnjVVPSL273U7QbmQzaFiii45K0hzmwE7edWNcF9rZVMb1CsOudRXQsgrc2ac0gvh39H/a7Oo1fSrfNNBiFr7qF0YFO7E5dxNrhUPL2xu6JTr8zkPtBee5x0J6vuLd7Q8avmCwC1y0S5Wwhpm5lloVtewNRRbWSH2CqNbV0ZEjVUF5Gl1NMOlFkydblT0x3oANBWLDIh1bBVJZVE4MRE9s2666EXDShoYz2yMVusV1bo2QKRs3lYkdjn96e69bIEbLiKs4Yjms0jxvKTG3WkibTsIDBBzILHDRAIzBXwjKE5TTqKYICUlxyYIonAEr3aVcJC6OZd9jGHc3FQzoQuvpbDSIQyJ7gXIrn5WH7gvW6UBoitXSxqxaCOw6Rict7rvjtS+vicgKnbLcveZpUuQsgk30WU0HbxpkLdLTkqpylEu1C59R+TUqzNe2J9MBSv0igEgBdcHw3wLFlUVdt1/+2OcZoWli4BijeutFuu+JTb5icS2XP3YfIrgV2MF4sPktB0eGEk21pN4aFtywpeXAvlG/Hxm5dbMykmrYFaaDMjXcYUbBVy2Wbk5ga7I6geAWQ77CKxp3I0DKCOn0+tt5XI3FeGesPZVqqWVe0+b2VHLRhPiuHA4XK4A1N3X99OR+6CRgWfunLcNZt/n7l3NGjp1UAI4j+t79qta5FF4sefWi/Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jul 15, 2025 at 02:31:45PM +0200, David Hildenbrand wrote: > On 15.07.25 14:07, Harry Yoo wrote: > > folio_test_anon() and folio_test_ksm() may return false positives when > > invoked on typed pages (except hugetlb folios), because lower bits of > > folio->mapping may be set even when they do not indicate > > FOLIO_MAPPING_* flags. > > > > This leads to tools/mm/page-types reporting pages with > > KPF_SLAB, KPF_ANON and KPF_KSM (with flags, page-counts, MB omitted): > > $ sudo ./page-types | grep slab > > _______S___________________________________ slab > > _______S____a________x_____________________ slab,anonymous,ksm > > > > Currently, and going forward (The New York interpretation), > > typed pages except hugetlb do not have FOLIO_MAPPING_* flags. > > In the future, they won't even cast to folios. > > > > For now, avoid checking FOLIO_MAPPING_* flags on pages if they are > > typed pages that are not hugetlb folios. > > > > Update the comment in FOLIO_MAPPING_* flags accordingly. > > > > Fixes: 130d4df57390 ("mm/sl[au]b: rearrange struct slab fields to allow larger rcu_head") > > Suggested-by: Vlastimil Babka > > Signed-off-by: Harry Yoo > > --- > > > > v2->v3: Did not introduce folio_has_mapcount() per David's suggestion > > v2: https://lore.kernel.org/linux-mm/20250707120740.4413-1-harry.yoo@oracle.com > > > > fs/proc/page.c | 19 +++++++++++-------- > > include/linux/page-flags.h | 15 +++++++++------ > > 2 files changed, 20 insertions(+), 14 deletions(-) > > > > diff --git a/fs/proc/page.c b/fs/proc/page.c > > index 0cdc78c0d23f..07582dbdef45 100644 > > --- a/fs/proc/page.c > > +++ b/fs/proc/page.c > > @@ -148,18 +148,21 @@ u64 stable_page_flags(const struct page *page) > > folio = page_folio(page); > > k = folio->flags; > > - mapping = (unsigned long)folio->mapping; > > - is_anon = mapping & FOLIO_MAPPING_ANON; > > /* > > * pseudo flags for the well known (anonymous) memory mapped pages > > */ > > - if (page_mapped(page)) > > - u |= 1 << KPF_MMAP; > > - if (is_anon) { > > - u |= 1 << KPF_ANON; > > - if (mapping & FOLIO_MAPPING_KSM) > > - u |= 1 << KPF_KSM; > > + if (!page_has_type(&folio->page) || folio_test_hugetlb(folio)) { > > + mapping = (unsigned long)folio->mapping; > > + is_anon = mapping & FOLIO_MAPPING_ANON; > > + > > + if (page_mapped(page)) > > + u |= 1 << KPF_MMAP; > > Note: Luiz switches to folio_mapped() in his patch that is in mm-new. Right, but in mm-new Luiz's patch already depends on my v2 patch, which still leaves me confused about what I should do... :) > > + if (is_anon) { > > + u |= 1 << KPF_ANON; > > + if (mapping & FOLIO_MAPPING_KSM) > > + u |= 1 << KPF_KSM; > > Can we just switch to folio_test_anon() and folio_test_ksm() ? > > I don't really see a reason to not do that. Willy converted these > checks from page -> mapping, but we should really just use the folio_test_* functions > I think. > > And looking at it, I think Willy introduced an issue in: > > commit dee3d0bef2b00772be430425832ead6aa9d707f9 > Author: Matthew Wilcox (Oracle) > Date: Tue Mar 26 17:10:32 2024 +0000 > > proc: rewrite stable_page_flags() > > > We replaced > > if (PageKsm(page)) > > essentially by > > if (mapping & PAGE_MAPPING_KSM) > > But > > #define PAGE_MAPPING_KSM (PAGE_MAPPING_ANON | PAGE_MAPPING_ANON_KSM) > > So wouldn't we just indicate *all* anon pages as ... KSM pages? Oops, I didn't notice that! I think you're right. I don't see any problem with going back to using folio_test_anon/ksm(). > > + } > > } > > /* > > diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h > > index 8e4d6eda8a8d..26ae4c7cf8dd 100644 > > --- a/include/linux/page-flags.h > > +++ b/include/linux/page-flags.h > > @@ -706,12 +706,15 @@ PAGEFLAG_FALSE(VmemmapSelfHosted, vmemmap_self_hosted) > > * address_space which maps the folio from disk; whereas "folio_mapped" > > * refers to user virtual address space into which the folio is mapped. > > * > > - * For slab pages, since slab reuses the bits in struct page to store its > > - * internal states, the folio->mapping does not exist as such, nor do > > - * these flags below. So in order to avoid testing non-existent bits, > > - * please make sure that folio_test_slab(folio) actually evaluates to > > - * false before calling the following functions (e.g., folio_test_anon). > > - * See mm/slab.h. > > + * For certain typed pages like slabs, since they reuse bits in struct page > > + * to store internal states, folio->mapping does not point to a valid > > + * mapping, nor do these flags exist. To avoid testing non-existent bits, > > + * make sure > > I would write that explicitly: > > that you are dealing with an actual folio: either page has no type or the type indicates a folio (hugetlb). Will adjust, thanks! -- Cheers, Harry / Hyeonggon