From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38FEBC83F27 for ; Wed, 16 Jul 2025 06:21:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8BA6F6B0093; Wed, 16 Jul 2025 02:21:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 892346B0095; Wed, 16 Jul 2025 02:21:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7CEB36B0096; Wed, 16 Jul 2025 02:21:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 7191C6B0093 for ; Wed, 16 Jul 2025 02:21:49 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 226AD1A02A6 for ; Wed, 16 Jul 2025 06:21:49 +0000 (UTC) X-FDA: 83669131938.21.9B03097 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf20.hostedemail.com (Postfix) with ESMTP id EB5721C000F for ; Wed, 16 Jul 2025 06:21:46 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Mofl2wKn ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752646907; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YKkz8lS5G74bKddbsW4P64woHWlQNnkiSMyItwjDQj8=; b=nx6zCBL26xNLj0qRyUf5QKhxWcf1lueo2lO47xem0jv3YckUF1gB+j2dUeH92PMSew/L4w Dhppb5vIQWzwgE6AwsKRiQrCzX7MZyD0LJuqh/arxSQrX2peaQYhoTsWeBRDL4BEN7plkJ KyOpUn0baK5BjvcPON7UTYvhZIpvwR8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752646907; a=rsa-sha256; cv=none; b=KfKqvzpMlkZyznilzXi6QUSci3fH2n8El6KO03wSJ3BAq5OYsJtEbbeAOZy7EnCaHP+Uld q07UrJFPt/CpJ4uHeLoB7aeJTfFfBinWHUMaCYXIj+ELgvnKvvNKKhQjLKSss+CYAZ4pel rMBAHS+R1qBTco3yHkM4OuuYjAFritw= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Mofl2wKn; dmarc=none; spf=none (imf20.hostedemail.com: domain of BATV+d54f9d66dc200d3a0946+7997+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+d54f9d66dc200d3a0946+7997+infradead.org+hch@bombadil.srs.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=YKkz8lS5G74bKddbsW4P64woHWlQNnkiSMyItwjDQj8=; b=Mofl2wKno1Md6XD6b+fYMr4jXm 7SPSnCY3GTxiKu5cqwg/aT6B8jX4hK5FSYgXzUgPEeSbH8vsn7k5+RdI6SjHvqJZNiUmLuwRSiz+C wwUg2d1683/pnc39qjye0llTFXv04LmqzMPNpl9SSWg4xCnvRiFNIaUPR4gU+x7JjC1T+yqHSfZ4u dSUSRl9+/UF9lUsqkTBlYotLhOsx4hrv+nzwfIAr4nmXVM4xeo33TGKD4eNH4/T9fT/dXryvLz0Rc Mgo863jaxZZSnHCGdU8NGcr/iHEWxBzmp6UIs+hoTFQRESKy8pQSGoeM0hQO+DdseOnpSXCJKfh+o Jbqj6E6w==; Received: from hch by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1ubvWR-00000006sCF-1M3N; Wed, 16 Jul 2025 06:21:43 +0000 Date: Tue, 15 Jul 2025 23:21:43 -0700 From: Christoph Hellwig To: Thomas =?iso-8859-1?Q?Wei=DFschuh?= Cc: Al Viro , Luis Chamberlain , Kees Cook , Christian Brauner , Jan Kara , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 06/15] fs,fork,exit: export symbols necessary for KUnit UAPI support Message-ID: References: <20250626-kunit-kselftests-v4-0-48760534fef5@linutronix.de> <20250626-kunit-kselftests-v4-6-48760534fef5@linutronix.de> <20250711123215-12326d5f-928c-40cd-8553-478859d9ed18@linutronix.de> <20250711154423.GW1880847@ZenIV> <20250714073704-ad146959-da12-4451-be01-819aba61c917@linutronix.de> <20250716072228-2dc39361-80b4-4603-8c20-4670a41e06ec@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250716072228-2dc39361-80b4-4603-8c20-4670a41e06ec@linutronix.de> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: EB5721C000F X-Stat-Signature: kkq9rx9z4u9jc37co4xsyi9ztfcjmbq6 X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1752646906-69527 X-HE-Meta: U2FsdGVkX1/QLxNKFFvAUb7a3wS0AUz9DA8OeoxmmlvVsyMgltkzfXsZ9L6TY66BvdOvAtvzEUE62xBEWWxEtGigAiIWjPoretSY72FNay9nMXK/1BozY0hUMlQJDN5TuuggFp6uCeZYu2d3oFy2gvPt86zw5muWqO3O/751zxNKsiaQv48zQEB7t0r/SLrzt52oNgJRMpHGGPcNAoxStyvBovoN/I7oVbCn2gDBAOAp4LR+wMnPgi18fPZgQ3y3OFzdKSNw4PekrTmocDLdVZBDB9ur0dKab1ZiCMrdYMLiREbiGW5DefSjqd8WXebTXPgpYPwbTec3dSZ4inho7uDF6QpEfe2qE+UVOntYsHVPnmBquDJPafr2NLawclEUdFZ+UOILkeV8VZGekd0wc7P2HrqG5FwYuWWgWkE+bKb+9Rt801K8o/cDNuZ7739Ys7YtlzbQuXgrNn2M/L+hXltG3gAs2Tu7Yips/XNLhHHU94wrSsGOzF7dZWhrJOLvNpNbNqPSFqxtWsk572T3Ak0LZ8bJFxM3HZ+5WdobSOvcZBRZ94jThuXy0z4X5EQex2j9KehaE39WIWJ7vBWVkzChOdN1WDgIyTd+J0lAVVEQqhR8ijbosQoO/IAUgxw161bUWkmStiWnXBnhv3pdTZYDc4+cLp/2/rg0Gfl7IcA5AQevnCMutJRDN8ZGHjqvGrbAPIXHfN6WZHBrtLvHETrnq0SAsi1zRJohpgjA0/XT5txHtKv9+sNRsGaLz3VeMPnE8WgTGImCAJKcQjEWJfqgMLhHcLBexn+zP19UjMDLQGtVzoDSeV6v5p2h3Uxv+oAz/hQU48pX5KV/FfNhclpWk+sz9SpE0/bs5rU1tohAD/UObVmoBcNJquo/sgfCmlc868AfRIgBjFAy29wmnEHLxO/WVs11m9zxHF5qAkoiStHLdEA5vdHOsSh7X1sDZ2P3595o5/nzj7tSIIm Lv5fhH+d skx0+938kd95oid0QBjJs4vZHdEb10ukNAJ42Hdd5gVCZD8t0hhQI45P95JCd2HsKhYEy+XpcXKlEuqL41tjnJmuGvba8fUyzdYxt20lqcScm4P3TY76cNyOioSPwMlQvXv9eXHRVo8gRwiWWfzzMialrxECYuaDXhRWX2ZsZKNHgofYwffxqal5cZ1ub3epO1aBE40dqtlj6Yvt/wVJ7/rM7N+eP1GAp4LgXgsghsHyZszfUl2CVu2M+uUsBrxy8Fq7FDUFJMwhWd/NrqIUEa+LRBc/lbup4/XoFEv/9/lldLUVbGlveZC29IdT/HVPnfiQpluENYU/WVH1FppXisOKKkxwEAiHJMsyYFL0d97wwco3I3NGmYBiZSSYg3gayTGMRXs9T+ZSrfUW2N78mNSW8tF4zEwqQmRwZF4vI/mruX24gW1G+PCKMNI+P4kjKrJ1u X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 16, 2025 at 07:30:46AM +0200, Thomas Weißschuh wrote: > On Mon, Jul 14, 2025 at 07:52:28AM +0200, Thomas Weißschuh wrote: > > On Fri, Jul 11, 2025 at 04:44:23PM +0100, Al Viro wrote: > > (...) > > > > On Fri, Jul 11, 2025 at 12:35:59PM +0200, Thomas Weißschuh wrote: > > > > could you take a look at these new symbol exports? > > > > > > > > +EXPORT_SYMBOL_GPL_FOR_MODULES(put_filesystem, "kunit-uapi"); > > > > > > What's that one for??? > > > > What are you referring to? > > Reading this again you probably asked why put_filesystem() is exported. > > As I see it, that should be called after being done with the return value of > get_fs_type(). Not that it does anything for the always built-in ramfs. > The alternatives I see are a commented-out variant with an explanation or > making put_filesystem() into an inline function. The right answer is to rework your code to not need all those exports. Nothing modular, and especially not something testing only should need all these low-level bits.