From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77ABCC83F1B for ; Wed, 16 Jul 2025 07:02:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E5DFC6B0089; Wed, 16 Jul 2025 03:02:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E0EAD6B008C; Wed, 16 Jul 2025 03:02:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D24886B0092; Wed, 16 Jul 2025 03:02:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C40346B0089 for ; Wed, 16 Jul 2025 03:02:30 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 44B2B80283 for ; Wed, 16 Jul 2025 07:02:30 +0000 (UTC) X-FDA: 83669234460.20.2DB1389 Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) by imf18.hostedemail.com (Postfix) with ESMTP id 46B2A1C000B for ; Wed, 16 Jul 2025 07:02:28 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=YnRdaSWl; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf18.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.43 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752649348; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IpbTFITF67s5ytx3WF8TIyUbw/oI1yuXLAr1FOz7XUE=; b=8PidL64TAjuNmkyY2lAevpr6rfgGQ/hKxEJe2CCsVdBtG852Mq6gotTIBntA2cbx4MlbUj 6h5O+yU9DbgFZCioAlbdD1QqfqNgknCipXV/940hZCLCgLZZeIc4AeQ/xCTyeK/asGj05I j8Y1N7OSDF/scygXK0m3uuwGp4FpNDs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752649348; a=rsa-sha256; cv=none; b=3DXKF8xcVjoIf2p1AFQ5uWWZJmcL2jGgq8FX45a0n8o3VR6d/mVOHQiR+al0N809L1TBpi lvBhQi8IXIP+wWNU8naEu2fzy/GT9yV9iX3AEQrt0CsqdPdBxhxWMXmxdIsGfRJwxJCJg8 weyzgXWXS+5hJQaaKGotCDx3IVAUhsE= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=YnRdaSWl; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf18.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.43 as permitted sender) smtp.mailfrom=urezki@gmail.com Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-553c31542b1so5923894e87.2 for ; Wed, 16 Jul 2025 00:02:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752649346; x=1753254146; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=IpbTFITF67s5ytx3WF8TIyUbw/oI1yuXLAr1FOz7XUE=; b=YnRdaSWlh7R0I4K9O6H7BP2FDkj+SdsJvc2IiVbhte8wUXxDsmpxncgOVkgudERJFn 0PZhX6zpu/GOaTP1xCQ/OlBCRLIaKafcEZfqWki8WH9ILLpcDqgVCfeAT9oDhErQTUZ4 1Cfd2g2JceUedmQyvTdmvOkWaXDd8o6wIifruZ5ptwVzgBAqfvj3tXexk0KaBBl3oSOH fJnrsKWFPQRad7ktHBAtD4DlJxulTip7APuT6Pb7V2Fo5RcsembSXUHPmb2lVjUHXQ6t sMtQsUyKPRIy0fwCck1DqiJMtcqaE5EzXF44JIX+nqOovr3sjbR8jrGQCiRQXUXv+hwa DmrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752649346; x=1753254146; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IpbTFITF67s5ytx3WF8TIyUbw/oI1yuXLAr1FOz7XUE=; b=BFVM9lzO1usEbHrmoCDarYnbzjei2qMQg7uzm1D7INmaouLokemOSqEn9MZZSwkGzJ tTtYyX7V/0eMNLoSSjos9bN0jtWRV4gTaUUgoX3IHxbAXiZZCr0KtddCc/eAMHKFtMXQ y38unjeIEdxdQ391Ctq0yUk35aikgPYki8cKV0UvFXe67v2gfPJxYBL3LZQAvJDu+QKg pmb5Ef62A1gKZYV8WMxg5E8ZC2IzCfPD/Wn7NtKzmuosgpXngzUba8nNvlIeotr+5I9q Fv1SpJiAMR5v4SLnWwYDeG7UTL82cBCBfaS6DHjb7SNMcTbZhYKGxZjhGhysujkkvWKc HtbA== X-Forwarded-Encrypted: i=1; AJvYcCVMugaCaTIgBxayfSLwSPZ34ABY1tnC0PkBH/zeAfUl4KzCCxZtBc8JwvJoV5uVcrO4tDO/SIIJFg==@kvack.org X-Gm-Message-State: AOJu0Yz+/tuQ/jqfG+38LGBUKd0kYs/b7uVrhpqGbOA33jawASlhVjHs aQDQndp2Qq5WonJT1+qBmzP5lHJHm4rSY97PqAVvaGibfxelrxtX+C4s X-Gm-Gg: ASbGnctZPPEBNErHXMOAGyQAxiJgDl9i/HEsiY00BQ+FsB3Fcdpph133+uEGvK930Fl XtV8xavjru/t5F+M8bxnp6hVY3l8HmQRm4ECTALRLukxYTCm0KQ+3J3FiesouB/CLxIC9ux7pUh bJPSchftx78GolzmuG4wOkVNwfO8gxa4WtwZEuJS1usLsUDzvIWfsyGsjmnjsVgM+gDYQdZ4eoc kFyGl3REtbOKJTezyOzfhK9oTTXMF1vwiAd1vMJqQW06/9y8T+SvR13qzKjG600ZqqHYRrlU1V5 v6EHnBZCwvw9BXBn7Sj8pBDd6ycQmJzJY5kxkabdUDS88sd7mv9fKkBr9TaDTJKpqr1rOCo3Iib xUXrvZIZdp0NYuEiVyP+BtHCGWCWWTU0eLCS41B+Uzh3IHJg= X-Google-Smtp-Source: AGHT+IEaQjkkeF2ySgsL9PJxlSd912c1e0hN8v81h0Xze53G9AuaujDLm7o/XYcnrMZzTnbqw1FiGw== X-Received: by 2002:a05:6512:118f:b0:553:37e7:867b with SMTP id 2adb3069b0e04-55a23f5660bmr595211e87.31.1752649345904; Wed, 16 Jul 2025 00:02:25 -0700 (PDT) Received: from pc636 (host-95-203-27-91.mobileonline.telia.com. [95.203.27.91]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5593c9d32c1sm2531820e87.125.2025.07.16.00.02.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Jul 2025 00:02:25 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Wed, 16 Jul 2025 09:02:22 +0200 To: Hui Zhu Cc: Andrew Morton , Uladzislau Rezki , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , bjorn3_gh@protonmail.com, Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Geliang Tang , Hui Zhu , linux-kernel@vger.kernel.org, linux-mm@kvack.org, rust-for-linux@vger.kernel.org Subject: Re: [PATCH 1/3] vmalloc: Add vrealloc_align to support allocation of aligned vmap pages Message-ID: References: <81647cce3b8e7139af47f20dbeba184b7a89b0cc.1752573305.git.zhuhui@kylinos.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <81647cce3b8e7139af47f20dbeba184b7a89b0cc.1752573305.git.zhuhui@kylinos.cn> X-Stat-Signature: a89r3hso67iq8ic4sfqjx14mkag7cscn X-Rspamd-Queue-Id: 46B2A1C000B X-Rspamd-Server: rspam10 X-Rspam-User: X-HE-Tag: 1752649348-511648 X-HE-Meta: U2FsdGVkX19OTmVUp1x49GD7UP5X2uUlbeTFOs1Iha28ABY3jNvd0wJOLr4sWdgYOvt2BQjZmKhwXeH0Zb0pOC1XyftAUFZnJ2vCXDoJHbTP9SiSiiJYHJI5PZwCunCet9qFJ2Nydr2iMuB6d2vRtwKIouKqEGyUvOjDfhoh+NfzCYJqdlX2Fl1S7M/t2u3LLqArJ+N51RTFPMyVzF4tjkBAm9YbgIZGH2wN3YOZ06bVOZ3ThDj695m+A61MgA54fsM5lHwM9EZ7j7tJSHb2JiMiyutEO736s0AxshDpv4mG8dkB8fQtRYqIRPdIhgtMFj3H+BDHcRHd0fLpZ71S5b/NBTVgS+U5//qJwiUj/jb/eHeRTXSiXbu8MSB3lTNy+aQ8O52gm0Iwfu68lSqZB+E1cEPnrvSNA+wcSSnAjGng1H2BYE2WfNfAe7+lcubva4uQLrFsvr0HBs6CYEex5mPVMU/92WeINOVTW54QIPEIJ7zbgBXLzKSDh71QTvsu2sdf23TYE/ZgRPHvsaGfMlDta5K0llhUqjyJJRiu50QY3wseNCiSgbgoMtMUEiRmKZ0yrhS41EE7kQai/K3NMRlkWKV7u0J6mXtTEwBUvnWsUse6qsRHFouolo7C/QbAuCJE2tz9l54UkgRyHeTQvdkmTgECA5uqgljADGF/gwK3ysWSUaSqRRPZdA5duWQmDPaoF1JWyJlQNG/kpUGBfMwdMIlCgvo6gLPJyh/q75Ah9Za2aaaZZH9TmN5IqGPCx50kk38fxu/HUKVSwjehZVUv2xQErGKsX9sM0qONqjxtBWJZexVV6mYCZs7YrYTT9Tl6bVhDbSAC6nf+Z3E+3/wVyeddbGTSwiT0r3my5flOn1WlvoOJzq2ffiE+YK+4gpLSrb5m7ZezZHE4Gx6clcUSFzhwAGU4p1a5TP5plIdS8uDtBQmvYoxx/ps+63GaLnqkNr9tXaJTHAE7QSE U+/tl9Dp 4Dmh8l2v13HO34/Oie9H/dExkqYXem3f8ltkSzKlZFYhFhLbfN7evlDR4w9PsrVxIODBmU+h5RiiKyLaVSzBHsiYyE6bBW7KvlzuQ+f0LOFHvQ4GxYc3cTJlUMLA43QJuFOJhInw2ZpBT0pvmlHyweFauqen3Wdzj9kX5t/1OpT7G1x3DPrDis7MnaRpR1SyKEEvYVovDCfaR2vrUFTLSEWe1dGCD12e4zHX6vnTdRO2O1rBumSQVxZWwOcfcScYcAY4i41iacAuiw2SDTFiZhRfFB1+mNT8jvkbqN4xESH7ahjApCNdTf/plDbMju5QN2G8R/CUUtINPOlm5clak4qGNAOz1nUPXRU3Uhjxg93u2FzvceBvUXfSMPui1fbRcZKaVlUB0NDDq+lesmmr0M6/r13sHJvZVOstUFwbX2iakwEKLNXvro02isuTvRdBMBaAh55cSI+FEGOxG5JgrkSlpqenyFVTx6nfgpmjUeHM6ylAjN5BjWXzy4/LTGhd6Pb7vn96YzsTuJKjDTcM3URaNgjl/TlS84AyKn2M1LmGfK2lqLCdkjvGoy1+chBq7aH6pYjTbbfi4Si2rFEb9dPxaWoCo05MHHoAKtVPDWMVidan1SnyzljXg8NeP1+zZv4MD6Sa6R5oOW6VRbPgaYKvUyR/VXwEw50gm X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jul 15, 2025 at 05:59:46PM +0800, Hui Zhu wrote: > From: Hui Zhu > > This commit add new function vrealloc_align. > vrealloc_align support allocation of aligned vmap pages with > __vmalloc_node_noprof. > And vrealloc_align will check the old address. If this address does > not meet the current alignment requirements, it will also release > the old vmap pages and reallocate new vmap pages that satisfy the > alignment requirements. > > Co-developed-by: Geliang Tang > Signed-off-by: Geliang Tang > Signed-off-by: Hui Zhu > --- > include/linux/vmalloc.h | 5 +++ > mm/vmalloc.c | 80 ++++++++++++++++++++++++++--------------- > 2 files changed, 57 insertions(+), 28 deletions(-) > > diff --git a/include/linux/vmalloc.h b/include/linux/vmalloc.h > index fdc9aeb74a44..0ce0c1ea2427 100644 > --- a/include/linux/vmalloc.h > +++ b/include/linux/vmalloc.h > @@ -201,6 +201,11 @@ void * __must_check vrealloc_noprof(const void *p, size_t size, gfp_t flags) > __realloc_size(2); > #define vrealloc(...) alloc_hooks(vrealloc_noprof(__VA_ARGS__)) > > +void * __must_check vrealloc_align_noprof(const void *p, size_t size, > + size_t align, gfp_t flags) > + __realloc_size(2); > +#define vrealloc_align(...) alloc_hooks(vrealloc_align_noprof(__VA_ARGS__)) > + > extern void vfree(const void *addr); > extern void vfree_atomic(const void *addr); > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index ab986dd09b6a..41cb3603b3cc 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -4081,9 +4081,11 @@ void *vzalloc_node_noprof(unsigned long size, int node) > EXPORT_SYMBOL(vzalloc_node_noprof); > > /** > - * vrealloc - reallocate virtually contiguous memory; contents remain unchanged > + * vrealloc_align - reallocate virtually contiguous memory; > + * contents remain unchanged > * @p: object to reallocate memory for > * @size: the size to reallocate > + * @align: requested alignment > * @flags: the flags for the page level allocator > * > * If @p is %NULL, vrealloc() behaves exactly like vmalloc(). If @size is 0 and > @@ -4103,7 +4105,8 @@ EXPORT_SYMBOL(vzalloc_node_noprof); > * Return: pointer to the allocated memory; %NULL if @size is zero or in case of > * failure > */ > -void *vrealloc_noprof(const void *p, size_t size, gfp_t flags) > +void *vrealloc_align_noprof(const void *p, size_t size, size_t align, > + gfp_t flags) > { > struct vm_struct *vm = NULL; > size_t alloced_size = 0; > @@ -4116,49 +4119,65 @@ void *vrealloc_noprof(const void *p, size_t size, gfp_t flags) > } > > if (p) { > + if (!is_power_of_2(align)) { > + WARN(1, "Trying to vrealloc_align() align is not power of 2 (%ld)\n", > + align); > + return NULL; > + } > + > vm = find_vm_area(p); > if (unlikely(!vm)) { > - WARN(1, "Trying to vrealloc() nonexistent vm area (%p)\n", p); > + WARN(1, "Trying to vrealloc_align() nonexistent vm area (%p)\n", p); > return NULL; > } > > alloced_size = get_vm_area_size(vm); > old_size = vm->requested_size; > if (WARN(alloced_size < old_size, > - "vrealloc() has mismatched area vs requested sizes (%p)\n", p)) > + "vrealloc_align() has mismatched area vs requested sizes (%p)\n", p)) > return NULL; > } > > - /* > - * TODO: Shrink the vm_area, i.e. unmap and free unused pages. What > - * would be a good heuristic for when to shrink the vm_area? > - */ > - if (size <= old_size) { > - /* Zero out "freed" memory, potentially for future realloc. */ > - if (want_init_on_free() || want_init_on_alloc(flags)) > - memset((void *)p + size, 0, old_size - size); > - vm->requested_size = size; > - kasan_poison_vmalloc(p + size, old_size - size); > - return (void *)p; > - } > + if (IS_ALIGNED((unsigned long)p, align)) { > + /* > + * TODO: Shrink the vm_area, i.e. unmap and free unused pages. What > + * would be a good heuristic for when to shrink the vm_area? > + */ > + if (size <= old_size) { > + /* Zero out "freed" memory, potentially for future realloc. */ > + if (want_init_on_free() || want_init_on_alloc(flags)) > + memset((void *)p + size, 0, old_size - size); > + vm->requested_size = size; > + kasan_poison_vmalloc(p + size, old_size - size); > + return (void *)p; > + } > > - /* > - * We already have the bytes available in the allocation; use them. > - */ > - if (size <= alloced_size) { > - kasan_unpoison_vmalloc(p + old_size, size - old_size, > - KASAN_VMALLOC_PROT_NORMAL); > /* > - * No need to zero memory here, as unused memory will have > - * already been zeroed at initial allocation time or during > - * realloc shrink time. > + * We already have the bytes available in the allocation; use them. > + */ > + if (size <= alloced_size) { > + kasan_unpoison_vmalloc(p + old_size, size - old_size, > + KASAN_VMALLOC_PROT_NORMAL); > + /* > + * No need to zero memory here, as unused memory will have > + * already been zeroed at initial allocation time or during > + * realloc shrink time. > + */ > + vm->requested_size = size; > + return (void *)p; > + } > + } else { > + /* > + * p is not aligned with align. > + * Allocate a new address to handle it. > */ > - vm->requested_size = size; > - return (void *)p; > + if (size < old_size) > + old_size = size; > } > > /* TODO: Grow the vm_area, i.e. allocate and map additional pages. */ > - n = __vmalloc_noprof(size, flags); > + n = __vmalloc_node_noprof(size, align, flags, NUMA_NO_NODE, > + __builtin_return_address(0)); > if (!n) > return NULL; > > @@ -4170,6 +4189,11 @@ void *vrealloc_noprof(const void *p, size_t size, gfp_t flags) > return n; > } > > +void *vrealloc_noprof(const void *p, size_t size, gfp_t flags) > +{ > + return vrealloc_align_noprof(p, size, 1, flags); > +} > + > #if defined(CONFIG_64BIT) && defined(CONFIG_ZONE_DMA32) > #define GFP_VMALLOC32 (GFP_DMA32 | GFP_KERNEL) > #elif defined(CONFIG_64BIT) && defined(CONFIG_ZONE_DMA) > -- > 2.43.0 > This is similar what Vitaly is doing. There is already v14 but as example see it here: https://lkml.org/lkml/2025/7/9/1583 -- Uladzislau Rezki