From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB04FC83F27 for ; Wed, 16 Jul 2025 08:20:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8D8FD6B00A1; Wed, 16 Jul 2025 04:20:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8B0A06B00A2; Wed, 16 Jul 2025 04:20:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C6E66B00A3; Wed, 16 Jul 2025 04:20:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 6DD716B00A1 for ; Wed, 16 Jul 2025 04:20:50 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 492DA12C4D2 for ; Wed, 16 Jul 2025 08:20:50 +0000 (UTC) X-FDA: 83669431860.17.81A976D Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf26.hostedemail.com (Postfix) with ESMTP id 2A4D1140004 for ; Wed, 16 Jul 2025 08:20:47 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="Kra/SNnC"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="k/6sTKZd"; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="Kra/SNnC"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="k/6sTKZd"; spf=pass (imf26.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752654048; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7R+hCBYnvSZ+PSORPTHDk4t1hNJZ7tafG6Xa+YTLyPY=; b=R+4o5NUPO4DbJtwPaowo0di1DcURYXw0eXSnY9ZZcPRs+DLHnmNXPqsuyH2+ifSQuULyJw +BRS/0CzzvrvcDhhYpF4FRupPUOYcqhI1OjiwFaO3LPiw3b5WQRavR3CkE/op8CxIQYOzM EpjJWo278VRodudgHFKAzkWofVMFGNc= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="Kra/SNnC"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="k/6sTKZd"; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="Kra/SNnC"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="k/6sTKZd"; spf=pass (imf26.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752654048; a=rsa-sha256; cv=none; b=voeEl9RQFr4TSsGFnodCf8Lk2K96SPXmfto4Ey/D7cESoOS2mJUtSb30XADHYv5tDw9NFu YGsH+BTj+M3dXCEBGkxhuSOBRWVeat+Id+Y+JZjatoPyu8VwscizCEbzFjXPQh2E785y96 +vRH/ibS4YpO7A4+rEG4Y6cvmLFrKYA= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D381321235; Wed, 16 Jul 2025 08:20:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1752654046; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7R+hCBYnvSZ+PSORPTHDk4t1hNJZ7tafG6Xa+YTLyPY=; b=Kra/SNnCnlFmArihgtpkJnlBzxIFiix4eMZf8WbVVkUNgMLSzRRITKBrwHMb+8Ue4kkSbB 6PvwD7ORnT9v0Rmx+Wr3QL4PXlhl3U9RJ/JDrXNXqtGIqOF3x47fvHiOWLZ3Sx72WtF/d6 pM64q1fFj3EuMQZlsG/KvMhVtNdQQks= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1752654046; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7R+hCBYnvSZ+PSORPTHDk4t1hNJZ7tafG6Xa+YTLyPY=; b=k/6sTKZdoXEEDiueorLGp+Ptu/WsaOoSciT+ZR/RD/N7j9lULKWQVfeKfHwwdOHcPUBzS1 88PpQ07hwEjfNxDA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1752654046; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7R+hCBYnvSZ+PSORPTHDk4t1hNJZ7tafG6Xa+YTLyPY=; b=Kra/SNnCnlFmArihgtpkJnlBzxIFiix4eMZf8WbVVkUNgMLSzRRITKBrwHMb+8Ue4kkSbB 6PvwD7ORnT9v0Rmx+Wr3QL4PXlhl3U9RJ/JDrXNXqtGIqOF3x47fvHiOWLZ3Sx72WtF/d6 pM64q1fFj3EuMQZlsG/KvMhVtNdQQks= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1752654046; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7R+hCBYnvSZ+PSORPTHDk4t1hNJZ7tafG6Xa+YTLyPY=; b=k/6sTKZdoXEEDiueorLGp+Ptu/WsaOoSciT+ZR/RD/N7j9lULKWQVfeKfHwwdOHcPUBzS1 88PpQ07hwEjfNxDA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 5085E138D2; Wed, 16 Jul 2025 08:20:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 8H0GEd1gd2jdEQAAD6G6ig (envelope-from ); Wed, 16 Jul 2025 08:20:45 +0000 Date: Wed, 16 Jul 2025 10:20:43 +0200 From: Oscar Salvador To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, xen-devel@lists.xenproject.org, linux-fsdevel@vger.kernel.org, nvdimm@lists.linux.dev, Andrew Morton , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Dan Williams , Matthew Wilcox , Jan Kara , Alexander Viro , Christian Brauner , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Jann Horn , Pedro Falcato , Hugh Dickins , Lance Yang Subject: Re: [PATCH v1 8/9] mm: introduce and use vm_normal_page_pud() Message-ID: References: <20250715132350.2448901-1-david@redhat.com> <20250715132350.2448901-9-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250715132350.2448901-9-david@redhat.com> X-Rspam-User: X-Rspamd-Queue-Id: 2A4D1140004 X-Rspamd-Server: rspam06 X-Stat-Signature: c53yehauschjs6an44j1jqe3ojtrnquj X-HE-Tag: 1752654047-139865 X-HE-Meta: U2FsdGVkX1+oAqmtd1d0Y7hKwVzJ7ooCfDL4zt9xNZJIZbJx9G/XP4381oncTsiizWPVzIM1tMwf9gnFJrFKFWIQ0e7GErz5wtSXndoNw49DbDDoBvSJsptutcMmIjyAXgAHXJ4S2oGBFw0+x0itoW9c1KQROj8+KwV/3Ks5hlhQ9LFGXS1szTQNNYG9EMFudpXfx8oJ2IaSpEjDX6MVsRpujzORNfWfXZJuVyatS4lxUlLHmas0NYigOYUD8sjS5toB+thEMKwpYQu9wVSFwwh4XGBYaHxkgH7H3gMU8UkM4DzuPMNWYI42bCr1bcgzcxhfJGloNT6FDPa4v0Xb5W1+MHOFncuW24R0Z3aJbWOwFr6D0epd2C8aYyi4MS6PvK0O08w2KJuAp1hgt6xV+nQquQ5MK/7pS6vNeRdJcmpM9/vSNbdEPtftyDfth8GKGqD7GcZrD1qcHZBItuAZz4K7u3KTsovlbS69mPY7jF+UVpC8TIAC3Xdku1IM5p61uQaDQsYQwaogCUqRJa4SWGooq3WlYUmK9dM71J56hm4tugFwdvItSTnWRYsy0yWAJSEBxGa8ivBnD+97p7svCPjhxzAuK19oGKgJtobTgemOU3lhUH0AUdQ/iVYA9BKDHOj2cNxK4C0S/zlnVlit/XfcwcOnoIM8ORP0FkIFP8E6m9QZtUlezY7Pz0fTKDDK2zQXizmhfWB7zyDQHaQk/1NquFg60B+x+AT3hySNW5m5EGhpg7qC8uNeQaLJw9Qw//wLU8zkaqGNBLzlxvuqBIjAIJ4LVr5VzW5gfGnOrC5s7u7DI2WUM+ucrG+17jOPqxJbdyJdvQbQdbqhS5DXpYc5EUg8cpWzmrmnRSp8zj2ZqWfM0Bwt4n2/PYRR/Vul5tNguuPyu2V4ZxDF/Hs1YrL3yahm6DWJeP9RvUCA1v0VEQmK4l2h3WF09M5/mwzfvfV4UDyENzGHp1QW0eA +P7TjPZg M/pZTZyKeSqD3YmR3num2g7TOPTzC5lIO+7wrPGjQiJXAbVbHi0w1Opb7hQ8yqUV231mGfZvxzsIEZOlW9VVJYgngNaSMka+MWFKefTIQT1o1gLuwDav+JuH8DdGtQCMpd+c9dDmg8UX3c1/V5z0WrPilLHW5DrEAkW4C7CpHyl+hC1pGhHfGu1vTK834lKEyt14H7K8cJbwupyResEnEGLlN7hNS/ucRZV78kzlQf1XEMbyk4DTQxnSRCeuMCBV8iNdJEltIQgpXjOa2rsVwZzn+KwoouYI+SmwiAvrMHlZrYkNKY+l/QVuSeISSmG4RnEG1CODcRxugLT8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jul 15, 2025 at 03:23:49PM +0200, David Hildenbrand wrote: > Let's introduce vm_normal_page_pud(), which ends up being fairly simple > because of our new common helpers and there not being a PUD-sized zero > folio. > > Use vm_normal_page_pud() in folio_walk_start() to resolve a TODO, > structuring the code like the other (pmd/pte) cases. Defer > introducing vm_normal_folio_pud() until really used. > > Signed-off-by: David Hildenbrand Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE Labs