From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48DE6C83F27 for ; Wed, 16 Jul 2025 08:22:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DE7166B00A6; Wed, 16 Jul 2025 04:22:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DBE746B00A7; Wed, 16 Jul 2025 04:22:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CD3B06B00A8; Wed, 16 Jul 2025 04:22:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id BC3A76B00A6 for ; Wed, 16 Jul 2025 04:22:54 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 37C2858487 for ; Wed, 16 Jul 2025 08:22:54 +0000 (UTC) X-FDA: 83669437068.09.128F268 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf28.hostedemail.com (Postfix) with ESMTP id 185EAC0009 for ; Wed, 16 Jul 2025 08:22:51 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=yc7y2C6O; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=fOdMwmH8; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=SKtCDwxJ; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=VQapEGWN; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf28.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752654172; a=rsa-sha256; cv=none; b=bWUI/AUYs6ev4AUoWY4qpaThQZuVMlFin9GBtFSK1lXnzr7+9JkVT2BzznteEN6cGlqAyK f6XZiQ3z97v8WQPdk7j6t3IIPaDXHxhyorLC2nQZf1Bq/3nLe2BctJhxEKP5e8m3FK/29N 5yLePQ795n71KP/KM4nIFeVhAHO6ax8= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=yc7y2C6O; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=fOdMwmH8; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=SKtCDwxJ; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=VQapEGWN; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf28.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752654172; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eYaQzTxO2EXAgTj5Tmh3qSEBV9qTyqV769ionVDxydo=; b=OCEPzNd2CeYMA0gv3n3RjvzQgmb6l0qmVryNqCLMdJeeyw7lofRiV2VstNTbTUpis/VMOs bPR7du9LnPWBYTWJXpTyV7SaAsOBq+5YJ3ik0wnAoqWKa6IzvwmZpGMT513Y9EW6ofsGGt jFPkflfFaVm5tOB0ysEXpit3oxItmAw= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 9648F1F38E; Wed, 16 Jul 2025 08:22:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1752654170; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eYaQzTxO2EXAgTj5Tmh3qSEBV9qTyqV769ionVDxydo=; b=yc7y2C6OOZgd4x9WIB5Fsl5oTCcbpQz4jm9Kq+EoQ9QCutH+KbLCj+1v0aHvRp1LeurUkI FRfAMBG3EYJvSVy/R8oTFZl4/s2L/BXL5ak5CEHwZqwepHvnP8qYDdwm2w1DImdMO8wo5W 9xerIS40xW1fufGncx8MwTgRWWJmQy0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1752654170; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eYaQzTxO2EXAgTj5Tmh3qSEBV9qTyqV769ionVDxydo=; b=fOdMwmH8kyrOPeSCUT5zBSuQ4lVq/Id6NVZseDv1XtbuqIDi6Ll775JTt4ecNanN5XH1Ew GQ5E28xqUI+nL6DQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1752654169; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eYaQzTxO2EXAgTj5Tmh3qSEBV9qTyqV769ionVDxydo=; b=SKtCDwxJo8nPlZdaW/yBPWECZgSEX/cx5Irqq/nvAQZvIzEYHdR2l6HG4Wp3ZpYwuAws+5 VowBBx1gQ5vvxwv7gamBKohfkbdqAIm5hoyZKQri15D6GihKP3XFHBoIhCJ/xqvsK3tK9L COaG7EuEkg8Syz/YKsGgM+fDj8uaQvQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1752654169; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eYaQzTxO2EXAgTj5Tmh3qSEBV9qTyqV769ionVDxydo=; b=VQapEGWNmv38Ig5isE+uVRHaUwcAwA70C/LQrjGZLGVEAwj5qiXZ7Nl9qdWIWHjMFl73fN RWNDObOLEczLSQDg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id E588A138D2; Wed, 16 Jul 2025 08:22:47 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id WqVdNVdhd2icEgAAD6G6ig (envelope-from ); Wed, 16 Jul 2025 08:22:47 +0000 Date: Wed, 16 Jul 2025 10:22:46 +0200 From: Oscar Salvador To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, xen-devel@lists.xenproject.org, linux-fsdevel@vger.kernel.org, nvdimm@lists.linux.dev, Andrew Morton , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Dan Williams , Matthew Wilcox , Jan Kara , Alexander Viro , Christian Brauner , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Jann Horn , Pedro Falcato , Hugh Dickins , Lance Yang , David Vrabel Subject: Re: [PATCH v1 9/9] mm: rename vm_ops->find_special_page() to vm_ops->find_normal_page() Message-ID: References: <20250715132350.2448901-1-david@redhat.com> <20250715132350.2448901-10-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250715132350.2448901-10-david@redhat.com> X-Rspamd-Action: no action X-Stat-Signature: ry3jqhbzf6835cu8zf9uewgnyuz5m5f5 X-Rspam-User: X-Rspamd-Queue-Id: 185EAC0009 X-Rspamd-Server: rspam02 X-HE-Tag: 1752654171-476934 X-HE-Meta: U2FsdGVkX1+C55hfxYez5nWkdI5hU/V0GP6abP63wO01xq9qxv9i0Xy3KKwB4Bim7P5fX/sxD7wXVqoPL71fF1vbW8QKpUvwtN0IpFe/A99eVjPuAdLHh8aOxj2G5QmW5yeFsUIyTeIOFTsVSGPL3C7m4rR2t8AGHyJ3w23fzhCf3QIpZIWIPuGJ85LzWsPLTyC+rotRaRMSFSU/FoNF2XJ4Qq8cWZ/I2YlDvzHrPYmmO2hfr/HYjlfOxTUzpTM1Ywvne+utx0usBmmPdbd23aHRa//A2ORZveymGEcpyJs/Uh7Sje3VNc5BdC0sOBf8l5KwoAYTRx/3VJiwS128jEjDrpLCIMiuFoulk920UCwjXMwGWXDwb6FPh4KYybzri2ni2i+TXYgvrewN+o1OLU7b18wlnZ4zJG7NPbwC9FGt0eDHfte1sjQ31Q0icJm/a+GQuOw7j0RzAgdKnrwY3d4zKFOW9WJnxOdP038NmuLayx4f6e3zszJOseZMRaovRYDM5ew5rVyan86orm9r+A9uHtAwxngclMdydMOH9ZSvXKNAOY/aV9HvKtjKdSmGvbQx2iLPzTpzpb+w9Nx/8F6j9xRJNrnGazDA0HGmCx+grgBSRj85C+h4G69jD0vDJblHfG/OSwWca90NwdcV63KjELS8xvCzL5kbYo158srA6DcoA6WMR/DstiQxDvkg44/L4qyUX7gpMx2qOFtYa90yn93EeWL7eNTNKJnh8EE+2X3NrwIa0Wa3kpsK5ZoXkDhG3QsDM2569Fn3s0Tnty5+1qsV6WGN67nc7K4VOhdGiZTAyvMzO5UWDQNDTXzZ+ayKHv52ettP5ppqDxQ2IAA/dN6sxzszgY7btMxG6PpJBjPe6Td8AJhW1kfCmj8dihYeGXdMh//PTylepsWROlkn0IyATQWN2pfRnJRWBumvnNF4wn4oP9lIJ6SVW41YHyA/nDtjRf3sF9GfogF PpGovB9s Gracwfi6xwAs2ho5UiqiDYwPmdVjwhLFHsmHn7g2K4xJCrjM7wP3TmdHtbL4pHn3k8nnn4FZ0wevQzGSkI3jsTjyB3iv82dz44quUD/Pb934Nhi27uLWHJu2BbEk6uiuIOREDEMHNA7UerUgIxq3aWOPPFE7BNiIxAZ2HSTIS//lqpmuZ3kb3l559MU5/wcIFhqfxRGxed8cZeiVxFICGBJXCoEi66VIpv3KIELhLQvvr9sP3um3lx7dz8CYL+AAp3n5hQ7Do2hyTT7zH0A3YtwNa98BYyApvR6OvA8A4K7S4jz5RsUBDLoTyMGcidVntRtJLadHMqmUqyxCncxzKU8tF/ejX3NFfV+BZpMphgewfZhk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jul 15, 2025 at 03:23:50PM +0200, David Hildenbrand wrote: > ... and hide it behind a kconfig option. There is really no need for > any !xen code to perform this check. > > The naming is a bit off: we want to find the "normal" page when a PTE > was marked "special". So it's really not "finding a special" page. > > Improve the documentation, and add a comment in the code where XEN ends > up performing the pte_mkspecial() through a hypercall. More details can > be found in commit 923b2919e2c3 ("xen/gntdev: mark userspace PTEs as > special on x86 PV guests"). > > Cc: David Vrabel > Signed-off-by: David Hildenbrand Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE Labs