From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06E26C83F22 for ; Wed, 16 Jul 2025 11:11:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9CC338D0002; Wed, 16 Jul 2025 07:11:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 955798D0001; Wed, 16 Jul 2025 07:11:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 844838D0002; Wed, 16 Jul 2025 07:11:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 70A958D0001 for ; Wed, 16 Jul 2025 07:11:11 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 1D0771D9D8C for ; Wed, 16 Jul 2025 11:11:11 +0000 (UTC) X-FDA: 83669861142.28.9044E93 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf27.hostedemail.com (Postfix) with ESMTP id A02AA4000E for ; Wed, 16 Jul 2025 11:11:08 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=WpUi2ixj ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752664269; a=rsa-sha256; cv=none; b=cwwWdrvfJJKW2ouGqp16jU6Bw8CvICYfhPeaietYo1GnUVPaPmGvkHztgqiT1jxKTl+r2K kCiuv16v6YB170xrbbHYwcYvxaqXOA1yZJ1z0gwZHV/FKZWqV2YyINgeCc3hlW+2gIjce4 R0LU0ZpUqJK6v/jJfzrpZHp7gehBvnM= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=WpUi2ixj; dmarc=none; spf=none (imf27.hostedemail.com: domain of BATV+d54f9d66dc200d3a0946+7997+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+d54f9d66dc200d3a0946+7997+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752664269; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YNM4YXiRTugYP4St2XF/wvdNCP1F0YhY9Wc6I1yX/lQ=; b=fLLoWUwnKG9yVKSgTGp8he4PNDgkkg+jm588Hwi83IGPYv3bb6vGTwBxvcGzdS+vpMbt11 Ef1nEBqSdsjX6T4uLdyKKSrbarhD/nGeuF2eqAhIvNHTSBU+AFrPageNnwbK3o47c+AKTA 9WwblAldvCGR8WQG1CsEeJWWD8gnuQM= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=YNM4YXiRTugYP4St2XF/wvdNCP1F0YhY9Wc6I1yX/lQ=; b=WpUi2ixjQpHpCwpmWHNzQ3ZPH4 TAIyUU3rZLF9AvlXQDLcnV0SDyrNC2F+DSLxKxKjiB/Wj6rSrPey8QjQjKU4s9dHi4X/2kQWF2dle 1yjmJAa04ES4ukuR0WJ/SQH/SihjW6nW1i4EIlOex3G6REXNZlWSh9uMgt2/jUwIb/iJVnVRBEWOO oUCn4VY5w3hXMZ1Fx9QXOcvyg8runbraUzuG0/AB+RW+qhBbmj84GwExKiaonqxdvi4lSindp7K+/ C4q6ZoOEfe4YnE8W4uMrsjcz5ck3CNyqcAsjV6kdIqRNMCOiuP2Qc3bbnh8jngcdblZvgbMgG4M8p 3Zn9UFRQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uc02S-00000007WPi-3mfS; Wed, 16 Jul 2025 11:11:04 +0000 Date: Wed, 16 Jul 2025 04:11:04 -0700 From: Christoph Hellwig To: Thomas =?iso-8859-1?Q?Wei=DFschuh?= Cc: Christoph Hellwig , Al Viro , Luis Chamberlain , Kees Cook , Christian Brauner , Jan Kara , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 06/15] fs,fork,exit: export symbols necessary for KUnit UAPI support Message-ID: References: <20250626-kunit-kselftests-v4-0-48760534fef5@linutronix.de> <20250626-kunit-kselftests-v4-6-48760534fef5@linutronix.de> <20250711123215-12326d5f-928c-40cd-8553-478859d9ed18@linutronix.de> <20250711154423.GW1880847@ZenIV> <20250714073704-ad146959-da12-4451-be01-819aba61c917@linutronix.de> <20250716072228-2dc39361-80b4-4603-8c20-4670a41e06ec@linutronix.de> <20250716101207-c4201cef-abbe-481d-bca5-c2b27f324506@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250716101207-c4201cef-abbe-481d-bca5-c2b27f324506@linutronix.de> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: A02AA4000E X-Stat-Signature: j45ayeyrfggcqgtf5dphm8azd1ee86hn X-Rspam-User: X-HE-Tag: 1752664268-339860 X-HE-Meta: U2FsdGVkX1/sITB4DEELyqM4ix1CqNr2pSwGa3wOQHLAz9Xas4hZUhBBxc2V10V0Oeil/nWJheYuBtTcZK6+jCloXU+EscYlddmStTVMftoI+sPimjX5p1MVJWLDITmJ+4gdiOJALxk1uGMAO+ismlPLgxiLZILTRMWkHfnuQP6GEmIRfUlQwXZyLUNbGZz15gp16GPnEWD4hdiJ1aWDsWRCMK8DqEe5GwOvnwqAY2b2kNMM60N4qjBzMiDTJNTGuAw6/UtRgO9e9huVL0WdUsEhVERg7gcp/0oOTNX7ACvzs+VVOr/uAHNdAPXNPvDgVhgG83nQj3vreChHKg2mQpv8Bemk94I3Jz2Yq4wBk/BLrW7fs0jA667m+hGJ/CqUEtPt6mL9vXDvS0T0a2Ied377NqnwE+AW6+j1RdKmPSE6JkFLjJmouobdu2E0RkCSd9ijYLwyFuvzdLeilnWBxHi5E6MhBwwgDVTSjpLymHba4MCgt29nZ7oA/ojawpErhDRFbmiF9LouqJQ4WSTsrGXTZhSC8ui0NqI2Z1VskYvSqhW6Q0uDuur6k5NU3u9L5IIwxr2a+N0E3CZFXNoXsr61oOeQV53CCwR1RHzs2USYwsMKphayYoI9ch48Ec04pr01yKI/+4N8ULEWjWQeWauEPZbLbVSuSXs7bSJX29WPgr/P9jPWNqu+Fg6tzRV9BnI+7VSTWM1QLxVWWChxdjhfjW6x+MNxQ3VqShCmOvW05mJD1aqr7SavWXwWwHHc7pGV9R1EmPufrXagOdYy7Wd7FgnlYHkNTRIiogwKFysh0n7A2G71xXM7Y9KZPTqNtqkG1H10648UzNPeOifexFuHCy4kYWdkrPz82VqMj4jco6g6gaAWT0av5rGyS8lsasPIQ3qU7xxXA+vKegX5lLiL9nVQeCG/4iLEa3ynJAZDXgGw1inpd22onLsUPx3z7E+d5Ent73mDA3TDb3e 7t6HqXWq 6YV6Hk3jH3dOaDRWvIlx0s1K3yqYM36g+cbhmNmKenWzfp7/fLVXPF3+d77kPq8MvmlX+DcfqyUwE5/DYtCOocHhA2+2jGPpvaW+TyQRo0afEM0B3qi4nQZM8OjFes93szQ519iUt7ceF5vROOTiIMJNbzfhikbqzNQSrHq5bKgRckrgVu7i5c7sdbU+QGfhWZiq1QeLKcPz4Y5tuIGtIaFdTjZYYQpZi2Odm8RRRxcT9DD5aV9Myyt7ivhgEOdmYotxoXu4au9ddcu1x6s33zixG18gtLbTm3TZY2LDYffN5otFR7MoWka4gLLNa2/vpnie3gznIRSkm5/WE7n1EiVm2t4VZgN25Eh0/GTmn8KSA1U9rePD5X+g2jZq5jR2KPslMohC3ozRIhqEfSiBXrqcy3KbBOhS99Spb8khWojJjYGGSQPPvSfEHMl8vFp9M7oZSYYkHsmRffIedrw5b92l7Nl671waTKYXk/GdAsTkZXcc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 16, 2025 at 10:39:57AM +0200, Thomas Weißschuh wrote: > Let's take kernel_execve() as example, there is no way around using this > function in one way or another. It only has two existing callers. > init/main.c: It is completely unsuitable for this usecase. > kernel/umh.c: It is also what Al suggested and I am all for it. > Unfortunately it is missing features. Citation from my response to Al: But why does the code that calls it need to be modular? I get why the actual test cases should be modular, but the core test runner is small and needs a lot of kernel internals. Just require it to be built-in and all this mess goes away. That being said some of this stuff, like get_fs_type / put_filesystem or replace_fd seem like the wrong level of abstractions for something running tests anyway.