From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BDE0C83F1B for ; Wed, 16 Jul 2025 11:36:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1E5618D0002; Wed, 16 Jul 2025 07:36:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1BD688D0001; Wed, 16 Jul 2025 07:36:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D3338D0002; Wed, 16 Jul 2025 07:36:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E857F8D0001 for ; Wed, 16 Jul 2025 07:36:42 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 944D7B7EE1 for ; Wed, 16 Jul 2025 11:36:42 +0000 (UTC) X-FDA: 83669925444.23.E02B7A3 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf10.hostedemail.com (Postfix) with ESMTP id C6986C0006 for ; Wed, 16 Jul 2025 11:36:40 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=i3gFkJTJ ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752665801; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IfRmjwGtRP6oQ8KDbKEpggcGnwljF/EmhtdDL5jBVQw=; b=4/TBPJsJiWWGoxErlGueisZxsa4D6f57rOnOfyCa0/XJI/T6GhWWlIuVhliB9uAIkm0nBO XWSh+No+YkDdoxY7SzfplUjAUBZEI+iaTj7SeF/qA6I7iJsDLi3Low8nmMgOoflHxftOPl rb8IndHAXV5xAiqkECJ6dtWl1aGRgLA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752665801; a=rsa-sha256; cv=none; b=7IxZ3fmj9zSvykP3hg9uG1koFO88YgedZezdNYQ8WzHoCgMstS0w+j+zVcREkukWjA7F4G 1U/4mUv5HiGapEJPhq25veQ+AflJixNofbH8fSZJgklAWvLLn8F0RXX8slhiU7ZGufKDAI IBX8XYUzh/ZY8em4ylZNZ/A6XQjj1gE= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=i3gFkJTJ; spf=none (imf10.hostedemail.com: domain of BATV+d54f9d66dc200d3a0946+7997+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+d54f9d66dc200d3a0946+7997+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=IfRmjwGtRP6oQ8KDbKEpggcGnwljF/EmhtdDL5jBVQw=; b=i3gFkJTJfYS1ekfShQMpLaepU5 FnpJmCYB9e0gHP1WTbAtXyzG8pvxx2occdnfdtORm2PM2Ajgux/FnN86FElBG3qwyLi1q/tsSqQX9 ZE/GHfam/po8RharCeTb56QYK8RHqgcpzG21HIR0Mk2fxdn9SqYUqCitQbI4oIezl2CtbooMZEYMU QhdYFq5DW9gdNaEWvQ/d8D7WhGy06ABQTdmeg/khiSCfdVEykbj+ZN4W2/hguH9iLkyXvFxnAdPRG odbAulxDKrID1PCemT7MDINWHv+dBNuV6pELRiZL29huOHbnaXW3xHJaG7PxvrGljUUjyLaOcb9di UXEHqDdQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uc0RC-00000007ZgG-1yzg; Wed, 16 Jul 2025 11:36:38 +0000 Date: Wed, 16 Jul 2025 04:36:38 -0700 From: Christoph Hellwig To: Thomas =?iso-8859-1?Q?Wei=DFschuh?= Cc: Christoph Hellwig , Al Viro , Luis Chamberlain , Kees Cook , Christian Brauner , Jan Kara , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 06/15] fs,fork,exit: export symbols necessary for KUnit UAPI support Message-ID: References: <20250626-kunit-kselftests-v4-0-48760534fef5@linutronix.de> <20250626-kunit-kselftests-v4-6-48760534fef5@linutronix.de> <20250711123215-12326d5f-928c-40cd-8553-478859d9ed18@linutronix.de> <20250711154423.GW1880847@ZenIV> <20250714073704-ad146959-da12-4451-be01-819aba61c917@linutronix.de> <20250716072228-2dc39361-80b4-4603-8c20-4670a41e06ec@linutronix.de> <20250716101207-c4201cef-abbe-481d-bca5-c2b27f324506@linutronix.de> <20250716132337-ee01c8f1-0942-4d45-a906-67d4884a765e@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250716132337-ee01c8f1-0942-4d45-a906-67d4884a765e@linutronix.de> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: C6986C0006 X-Rspam-User: X-Rspamd-Server: rspam09 X-Stat-Signature: oyinknjaed6tjxxwn8geq8xtgpmcpwji X-HE-Tag: 1752665800-722011 X-HE-Meta: U2FsdGVkX1+OMZjRyxxwjhb5cCRKbq7JSSiDUUad8PZFgwRvm+TFgVDph1+h3yDEHUtomiR/mVRPWdjNDVnMd5lPeLlZx8JjOlfWLmiYiE+4HmnhrSRhW1FbzROlivNcB0T2tyuwuCIvnVEhnH/yYJkxN+8bM1VfN4709S/EOdjbexzhZxLkLdVTNufgMeYmU7t3YX4yPaIPTHCxHYccJgUUEBMP2t6I+N12Uf6EFkGtFGLn+dfGrl/5a71WdBDbbp2WwtD32qsq2RCUf6z0DRffDUb7Ydxk5lN+IdfKoikx7HNeKZkxoGe5/lSLCaK1oPlptdqSyrt6oQ/mQAtSvbEhO8rOl9zQjeYI+HvYWcyqJH7xr8MmIFH4g3OAXDhcJrP526ZCe7ffehlBgojyS8xaXoo3kNvMSmG/Uo7zONq+nI8e35I2npNmmVOpHfukRxssSW4+9xwK4X+CQxliBCBVT9QFXqMYxP2xfEy469B4bItyntH3hjir2bjzNxeZlru2dyuMSMr76r5XHrPMUPkIUVYCKD5bhuhRan7UUQANtadl8DUvhdSRPvFLtSkljmngV8bcFk+0uDvKFnDjQAzZWjQznOWNU66YHSoATFCsAO9n+t9ZeHceWNISz9oawHNNoFP2EYZ3dXTSjcCqfjyCOcn8i+ZcYqkri/9jDndfTQ5NuCqs4oe4XR+LXzjZxuGIDeBnDsGZMoLq++RIZ6qzRhsmSYil4WqrFf8ef3ur3uxBwS1hI2XzuGHinvjfl2D/7QxpuJUA0YFWgaOadLpPlnkyL9ix5bvEsj7JipnCjEIg4ckXhZqA/iZABvIwl9d776HczPZFyPY6MdWiKi4XrgeXhwNxCBhLSe6eIDTFFGQNYKi/FhLxuU6XNymTH8aAO14FyWHC4TANWFrN3oCpNZ4+i9DbN/CotYvtQnJneclm/RpybAiDBY5MCf3kaa6EH6JYh+AEqe3c3FM 4gUpa/BM t7Q26XAFwySeeVsSBBgRcadVWOdw803tTt9ILIbkKe9TrWkrvkL7CAUfmX4f2ArzmV2g6api6vJjnJJx9FcIRMiQh6uEddDHVIhSZpWfp1owC+z5EqeBGJ3nXC8FS1DHjUyrsyXGGf2AL+OMn89SlGZKK+msZdCYcPETx41AhgZRSuBM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 16, 2025 at 01:33:05PM +0200, Thomas Weißschuh wrote: > On Wed, Jul 16, 2025 at 04:11:04AM -0700, Christoph Hellwig wrote: > > On Wed, Jul 16, 2025 at 10:39:57AM +0200, Thomas Weißschuh wrote: > > > Let's take kernel_execve() as example, there is no way around using this > > > function in one way or another. It only has two existing callers. > > > init/main.c: It is completely unsuitable for this usecase. > > > kernel/umh.c: It is also what Al suggested and I am all for it. > > > Unfortunately it is missing features. Citation from my response to Al: > > > > But why does the code that calls it need to be modular? I get why > > the actual test cases should be modular, but the core test runner is > > small and needs a lot of kernel internals. Just require it to be > > built-in and all this mess goes away. > > KUnit UAPI calls into KUnit proper which itself is modular. > As such it needs to be modular, too. Not if you depend on KUNIT=y. > > That being said some of this stuff, like get_fs_type / put_filesystem > > or replace_fd seem like the wrong level of abstractions for something > > running tests anyway. > > This was modelled after usermode helper and usermode driver. > To me it makes sense, and I don't see an obvious way to get rid of these. > > Or do you mean to introduce a new in-core helper to abstract this away? > Then everybody would need to pay the cost for this helper even if it is only > used from some modular code. I have no idea what you are doing as you only Cc'ed the exports patch but not the actual work to the mailing lists, so I have no way of helping you with the actual code. I can just tell you my gut feeling based on the symbols, and they are something that doesn't feel outside of very core code.