From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83DF7C83F1A for ; Thu, 17 Jul 2025 10:30:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E8B966B0093; Thu, 17 Jul 2025 06:30:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E631E6B0095; Thu, 17 Jul 2025 06:30:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA0556B0096; Thu, 17 Jul 2025 06:30:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id CC9D06B0093 for ; Thu, 17 Jul 2025 06:30:15 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B58AE806C3 for ; Thu, 17 Jul 2025 10:30:08 +0000 (UTC) X-FDA: 83673386496.02.B2D4B46 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf08.hostedemail.com (Postfix) with ESMTP id B3CB616000D for ; Thu, 17 Jul 2025 10:30:06 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=DAXyXFrd; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf08.hostedemail.com: domain of rppt@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752748206; a=rsa-sha256; cv=none; b=g8o6gNnvcjw1izMFemd9Tn83mvKpSeUGQdHTvfjqLKv80WmG+rAtpGJ22RM5KBPXGzZJ+g z7Mx/4HRpebSAPYROXqk5clHl713k70A4FU4xB58VvU9/x8cAxinH8F7R27DJQ7pBdEjAK S76E8a1sVqMwPmtpAxZNiBXgG5UsZio= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=DAXyXFrd; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf08.hostedemail.com: domain of rppt@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752748206; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+YgPqrokAaoa1tcilQXmRQVMILywVTBcRy9d56xqNP4=; b=OuHkOBW/XfsSK6g41o9CoiRMHBDAMQWbSRILcnNR7kfQNn2J55bpfiNu78QgOvIuR17PoM i1BO/yTz0qRsTjoG8VvNx5aHTtx3PlpW2ZaDq5z5YlTfq0PSpudVR30q5+4kYIkdRavYZ+ 8bed2h/cFz5SwhCbmUHmMWr/gs2k1rQ= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 6F3D946F43; Thu, 17 Jul 2025 10:30:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 66C95C4CEF0; Thu, 17 Jul 2025 10:30:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1752748205; bh=3/PF8dpMl5C8SP09gYB2TIgP3XqaOEcppN5FDF8vZdo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DAXyXFrdBEECSYvOEYdTsKDb5PaFQQvLIZLOb8Xsk0jhzywbA2YtGNws0RhCsOzUV mdm7uW1l8pLLBPFv1rvTJ76fHQBno0bY5xkStGFJ8aeH6XtLBFDg1xbBxAmhFiJXmE b0ndyn9E4c/zXPM4f2heljIKQGe6NLrdcVx8L8Yaf9LbGsYqPBvIpu488gIB5gQWCm WrIzYAlYUe0qVKXaBPKiLd6c+GF0YLvRxBIAH5HdMoT9i1AWBQPjqQdGE8rr1sWeJs IRombsIGGJxugI0Bu9opQSIpEXFE0oRn4lahKYZkmthYjIO08ylzgsvv1aSoY9GGaU DQnji4mQn7rLg== Date: Thu, 17 Jul 2025 13:29:59 +0300 From: Mike Rapoport To: Wupeng Ma Cc: akpm@linux-foundation.org, ardb@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: ignore nomap memory during mirror init Message-ID: References: <20250717085723.1875462-1-mawupeng1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250717085723.1875462-1-mawupeng1@huawei.com> X-Stat-Signature: sasstpfypicfaqse4tzc5zuwn5eucojx X-Rspam-User: X-Rspamd-Queue-Id: B3CB616000D X-Rspamd-Server: rspam02 X-HE-Tag: 1752748206-803364 X-HE-Meta: U2FsdGVkX19Qw8ORPI3Gqb5OVzQkquqrsecP7keCqaoCpC86WE3q/+KXpNt1tjGUyKR7+mE/gff/aB9uJrQ+B0juo9uGdibO2rWCkQAOMryJK3mIJRbwwfzDYCp3NQfjkHXUPuH8fYCHmW72YxapzPaIbv4iserPM2QMVSx8BNII7LG2dee6octCD3GMy6UvldiNtuj2LmgEb5g64sW+FVBJu0CeSgO2dLOETBt/JnrxvGZcF90MVVl1xpXjMAs15ffJrwhhEGKXApD3n3veKKgqDpBQNfKjiWKN0hvRL+KokdHEoYGCdH2/upIcj0J41lUm7F5Z3P72cHZI48a4JLvxaAegjvzj7lzYaMisg6OE6WI8OSehn/PlEAC/CrFV+rzytM4FeAXEKjE+wsiTkngVAB10qCR7RHZxY68Q4ueCNqk+29b3l1ZuqnIxeTVdOzd92CvB/s2L0icd1coHjYkrwVV3w9hPBscgQ9RN7N7KJBXJy77M706nuiaXKS2+Ssi2/1j8Xhkz42SUFpvdYkTgbF+alFk+j59LLIxReiE5KRHLP3S0lespIAhfibmVhIu3Z1DwsB1zFoL2jxhK5y9dF6iMr/UzO+gZ6xCmo3aMQk0miQn78BjbmEn02IMlfPZNJsiA9vJKl9GlLsL2R+BzpxB4B5MxcC8guKHjCONVWO25V/gaAOrAz4SNTTlj5wnSQ7YrOsExLRMrN8nZXFfhs3QqjhNEGQiD4DxpMTVl0IzBSPw9vNbyPt3Ryu+mm2c+H5+klgbXMC56+y/Udhs6NAnr1zmh3TJyjbIwwQK6uvj8R9f2ceCPPZywPSYZeJ+42he7dt+CPV9RwGC22fyARQOU9k0CZ3ncJz/985H1n/lGvc4zfs/Cdi0MrXCZCLJUPOONVWZ09PnnbAUDMvWNyYW13t+x3JAJ89aUsjjPNugJTty/q39D3YCS7m+jJZ9QK4EiYji1WnnTupP x5zn/iW0 HzlBrkpKKJXIgmKoQdPulnmA6fDcqBU5VjUNea3PsVYk1zOf8UsfaM5Vf5BrtGaTAag2e+Aj56GtMo7DJGToYP57fbeKYQfBZC70+7FF5dBvzRsBnTmcpa2pQoWu8+3dTqDQSH/kG6XimVLevn1HhFW49SamS3sR7h8vc6XW46qjv/tdYK3Kv4xWcKM0WUMzlnSmNh1RtjQAYfVoBJf+/a7B5SbVPuN+revsZwh/K3fBrjTw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jul 17, 2025 at 04:57:23PM +0800, Wupeng Ma wrote: > When memory mirroring is enabled, the BIOS may reserve memory regions > at the start of the physical address space without the MR flag. This will > lead to zone_movable_pfn to be updated to the start of these reserved > regions, resulting in subsequent mirrored memory being ignored. > > Here is the log with efi=debug enabled: > efi: 0x084004000000-0x0842bf37ffff [Conventional| | |MR|...|WB|WT|WC| ] > efi: 0x0842bf380000-0x0842c21effff [Loader Code | | |MR|...|WB|WT|WC| ] > efi: 0x0842c21f0000-0x0847ffffffff [Conventional| | |MR|...|WB|WT|WC| ] > efi: 0x085000000000-0x085fffffffff [Conventional| | | |...|WB|WT|WC| ] > ... > efi: 0x084000000000-0x084003ffffff [Reserved | | | |...|WB|WT|WC| ] > > Since this kind of memory can not be used by kernel. ignore nomap memory to fix > this issue. If the memory is nomap it won't be used by the kernel anyway. What's the actual issue you are trying to fix? > Signed-off-by: Wupeng Ma > --- > mm/mm_init.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/mm_init.c b/mm/mm_init.c > index f2944748f526..1c36518f0fe4 100644 > --- a/mm/mm_init.c > +++ b/mm/mm_init.c > @@ -405,7 +405,7 @@ static void __init find_zone_movable_pfns_for_nodes(void) > } > > for_each_mem_region(r) { > - if (memblock_is_mirror(r)) > + if (memblock_is_mirror(r) || memblock_is_nomap(r)) > continue; > > nid = memblock_get_region_node(r); > -- > 2.43.0 > -- Sincerely yours, Mike.