From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68BA5C83F17 for ; Fri, 18 Jul 2025 08:36:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EEEC28D0009; Fri, 18 Jul 2025 04:36:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EC6738D0001; Fri, 18 Jul 2025 04:36:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E03348D0009; Fri, 18 Jul 2025 04:36:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id CE7B18D0001 for ; Fri, 18 Jul 2025 04:36:57 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 42A3E140360 for ; Fri, 18 Jul 2025 08:36:57 +0000 (UTC) X-FDA: 83676730074.22.18C00F0 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf22.hostedemail.com (Postfix) with ESMTP id 9A49FC000B for ; Fri, 18 Jul 2025 08:36:55 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=GmH8kuFD; spf=pass (imf22.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752827815; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=inHdJPS1iKdIaaojY28b0ZRuhQUhLrBV2HxD58xasXg=; b=SYYGVYXSV4MTz4kOT/0mIOgK7XBSs3UMiP1rq3UifspdIrLmWp+HdcTeVA8i/EWY4hzvJb N8TtfNM6HdjXF/91FgnEk9aGUrllvGGXLS1RZiKscT3cmq51wpWGdAR8vAD4l75Ui9mgon LxLxNFEa27piymReByeUQyMDMfxSyYE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752827815; a=rsa-sha256; cv=none; b=YXTdVZFuT4YcILV8sPvlQXZH9gzvJkPOH6OGfVx4L44L6tzUI/46ElIOVBPSxhutzV6Ew7 LYLdavNFjdN9gvjEv1nZp+1LpTCdGUaYTPln75M2Xt1fgLaGaUhTYwwgjbG3jajOiownDv jaFGdFs9lhkX96Yw3Wmv6cLtgyDXbu0= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=GmH8kuFD; spf=pass (imf22.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 373645C5996; Fri, 18 Jul 2025 08:36:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4E585C4CEEB; Fri, 18 Jul 2025 08:36:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1752827813; bh=HL/2nr+vhFKcEcF58riyFRNQttwiCB/9fGbm+q71Dgg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GmH8kuFDP69wLkOjDvdpYL8g4oErm+tCxzSYFjNficaE3yVU2VDi2CVybyh3k2vzL ktrs4o3SmHh9+Ti01m0+zENfWaUVs3rPEOFccIDJ8JzUuMBm7vzDhfYqgJjGzyUfX2 tzprzSBZDHn6R6ZCy1S+ooHnVTZn0aRQWwJVACdL/lb02WuONW5CmJoAQ+l6IEgvXV YUoaFOXIVofvTGsxJhTxgxblsj38dHI42GL2cErPbWSgZ0WyDVaDQIEbTqk0zRmB/4 6UGfFtVoeLA7gIVsJdymOjI/f87nJMUh+D/2j397DUryS3KRRsJ57CDJHeSOO9dNdu VnRo0rjVmoxGg== Date: Fri, 18 Jul 2025 11:36:32 +0300 From: Mike Rapoport To: Kees Cook Cc: Arnd Bergmann , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Paolo Bonzini , Vitaly Kuznetsov , Henrique de Moraes Holschuh , Hans de Goede , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , "Rafael J. Wysocki" , Len Brown , Masami Hiramatsu , Ard Biesheuvel , Michal Wilczynski , Juergen Gross , Andy Shevchenko , "Kirill A. Shutemov" , Roger Pau Monne , David Woodhouse , Usama Arif , "Guilherme G. Piccoli" , Thomas Huth , Brian Gerst , kvm@vger.kernel.org, ibm-acpi-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, linux-acpi@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-efi@vger.kernel.org, linux-mm@kvack.org, Ingo Molnar , "Gustavo A. R. Silva" , Christoph Hellwig , Andrey Konovalov , Andrey Ryabinin , Masahiro Yamada , Nathan Chancellor , Nicolas Schier , Nick Desaulniers , Bill Wendling , Justin Stitt , linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-hardening@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kselftest@vger.kernel.org, sparclinux@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH v3 04/13] x86: Handle KCOV __init vs inline mismatches Message-ID: References: <20250717231756.make.423-kees@kernel.org> <20250717232519.2984886-4-kees@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250717232519.2984886-4-kees@kernel.org> X-Rspamd-Queue-Id: 9A49FC000B X-Stat-Signature: f8sabyugwdt94sck4qq5kj6nab8g1zr8 X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1752827815-501787 X-HE-Meta: U2FsdGVkX1/9CaZpy4A/5Abyl1n4kZV1eizRyZZBGnPeAVPrbOoqz/unT3DmxWtcmzTa7rOceKuCrh2LTPGkzCokqIBEntswdJJZdUr//S/g0DGXl4xeB95A6FWSFxX5+UjpwQYCBlytN3pFaKgztbl/kO//26Q+7UJjMl8CA9VGAR7JeA7SK8GB86IiI4YOppi6VEgwiJTvrD9LEbE1iJ/kiQ6dfuez0RiMe5TD3D5C/IvXWwTrEbNjrtq0LjUmuTVPHBGhXQ1zpEstqfgzVczqWTDZrOSX4CWe55hNPSlfLDN9qI2oPDHI0y62+kYun0pRidnoK1IEz5FZ1GpN3Qd36PedHWg5Jd9eHIWBnEyZw4qCHHhQL0NVz/7V6Pov39/Bl3ophtJxqoqHbccn+8XbfhnrdS12G4hCjUWZK12+70scU/vgEO1XFxeicj9laY3naUDK6vDcN6K4SMNdLTPQ8GTekriWFwRFnw0nPB+y5CVoRPQ0R9Gn9g+aefB/hSqKV5yNQHtayEtefFTlCdWosufgmKFYr+GIzMg3md3sBE1HSAs28bYEzH5Wj9SAgJaSMY3fDucAqn3z/m7SSmV58xlb9s6f1IdnWBZtNbUFSTFYBPnYX5cf+rjePBQjQeqFoxc7f2gDveZ4zusT2xeDvn1wk0H5cf+PYc49dEYDuKmKqwaOvwv3LxZhuGOfjNUe4ZrQT0Tb5iMcBYHZXZo1bIm9gsKfXSDF+p7cqsdgTq9C08YAqwyVVhBe8EI9l0+bPfOmIhZC9APFcYc0OzjhjlTFj6WJg47KKvkPt5jIzQV1vzXNzFs3YQNLd2xFBjmomwJR1OEOq2BWx4rvpDDIZjv+O741lT/2k0ro/zmBYSr6LineQzzgM2ULjqMCPnM/Mk3AHcVRk+AKa46BLhG36h3kM3GLJR0YiBxPj/mL0E7Rg2UrOiQcs84YeYMckyIrXJkjAgrhZaTLZ71 2VCRf33G pZWdf/g6MlCBA/uX70TdMHf+H63X0f3M/hRgnf1xlOeZygtHRnCA0yXvARkiioGTpT6rJfgnjS/6V8mqJ4i4b7i2oZXjl5MiUC4P1fwhDaLKFoZqVMGzhiRbnlJii3DkZw31DWokgXJetADXfOKfSqQ9VK2bV/0A7Y3HQKDReB6Kl28E1EErlNdtuS45AoQSNiMOfw2L4fFn99AdLg01RDpk+VNwIlXQahqq69vD1m90n5k6MziKQch4QrstsXcI+ykpip7Tc5Ma4Az3sTdeAq6osySCfhVVOu8kpvN4vN79MfSeEmX/u3aPqqZgaO2676gUnXj4iJHquCsDD63hjKQnXRsic27BP3aTspY8qthddypzGKAd+g5m+vCSsq0PgLM44R4Bz5OQ59F6jpo0uEIK0RjjWPHvVUY5LH0HYCSBDVVn7FPIf5Z0d+A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Kees, On Thu, Jul 17, 2025 at 04:25:09PM -0700, Kees Cook wrote: > When KCOV is enabled all functions get instrumented, unless the > __no_sanitize_coverage attribute is used. To prepare for > __no_sanitize_coverage being applied to __init functions, we have to > handle differences in how GCC's inline optimizations get resolved. For > x86 this means forcing several functions to be inline with > __always_inline. > > Signed-off-by: Kees Cook ... > diff --git a/include/linux/memblock.h b/include/linux/memblock.h > index bb19a2534224..b96746376e17 100644 > --- a/include/linux/memblock.h > +++ b/include/linux/memblock.h > @@ -463,7 +463,7 @@ static inline void *memblock_alloc_raw(phys_addr_t size, > NUMA_NO_NODE); > } > > -static inline void *memblock_alloc_from(phys_addr_t size, > +static __always_inline void *memblock_alloc_from(phys_addr_t size, > phys_addr_t align, > phys_addr_t min_addr) I'm curious why from all memblock_alloc* wrappers this is the only one that needs to be __always_inline? -- Sincerely yours, Mike.