From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31678C83F17 for ; Fri, 18 Jul 2025 14:31:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B225C6B00A0; Fri, 18 Jul 2025 10:31:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AFA1D6B00A1; Fri, 18 Jul 2025 10:31:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A36E66B00A3; Fri, 18 Jul 2025 10:31:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9298E6B00A0 for ; Fri, 18 Jul 2025 10:31:28 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 067B0160494 for ; Fri, 18 Jul 2025 14:31:28 +0000 (UTC) X-FDA: 83677623456.08.5CD2CFD Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf15.hostedemail.com (Postfix) with ESMTP id 4FE30A0004 for ; Fri, 18 Jul 2025 14:31:26 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=T0NopGKZ ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752849086; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=C+f6G0qeYvMfJLWbZqqOXaohYNJJGWVSAxUjQiRP0Ww=; b=WzZMjArcQLFw0Yez6df3fwIxfhUW/ojxPmL+sO9qVy+UtREGloYrYsWdcQjjpLKTu2dSD5 uFIFMlerfON41nZYFF9TzveDMQIWZeT6ZRuoxXKdoWiVxOXyxldQPQbzPQxP6qf/BmegxA kt06+oIueHggSMXUOZeoi+dEyFFGzA0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752849086; a=rsa-sha256; cv=none; b=DD3xhUCp0urKW0GQxtACjEaBkeBuxDjXTnBezecsByMfztnpP6p3K2vN4p3Yii8uGe13J0 Gz1t1KgFONNSXFeOWFkYEx76FVJJHz9ef/5ioK1JFA+17VwppVllIuEWpHthbqoBy6x9/d 8P35qP5MX0mbztnHaRqQCQw0JnGhjxQ= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=T0NopGKZ; spf=none (imf15.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=C+f6G0qeYvMfJLWbZqqOXaohYNJJGWVSAxUjQiRP0Ww=; b=T0NopGKZxNKGsmECuQx4IU6ls7 XuthZDW74dFvGFpmyddPDjlZIAykk7gtcPt1CqEYolD8ykFk++CGrbGW7Mq5Z6WTSco0kcdorWiU7 w0LWGprpfX32ItyuQPt00pKTv7G64RSMaPfH+UrAYF+1X05XFkCbo8HXSoPyx2SRgK/zcfibgugFe jLIhhTcjfLe1l6jV8NPjchQd94XuCsdEGkp01KfHhrC0Wz5j/bt4wWHSobNWM0orCgGDXal8IQdFR ycaknrRUEXrgzIz1xdBfYjWlNB/kbxXHfOKrVDAMZXdW4wqiXmNC6sLyB0D6Qz14BkVgGOXH6Frlo mmHRRs/g==; Received: from willy by casper.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1ucm6n-00000007P32-1dth; Fri, 18 Jul 2025 14:30:45 +0000 Date: Fri, 18 Jul 2025 15:30:45 +0100 From: Matthew Wilcox To: Lorenzo Stoakes Cc: Ye Liu , Andrew Morton , David Hildenbrand , Davidlohr Bueso , "Paul E. McKenney" , Josh Triplett , Frederic Weisbecker , Neeraj Upadhyay , Joel Fernandes , Boqun Feng , Uladzislau Rezki , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Ye Liu , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , Zqiang , Dietmar Eggemann , Ben Segall , Mel Gorman , Valentin Schneider , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Kemeng Shi , Kairui Song , Nhat Pham , Baoquan He , Chris Li , linux-mm@kvack.org, linux-kernel@vger.kernel.org, rcu@vger.kernel.org Subject: Re: [PATCH] mm: Replace (20 - PAGE_SHIFT) with common macros for pages<->MB conversion Message-ID: References: <20250718024134.1304745-1-ye.liu@linux.dev> <416948e5-6308-4d57-8a05-d611522f5f2e@lucifer.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <416948e5-6308-4d57-8a05-d611522f5f2e@lucifer.local> X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 4FE30A0004 X-Stat-Signature: 6kxz9aofeqtizfyf5wwt35cuxwjffbb3 X-Rspam-User: X-HE-Tag: 1752849086-398751 X-HE-Meta: U2FsdGVkX1+jnf0pM++bDRu3EKxMzn18vWCI5xkjuoJ3kfdxmivPw+DdwNfKVxe2uIGjeXrYTXlHiYpIryDnCEb1txXA5GJxXOFSTAvbIQokPzmTDxGs3wrbaZN9yHKGmILtIauBnU2YFDWX+B9F9hJFDIlS+HQzLAlDH90Ist6Qy92faRKXo2tOLvDhLJQsH/a6k7EyFEiX2tgv89jo3+iZahVzoHo325uZsdHdUz4QVLnAEGB8LLB+AidehuOhP8WwTEbB+fzVzTzqrlQwY/oJXzVJUqhLpKQZ1i7kWm2tikVcAq33peo+srMDvuresEQUlBYzC/Sz17RAou19+p4ZivGBqYcCuOt/lkLbp/sLKj20cAX+1N30jztv/3ddf2GbZppHpBPtaSWnezTk1GsTy+U1UIc7xhzOfIeLyOXjwThL80sLzA906PQrv0n48z+Cq0gdSSIWNZDdGqwG8do+XxtT//6QKyIOTP+nOVS+dS9RLXzhOG7esv3VCI4FOxR8rTkBAjAppUKb+19JTU2qzV+zPWpuHsQLiJ0+gQplRU+RllUwEOif4EEouKlILjNPAp9ijQ0bpWwCmXkEnieEw3hdLED6Jq6KsWlwYjQ70dsDPY9AQruQlS9XiZFWVhHprg4vX5O+RwfyDyOLclFVhU1kb/fUDyGIY50MaAaIQrhi1Jr5xU35+zpDzquLG1STt+GY5mpKI1xVrEKkPe+BHXHC3W7naevJZF/xu5FRbkYfIuN5onOGwbe/pgMnSvyeNjzmCaHqzAZDQhfi6YGLQTXWOqH4BOGeA/i9BY/WQyvdUWRnsUaWtX2SRT1RvR2xkVlUNQbrodrz05Elst+9F0jn1lZPzsyCBA/fzbmrfnnMKdXGO5NVLzDkoRBNgecPCwHAK5hRLefGtakSZEzosrLZYOYFLx23jMpPovL2w1IFn861uPCCg9ZGnWWJxiDjs6erSojoQEIAvqA dDTqJL2i YRFHaUuMizKd5bhtuC27KItXsMv7a6nPicbbHDvym5ouY1m0RtNC0uM+4aqXipk5HZh4lSWnqlXvw1gZXchhGWXqDsBXg9KYqtu/Kjem29KhbJU5BLNWYEuPrXZVP0l7tBKfyVp//LMmVmDoCT6GZgZgoXnkK/SP18E4gxUJCANEOs4XJj4qKGLVgPSjC/8t9h0u6jJWZR1/3Xvc5GUD8VTznGZnfg6HQloTzmzKe0zz1W66KeQ7pOp4KjEiBBTSv50unbD4PGc8JIZLrgS0eJaxcn5b7j8seHA12TCnIuUzD4hI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jul 18, 2025 at 10:57:36AM +0100, Lorenzo Stoakes wrote: > NOte I see arch/x86/include/asm/pgtable.h has a pages_to_mb() static inline > declaration, but probably being an asm include can't ref mm.h so meh not a big > deal. Should probably go to linux/sizes.h, except that it uses PAGE_SIZE which isn't available there. But asm-generic/getorder.h might be a good place for it. (hm, is including getorder.h safe by itself? looks like it relies on something else to bring in the definition of PAGE_SHIFT)