From: Matthew Wilcox <willy@infradead.org>
To: liqiong <liqiong@nfschina.com>
Cc: Harry Yoo <harry.yoo@oracle.com>,
Vlastimil Babka <vbabka@suse.cz>,
Christoph Lameter <cl@gentwo.org>,
David Rientjes <rientjes@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v2] mm: slub: avoid deref of free pointer in sanity checks if object is invalid
Date: Mon, 28 Jul 2025 04:29:22 +0100 [thread overview]
Message-ID: <aIbuks-8-FOckIjo@casper.infradead.org> (raw)
In-Reply-To: <e6f14d8a-5d32-473e-ba2d-1064ab8ef8fe@nfschina.com>
On Mon, Jul 28, 2025 at 10:06:42AM +0800, liqiong wrote:
> >> In this case it's an object pointer, not a freelist pointer.
> >> Or am I misunderstanding something?
> > Actually, in alloc_debug_processing() the pointer came from slab->freelist,
> > so I think saying either "invalid freelist pointer" or
> > "invalid object pointer" make sense...
>
> free_consistency_checks() has
> 'slab_err(s, slab, "Invalid object pointer 0x%p", object);'
> Maybe it is better, alloc_consisency_checks() has the same message.
No. Think about it.
next prev parent reply other threads:[~2025-07-28 3:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250725064919.1785537-1-liqiong@nfschina.com>
2025-07-25 16:47 ` [PATCH v2] mm: slub: avoid deref of free pointer in sanity checks if object is invalid Vlastimil Babka
2025-07-25 17:10 ` Matthew Wilcox
2025-07-25 19:22 ` Matthew Wilcox
2025-07-25 22:49 ` Harry Yoo
2025-07-25 19:55 ` Harry Yoo
2025-07-25 23:00 ` Harry Yoo
[not found] ` <e6f14d8a-5d32-473e-ba2d-1064ab8ef8fe@nfschina.com>
2025-07-28 3:29 ` Matthew Wilcox [this message]
2025-07-28 5:24 ` Harry Yoo
[not found] ` <ab080493-10cd-4f3b-8dd3-c67b4955a737@nfschina.com>
2025-07-28 13:38 ` Harry Yoo
2025-07-28 8:52 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aIbuks-8-FOckIjo@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=cl@gentwo.org \
--cc=harry.yoo@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liqiong@nfschina.com \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=stable@vger.kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).