From: Matthew Wilcox <willy@infradead.org>
To: "Vishal Moola (Oracle)" <vishal.moola@gmail.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Justin Sanders <justin@coraid.com>, Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org
Subject: Re: [PATCH 2/7] aoe: Stop calling page_address() in free_page()
Date: Tue, 26 Aug 2025 20:41:03 +0100 [thread overview]
Message-ID: <aK4NzxmGZjKvsGz8@casper.infradead.org> (raw)
In-Reply-To: <20250826193258.902608-3-vishal.moola@gmail.com>
On Tue, Aug 26, 2025 at 12:32:53PM -0700, Vishal Moola (Oracle) wrote:
> free_page() should be used when we only have a virtual address. We
> should call __free_page() directly on our page instead.
>
> Signed-off-by: Vishal Moola (Oracle) <vishal.moola@gmail.com>
Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Probably should have run ./scripts/get_maintainer.pl drivers/block/aoe/aoecmd.c
Adding ccs.
> drivers/block/aoe/aoecmd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/block/aoe/aoecmd.c b/drivers/block/aoe/aoecmd.c
> index 6298f8e271e3..a9affb7c264d 100644
> --- a/drivers/block/aoe/aoecmd.c
> +++ b/drivers/block/aoe/aoecmd.c
> @@ -1761,6 +1761,6 @@ aoecmd_exit(void)
> kfree(kts);
> kfree(ktiowq);
>
> - free_page((unsigned long) page_address(empty_page));
> + __free_page(empty_page);
> empty_page = NULL;
> }
> --
> 2.51.0
>
>
next prev parent reply other threads:[~2025-08-26 19:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-26 19:32 [PATCH 0/7] Cleanup free_pages() misuse Vishal Moola (Oracle)
2025-08-26 19:32 ` [PATCH 1/7] mm/page_alloc: Add kernel-docs for free_pages() Vishal Moola (Oracle)
2025-08-26 19:38 ` Matthew Wilcox
2025-08-26 19:32 ` [PATCH 2/7] aoe: Stop calling page_address() in free_page() Vishal Moola (Oracle)
2025-08-26 19:41 ` Matthew Wilcox [this message]
2025-08-26 20:12 ` Vishal Moola (Oracle)
2025-08-26 19:32 ` [PATCH 3/7] x86: Stop calling page_address() in free_pages() Vishal Moola (Oracle)
2025-08-26 19:32 ` [PATCH 4/7] riscv: " Vishal Moola (Oracle)
2025-08-26 19:32 ` [PATCH 5/7] powerpc: " Vishal Moola (Oracle)
2025-08-26 19:32 ` [PATCH 6/7] arm64: " Vishal Moola (Oracle)
2025-08-26 19:32 ` [PATCH 7/7] virtio_balloon: " Vishal Moola (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aK4NzxmGZjKvsGz8@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=justin@coraid.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=vishal.moola@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).