[PATCH 32/33] genirq: Correctly handle preferred kthreads affinity

Frederic Weisbecker
2025-10-13T20:36:08Z

[CHECKME: Do some IRQ threads have strong affinity requirements? In
which case they should use kthread_bind()...]

The affinity of IRQ threads is applied through a direct call to the
scheduler. As a result this affinity may not be carried correctly across
hotplug events, cpuset isolated partitions updates, or against
housekeeping constraints.

For example a simple creation of cpuset isolated partition will
overwrite all IRQ threads affinity to the non isolated cpusets.

To prevent from that, use the appropriate kthread affinity APIs that
takes care of the preferred affinity during these kinds of events.

Signed-off-by: Frederic Weisbecker <frederic@kernel.org>
---
kernel/irq/manage.c | 47 +++++++++++++++++++++++++++------------------
1 file changed, 28 insertions(+), 19 deletions(-)

diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index c94837382037..d96f6675c888 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -176,15 +176,15 @@ bool irq_can_set_affinity_usr(unsigned int irq)
}

/**
- * irq_set_thread_affinity - Notify irq threads to adjust affinity
+ * irq_thread_notify_affinity - Notify irq threads to adjust affinity
* @desc: irq descriptor which has affinity changed
*
* Just set IRQTF_AFFINITY and delegate the affinity setting to the
- * interrupt thread itself. We can not call set_cpus_allowed_ptr() here as
- * we hold desc->lock and this code can be called from hard interrupt
+ * interrupt thread itself. We can not call kthread_affine_preferred_update()
+ * here as we hold desc->lock and this code can be called from hard interrupt
* context.
*/
-static void irq_set_thread_affinity(struct irq_desc *desc)
+static void irq_thread_notify_affinity(struct irq_desc *desc)
{
struct irqaction *action;

@@ -283,7 +283,7 @@ int irq_do_set_affinity(struct irq_data *data, const struct cpumask *mask,
fallthrough;
case IRQ_SET_MASK_OK_NOCOPY:
irq_validate_effective_affinity(data);
- irq_set_thread_affinity(desc);
+ irq_thread_notify_affinity(desc);
ret = 0;
}

@@ -1032,11 +1032,26 @@ static void irq_thread_check_affinity(struct irq_desc *desc, struct irqaction *a
}

if (valid)
- set_cpus_allowed_ptr(current, mask);
+ kthread_affine_preferred_update(current, mask);
free_cpumask_var(mask);
}
+
+static inline void irq_thread_set_affinity(struct task_struct *t,
+ struct irq_desc *desc)
+{
+ const struct cpumask *mask;
+
+ if (cpumask_available(desc->irq_common_data.affinity))
+ mask = irq_data_get_effective_affinity_mask(&desc->irq_data);
+ else
+ mask = cpu_possible_mask;
+
+ kthread_affine_preferred(t, mask);
+}
#else
static inline void irq_thread_check_affinity(struct irq_desc *desc, struct irqaction *action) { }
+static inline void irq_thread_set_affinity(struct task_struct *t,
+ struct irq_desc *desc) { }
#endif

static int irq_wait_for_interrupt(struct irq_desc *desc,
@@ -1384,7 +1399,8 @@ static void irq_nmi_teardown(struct irq_desc *desc)
}

static int
-setup_irq_thread(struct irqaction *new, unsigned int irq, bool secondary)
+setup_irq_thread(struct irqaction *new, struct irq_desc *desc,
+ unsigned int irq, bool secondary)
{
struct task_struct *t;

@@ -1405,16 +1421,9 @@ setup_irq_thread(struct irqaction *new, unsigned int irq, bool secondary)
* references an already freed task_struct.
*/
new->thread = get_task_struct(t);
- /*
- * Tell the thread to set its affinity. This is
- * important for shared interrupt handlers as we do
- * not invoke setup_affinity() for the secondary
- * handlers as everything is already set up. Even for
- * interrupts marked with IRQF_NO_BALANCE this is
- * correct as we want the thread to move to the cpu(s)
- * on which the requesting code placed the interrupt.
- */
- set_bit(IRQTF_AFFINITY, &new->thread_flags);
+
+ irq_thread_set_affinity(t, desc);
+
return 0;
}

@@ -1486,11 +1495,11 @@ __setup_irq(unsigned int irq, struct irq_desc *desc, struct irqaction *new)
* thread.
*/
if (new->thread_fn && !nested) {
- ret = setup_irq_thread(new, irq, false);
+ ret = setup_irq_thread(new, desc, irq, false);
if (ret)
goto out_mput;
if (new->secondary) {
- ret = setup_irq_thread(new->secondary, irq, true);
+ ret = setup_irq_thread(new->secondary, desc, irq, true);
if (ret)
goto out_thread;
}
--
2.51.0