Re: [PATCH v1 04/26] mm: vmscan: refactor move_folios_to_lru()

Steven Rostedt
2025-11-12T15:45:07Z

On Tue, 11 Nov 2025 08:44:14 -0800
Shakeel Butt <shakeel.butt@linux.dev> wrote:

> Harry is talking about mod_node_page_state() on
> !CONFIG_HAVE_CMPXCHG_LOCAL which is disabling irqs.
>
> void mod_node_page_state(struct pglist_data *pgdat, enum node_stat_item item,
> long delta)
> {
> unsigned long flags;
>
> local_irq_save(flags);
> __mod_node_page_state(pgdat, item, delta);
> local_irq_restore(flags);
> }
>
> Is PREEMPT_RT fine with this?

But should be:

void mod_node_page_state(struct pglist_data *pgdat, enum node_stat_item item,
long delta)
{
guard(irqsave)();
__mod_node_page_state(pgdat, item, delta);
}

-- Steve