Re: [PATCH v4 11/19] mm, swap: split locked entry duplicating into a standalone helper

Baoquan He
2025-12-20T04:01:17Z

On 12/20/25 at 01:26am, Kairui Song wrote:
> On Thu, Dec 18, 2025 at 2:37 AM Kairui Song <ryncsn@gmail.com> wrote:
> >
> > On Wed, Dec 17, 2025 at 7:22 PM Baoquan He <bhe@redhat.com> wrote:
> > >
> > > On 12/05/25 at 03:29am, Kairui Song wrote:
> > > > From: Kairui Song <kasong@tencent.com>
> > > >
> > > > No feature change, split the common logic into a stand alone helper to
> > > ~~~~~~~~~~~
> > > standalone, typo?
> > > > be reused later.
> > >
> > > In phase 2, I saw the newly added swap_dup_entries() is only called by
> > > __swap_duplicate(). The 'reused later' means?
> > >
> >
> > Ah you are right, this patch belongs to phase 3 I think, I can drop it
> > for now, it's just a code rearrangement. Thanks!
>
> Hi Baoquan
>
> While working on V5 I noticed we do need this patch, the patch "mm,
> swap: use swap cache as the swap in synchronize layer" needs this
> splitted helper as an intermediate step. That usage will be dropped by
> the end of this series but I think we can live with this splitted out
> helper. The splitted helper and original help will all be gone in
> phase 3, and there is no behavior change at all.

That's fine to me, thanks for telling. I have some minor concers in
other patches, will add in v5.