From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7379C61DB2 for ; Mon, 9 Jun 2025 06:34:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6BE0E6B0089; Mon, 9 Jun 2025 02:34:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 66E766B008C; Mon, 9 Jun 2025 02:34:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 584756B0092; Mon, 9 Jun 2025 02:34:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 37B3E6B0089 for ; Mon, 9 Jun 2025 02:34:31 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A9D1D121227 for ; Mon, 9 Jun 2025 06:34:30 +0000 (UTC) X-FDA: 83534898300.11.D06D2EF Received: from out30-130.freemail.mail.aliyun.com (out30-130.freemail.mail.aliyun.com [115.124.30.130]) by imf09.hostedemail.com (Postfix) with ESMTP id 5FF8014000C for ; Mon, 9 Jun 2025 06:34:27 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=QVYirElk; spf=pass (imf09.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.130 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749450868; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bEbolKbxdXCTdkf5HWqUnpJFb7LwWG+f6HB8rKtQLSw=; b=GL+wu03ypuxm/dZvDefUoRZvbCdwk2+XkrCOlM1BDbttFpN0sAz/SHLubjgt8mHY6KESeI YV7tZVPWePUKxleDetu2WnXXERGmMsoRKJYdzHeV/YHSbL0gqs3F+3wY+N2py6Nztv4FWq O+Q0pbighyFAFDqvex4ShsM21Y2T6Ng= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=QVYirElk; spf=pass (imf09.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.130 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749450868; a=rsa-sha256; cv=none; b=0e4zYjY/y4t/uQAlPv6u55Va/P3p45xKwM+WOVYV5o1JI1VOC/NXVyoTmFIbyGPNAMc1lI T4RIcPlG1rXbJJ/Ug+1ihE1NmzysdJWrJpzyMgQejkgUFmE1yJyoa6eqtHtzNQd5Skouv+ jbdy63DyyF6icxSa7qVmZBLIO2TBWN0= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1749450863; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=bEbolKbxdXCTdkf5HWqUnpJFb7LwWG+f6HB8rKtQLSw=; b=QVYirElk7DdZ9lLGmy6186cfmXAhDQq0v+4xHYkuZcLZ3eoGlNPMM7hVxngZp2/VWwcfswJv141cwbSLUberOv80BG8T6OrJ8MbJCY1KPKUblV9ELlxEg+CTEusbTre3PBlNBF+gl1fh3xNKBs+6z7mpV/cg2AQj5fhJ3QsoZ84= Received: from 30.74.144.144(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0WdLx-iu_1749450862 cluster:ay36) by smtp.aliyun-inc.com; Mon, 09 Jun 2025 14:34:22 +0800 Message-ID: Date: Mon, 9 Jun 2025 14:34:22 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] mm: shmem: disallow hugepages if the system-wide shmem THP sysfs settings are disabled To: Lorenzo Stoakes Cc: akpm@linux-foundation.org, hughd@google.com, david@redhat.com, Liam.Howlett@oracle.com, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, ziy@nvidia.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <39d7617a6142c6091f233357171c5793e0992d36.1749109709.git.baolin.wang@linux.alibaba.com> From: Baolin Wang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 5FF8014000C X-Stat-Signature: tsixbp6at7z8n7epjwhbxu3a8nr33dzn X-Rspam-User: X-HE-Tag: 1749450867-375730 X-HE-Meta: U2FsdGVkX19nANp5lkUO+PLbGimraSWDkpm8B7feg+F7jnBMjGin4wEY/YT8J9UEXjack8FyZynvw/PNaBLxeMdKIrkGaXasiDXRfw/nALajc6Kk+niEcTzOd6+3pkWaPX/mig+dK5aGmtaeNF+NsSJndQl1vJur9okTkHgN8C2uWWWbJOk2LPZQSvLdcS08+ezyVz3oZX319/PuedPMYi/aHXoouTGf4Le6XLTUSmLlMi0SS1lLdgD9C/P4PtdVCy3lIZId5UBOGtFDkvaexgRxGbDPhou4WvouG7bMzz8VpfglubDSaaARme4DCe2It1ylU2+ptrzAdnFji6z5WBeyz/9QX00khDPcVW1Y94QBTPre+IT1qYUSPUINEfFKnKEy5fiYNVrX23ApQhakSiIohz2TFDSs6HD1se998zyLi7Br3dHY3PpZUAosYzFggLlJLeqJtgeL7NDKDHkvTJtjtMKM4c6sC1nNmnS/kKuJsrHWEfVPhqSwY2vKMfFURCGRAn0UoD8Mp/En3n0yCVHPnJmJr56CNjqAvHVvnXHsJWWVEP5fJ0cmOZqLYzCryjY+DAyqFrRVOKNWa8MrAmYwmQqAXi/hxglTg7bgmLYVvqMLJw2UQerrdoJJrKNpbw8a6cNyKnp0FjOyBr75L3/yL/ea6AU+l3Dt78bYjWMl2encN17UYwuWL+fdJtTtKOX5nXmoAqovm3WC1txVAZndq9KdSdVV86H95HNO8+HgzwqVsJ1428pg8V5+1PVLn7dRoz14xVJI7XHtqOZzspuc+s3wwmUqJD/3YMqQib4Xo4HzWBOSnW5X2Ioydl6YNWj9TXhublrvvuHvnKuuV1ip7Ccu5BzJ/zQL4VE007WvMt7iePOZixKSaRsfNEh9Of77FuZgpI3FbFdRLPQgtaBw1lnwpysZR1x4loYhre38gusajYrlRKxWksahrRaLQ//JCn7DYFFDnW4BTpV +J9NxzBt MOb+urGFrtBb5ouQJ1+Z9zVK3VYgxwVHRbLEPzpU4Y4XHXzkK/CtbR+Fvqj1fzjHnx9FPABiC1ArjVAoBe9mQOSp+65i4W5XJIQTg1ne7i66on5b5m+atxFodc1DyxFVi8TW7wJmhjiN0mtY9k9p1CjQQXS+jt3Y9iP5+vLf/3KTJ1GHvLDyQUz8x2cnj1MiMpcUyKiUx0f73GEW9G2fJV2xZEV3WIe0JLGOvAnX/Ym6RhZAghZV5BeEds/tTGaOi6wpX9MB9KcdtvXXm4NeqqWr14FPNOhKQqkv/U8bQhgMQjsXA9dcwB+UEksUNJis6xEGhzEjNE1+iC5i1PApSpQCV48G5+JVO9vTKdCvx8ySSAdiCMScZHOrhFw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/6/7 20:17, Lorenzo Stoakes wrote: > On Sat, Jun 07, 2025 at 01:14:41PM +0100, Lorenzo Stoakes wrote: >> On Thu, Jun 05, 2025 at 04:00:59PM +0800, Baolin Wang wrote: > [snip] >>> >>> Another rule for madvise, referring to David's suggestion: “allowing for collapsing >>> in a VM without VM_HUGEPAGE in the "madvise" mode would be fine". >> >> Hm I'm not sure if this is enforced is it? I may have missed something here >> however. > > Oh right actually I think it is implicitly - if TVA_ENFORCE_SYSFS is not > specified in tva_flags, then we don't bother applying an madvise filter at all > anyway, and we account for that in our 'enabled' check in > thp_vma_allowable_orders(). > > But I don't think this patch changes anything, I actually _think_ we can just > drop this one. See my previous replies. Shmem mTHP sysfs settings are different from Anonymous pages. Thanks for reviewing.