From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0EF6C43334 for ; Mon, 4 Jul 2022 03:57:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 219D68E0001; Sun, 3 Jul 2022 23:57:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1CA2B6B0073; Sun, 3 Jul 2022 23:57:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 091F98E0001; Sun, 3 Jul 2022 23:57:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id EC14C6B0072 for ; Sun, 3 Jul 2022 23:57:36 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B2CDF34FCB for ; Mon, 4 Jul 2022 03:57:36 +0000 (UTC) X-FDA: 79648058112.20.797F61B Received: from mailbox.box.xen0n.name (mail.xen0n.name [115.28.160.31]) by imf01.hostedemail.com (Postfix) with ESMTP id D6DC84002D for ; Mon, 4 Jul 2022 03:57:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xen0n.name; s=mail; t=1656907050; bh=nEFAaimDHQ9+9OzaA/ZB4ZaY0ZaBzpTQo6pKly4wWzE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=wWuMthucJbzktwB/xbORvGK5uNDweBclk0LJ/uzlpsQK+o4fTm4aPZIJnR97asuj4 se5k8kontPi/E0XftB0voNn3GTQzXY3ltXkJ/jG6SnX7/pCZdcQPZQudGzRHp0TKsU VuBFExTLic5XZTBaNkmMj2c6SHB23jyZof9/3I0I= Received: from [100.100.57.190] (unknown [220.248.53.61]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mailbox.box.xen0n.name (Postfix) with ESMTPSA id 32DAA60091; Mon, 4 Jul 2022 11:57:29 +0800 (CST) Message-ID: Date: Mon, 4 Jul 2022 11:57:28 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:104.0) Gecko/20100101 Thunderbird/104.0a1 Subject: Re: [PATCH 12/14] loongarch: drop definition of PGD_ORDER Content-Language: en-US To: Matthew Wilcox , Mike Rapoport Cc: Andrew Morton , Arnd Bergmann , Dinh Nguyen , Guo Ren , Helge Deller , Huacai Chen , "James E.J. Bottomley" , Max Filippov , Mike Rapoport , Thomas Bogendoerfer , WANG Xuerui , linux-arch@vger.kernel.org, linux-csky@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-parisc@vger.kernel.org, linux-xtensa@linux-xtensa.org, loongarch@lists.linux.dev References: <20220703141203.147893-1-rppt@kernel.org> <20220703141203.147893-13-rppt@kernel.org> From: WANG Xuerui In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656907056; a=rsa-sha256; cv=none; b=DWGcVBB9ClQwFm+wDMLv74P+SFwBdJvmOI/G1Wsk928mUkAjU4lhceVn9Nk4qF2ZfKmTDS SpQBPZR9JJnHKwdC9W/XwGqTTlxRYjpJuNxgJVoGMXD1iakwrTcgCncxRbt8w9PTL8BQ2O AR7XySjDRMfE46u8lilVdC348ToAgzA= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=xen0n.name header.s=mail header.b=wWuMthuc; dmarc=none; spf=pass (imf01.hostedemail.com: domain of kernel@xen0n.name designates 115.28.160.31 as permitted sender) smtp.mailfrom=kernel@xen0n.name ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656907056; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=F4dCiqg55zaaC34O6/lNmcOoSsMHk/uXLJQoiiHccsA=; b=6BBI+nEIvauaTTLwaZMSFHiiaCHztfJHdKYe6T7w+h/xWhyttmRcimmab2ee/xfDVTPlFq ibPczYtqPr69KRSj0O2BfWkbEsbaUA8h/QpF2E2GQ4lPocPlItXsDsMl3JVAGVAKYFGjY2 nLaMeiGfnelRCge4ekZ45RNaHveE7Ak= Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=xen0n.name header.s=mail header.b=wWuMthuc; dmarc=none; spf=pass (imf01.hostedemail.com: domain of kernel@xen0n.name designates 115.28.160.31 as permitted sender) smtp.mailfrom=kernel@xen0n.name X-Rspam-User: X-Stat-Signature: o8ajd68j4fo6tw77z8ftdiigoma3rtsc X-Rspamd-Queue-Id: D6DC84002D X-Rspamd-Server: rspam04 X-HE-Tag: 1656907053-131228 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/7/4 04:50, Matthew Wilcox wrote: > On Sun, Jul 03, 2022 at 05:12:01PM +0300, Mike Rapoport wrote: >> +++ b/arch/loongarch/kernel/asm-offsets.c >> @@ -190,7 +190,6 @@ void output_mm_defines(void) >> #endif >> DEFINE(_PTE_T_LOG2, PTE_T_LOG2); >> BLANK(); >> - DEFINE(_PGD_ORDER, PGD_ORDER); >> BLANK(); >> DEFINE(_PMD_SHIFT, PMD_SHIFT); >> DEFINE(_PGDIR_SHIFT, PGDIR_SHIFT); > Should probably also drop one of these BLANK() lines too? > Agreed; IMO the blank lines can and should be removed because the surrounding lines are also mm definitions.