From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CDEB0CA0EFA for ; Mon, 25 Aug 2025 13:58:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0EEFA8E0028; Mon, 25 Aug 2025 09:58:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0C73E8E0001; Mon, 25 Aug 2025 09:58:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EF7928E0028; Mon, 25 Aug 2025 09:58:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D835E8E0001 for ; Mon, 25 Aug 2025 09:58:46 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 01304840EA for ; Mon, 25 Aug 2025 13:58:45 +0000 (UTC) X-FDA: 83815435452.16.2CE3541 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 93E86100011 for ; Mon, 25 Aug 2025 13:58:43 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ELeLPwyW; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1756130323; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lxZho4Y+KRx8y6j3h2szyprS6aHvfITwJX6ZtyYAuvU=; b=VZrySI5ddAxwBS/zxIIU0zp1gNZDTbTEcr3CZbEbkIOJxo2GZ2v4fdFf0MsrRNFKejWgeu Zx3cfOckWpOfaCucHGeqF8RpiCXVezLgUJKN1XouXLMtXs/Dve6Lh/WY8+RoDaThu6Wg2e ttUwV+elKMtfvOEbrxgagdB1BpfYd/0= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ELeLPwyW; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1756130323; a=rsa-sha256; cv=none; b=NN3RZunF83FF12Xr/nlB0qOVX54M/AXhQN1/Mc7i15ySBYL1xk8iBWepIjKV4scm2qFS02 osj+SjKdjp9T3WUiDQiX4D5GRCM92gAfmwOtAmfhZ/BZ7ZJkSe8cbCJGTPWc8v/Pmd3yx4 gZLJue7QxQ9bIL6VTeJydrrl6/b1uJ4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1756130323; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=lxZho4Y+KRx8y6j3h2szyprS6aHvfITwJX6ZtyYAuvU=; b=ELeLPwyWqZOcgc+UzyrYqr555Wezwtj28gfzbCPIQSF0+AR+sEdOeYngKKULBzZLSRuSPJ L2drEs8+vGqPkj8mgK4g8vBHnlo+nz0s9lRkC9ik66GYtm9+x4rJDztJ5WvnLDDEkag512 aGHtkfm4dvF2G3n12Q65itJUwvdf9cI= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-132-gFZ0SeVGM9az93hvKrzKdA-1; Mon, 25 Aug 2025 09:58:40 -0400 X-MC-Unique: gFZ0SeVGM9az93hvKrzKdA-1 X-Mimecast-MFC-AGG-ID: gFZ0SeVGM9az93hvKrzKdA_1756130319 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-45b51411839so21227965e9.0 for ; Mon, 25 Aug 2025 06:58:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756130319; x=1756735119; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lxZho4Y+KRx8y6j3h2szyprS6aHvfITwJX6ZtyYAuvU=; b=S6pRR+gHTYq+TqOsDQYDR57mpnp/5XZl5HAResULktPSE3oap4jLzhUvcjtIFSGWEF 4sFK2Ehc7EmAOCA4g13TD+DLwy1q7qLEFTLwGK22DNO23sxtaiTH64sjanJaaVWNswcn GQtPlmc0Fh+4om8e3tYc4x5V7YGLgxFDIrMo1iRlCkKSx3XRqVY3YyzEn41K1cH93K3h mLrEnG3xJg0eOqQEyz51Tc9FMo8BLZfT9bgo5gdlAJWrRr6yVo37mhQs4f+Qv79edqyK GmgEnUG5yBw3E/736dBozw+qylbntq4294+dVLagCuLbfbjt8PECwaImXth9qcwiqJy+ Mmlg== X-Forwarded-Encrypted: i=1; AJvYcCX8MXixIsszYIWBqI63hfiUqkQaTp0VZypeHjEvH8CBdAiEkyO+EnB120wQGFnQ6SQnDYknAOE9uw==@kvack.org X-Gm-Message-State: AOJu0YwH4/RyWpVF1JodUeOhlbRsoiSvNrrFz73eIKhAz/YgOnt3ItO9 1a5aZRiGe8k4eYws2s/Uyb0TK023l2ZBDT7AKsmTSuay/mBi9gHtfwzm1VRjqQmg/mUeTsr/jj6 DRzbkEJby3Jj4aq29t4Fh6vhvk+wkg1ySOB38r90urGmO0pkoy3fO X-Gm-Gg: ASbGncthB5hhLyamfWnnEYi3SwCK2t1OIK03lOh3SHIC2keTAcGTDeaCS9lz56NFtpV sj6fe/cuHPa7qcBOGwmdMSzR8glS2XLypHW6/tFeym2DzUVQsmnV9fT1X0lOVTOexnyZjqsAPqo 7HBdKdqanO6ul/+sZRiTUaF9lYSF/0OYMeEmzSIC+4C3kXgIpBfqFD65gNhs3Ck5U8HQI+I9n/2 5cgkfd2SLwnI4WCuIDIb5wlK6edyK4cltIO3MJcuZMEgJIzDiJjbzMKqe8iOD7NXd8DqEAN7EvN MdGIZ04zjMXFuHeDKSGodKpoqxQV7Id8BjSbNHzPXTZ6O8iMnQTee3KFwIAtmCZLhqzvX5v06pf nIuIH5Juw40PjzaaPHjgYRuo5/51AdPWfDsGeqou1PA3c43OPQVHazVDl8HoJpMFWbYo= X-Received: by 2002:a05:600c:4fcd:b0:459:db71:74d7 with SMTP id 5b1f17b1804b1-45b517d40damr96554815e9.27.1756130319420; Mon, 25 Aug 2025 06:58:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFUP97mRYMAecNrJv9oVP9Z9C++b8mVPFeDAzLUacXcCy2KdCSOT3ajUA1Q373UfCMlAX2K9A== X-Received: by 2002:a05:600c:4fcd:b0:459:db71:74d7 with SMTP id 5b1f17b1804b1-45b517d40damr96554435e9.27.1756130318929; Mon, 25 Aug 2025 06:58:38 -0700 (PDT) Received: from ?IPV6:2003:d8:2f4f:1300:42f1:98e5:ddf8:3a76? (p200300d82f4f130042f198e5ddf83a76.dip0.t-ipconnect.de. [2003:d8:2f4f:1300:42f1:98e5:ddf8:3a76]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45b4e1d77e0sm112049385e9.0.2025.08.25.06.58.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Aug 2025 06:58:38 -0700 (PDT) Message-ID: Date: Mon, 25 Aug 2025 15:58:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC][PATCH v2 22/29] mm/numa: Register information into Kmemdump To: Eugen Hristev , Michal Hocko Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, tglx@linutronix.de, andersson@kernel.org, pmladek@suse.com, linux-arm-kernel@lists.infradead.org, linux-hardening@vger.kernel.org, corbet@lwn.net, mojha@qti.qualcomm.com, rostedt@goodmis.org, jonechou@google.com, tudor.ambarus@linaro.org, Christoph Hellwig , Sergey Senozhatsky References: <20250724135512.518487-1-eugen.hristev@linaro.org> <20250724135512.518487-23-eugen.hristev@linaro.org> <751514db-9e03-4cf3-bd3e-124b201bdb94@redhat.com> <23e7ec80-622e-4d33-a766-312c1213e56b@redhat.com> <77d17dbf-1609-41b1-9244-488d2ce75b33@redhat.com> <9f13df6f-3b76-4d02-aa74-40b913f37a8a@redhat.com> <64a93c4a-5619-4208-9e9f-83848206d42b@linaro.org> <01c67173-818c-48cf-8515-060751074c37@linaro.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZoEEwEIAEQCGwMCF4ACGQEFCwkIBwICIgIG FQoJCAsCBBYCAwECHgcWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaJzangUJJlgIpAAKCRBN 3hD3AP+DWhAxD/9wcL0A+2rtaAmutaKTfxhTP0b4AAp1r/eLxjrbfbCCmh4pqzBhmSX/4z11 opn2KqcOsueRF1t2ENLOWzQu3Roiny2HOU7DajqB4dm1BVMaXQya5ae2ghzlJN9SIoopTWlR 0Af3hPj5E2PYvQhlcqeoehKlBo9rROJv/rjmr2x0yOM8qeTroH/ZzNlCtJ56AsE6Tvl+r7cW 3x7/Jq5WvWeudKrhFh7/yQ7eRvHCjd9bBrZTlgAfiHmX9AnCCPRPpNGNedV9Yty2Jnxhfmbv Pw37LA/jef8zlCDyUh2KCU1xVEOWqg15o1RtTyGV1nXV2O/mfuQJud5vIgzBvHhypc3p6VZJ lEf8YmT+Ol5P7SfCs5/uGdWUYQEMqOlg6w9R4Pe8d+mk8KGvfE9/zTwGg0nRgKqlQXrWRERv cuEwQbridlPAoQHrFWtwpgYMXx2TaZ3sihcIPo9uU5eBs0rf4mOERY75SK+Ekayv2ucTfjxr Kf014py2aoRJHuvy85ee/zIyLmve5hngZTTe3Wg3TInT9UTFzTPhItam6dZ1xqdTGHZYGU0O otRHcwLGt470grdiob6PfVTXoHlBvkWRadMhSuG4RORCDpq89vu5QralFNIf3EysNohoFy2A LYg2/D53xbU/aa4DDzBb5b1Rkg/udO1gZocVQWrDh6I2K3+cCs7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <01c67173-818c-48cf-8515-060751074c37@linaro.org> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: C-RwNi_am_iiQlhbb3JTlVKCwweiA436olC3Xw7wAmI_1756130319 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 93E86100011 X-Stat-Signature: wn46b386jecnwqj5hspgfmdze3cpqdh6 X-Rspam-User: X-HE-Tag: 1756130323-605429 X-HE-Meta: U2FsdGVkX186E6qWXdKCwYiluZNHA6P7Gc8FNcr31ZTjIEs5/9aAcItgpgL5aTeGrJP0D6vIUJ5sl7SHC0IKBLpy6WhPqg0NXrjqop6GqF5keCil50wNKSH+kQEGa5Q/542eDT51ZFZqbhmnZqmizuxBHyFtpzaiUgZHHhtwXoAmfinZ1BZba+An7u5B8/51kZK7K8WUfOtU9kRXhuQ1GqzR/k3NOoCKsxESx7lwwAIiX17k3YIMfDLLpwZGzrRasT2+aG8JGAfyflDJ/xvN8gBEJImHoqXZhC+rBxwhail2COFseM4dJLSjq6j0TL23UPtYxCx+eZWaf8PAcJhzC57ljcGeuRq1Z+0KX8PGYMFeWlgEHwIHfsbc5LYVjEDc3LSyy4GWJtSSvoRF2F7NkoBzr1+12exLfL4Z/rtd4TFah5YXWSyI1yjSg4K8mC9UsDiaaRmqWa5S898LvPEKomoLWDkMtlL26ei/UrBpyCvRcr0XMtzhEcbbYPjAl2jOuGkQwtiVo2u/O+H2xATIFSb9InqiNbMaQMUHS4uiv1cZTULO8iMI6nhpX2cQpFOYIUEn+v+wzdW9K+OmsHLuDpJDCP6kn/eCho+LlwJ7lwOQ36iFMMJPn4cHMc+fiWjxbrfZhfbhHBxjZ97iJPtEk2TYlDVjQys+CHYWI8F2zuwOBc1RjNdHYn1dPaO/uCHfjec+4V7w7Y8a/YYdTkqq5DeA1OVbYjk2HqFMTRGAPrBIiJKRcWRCIhRsAaMCyDaf/gfBaJDcAaSeEcOBPVXHf4DCUxnyyHmFnoedj77t4emmALl/2HlF+ghUPPQXfz0uK7nKLvMZLMmkSlktuQ0PVkkSfIFWth6APc12gbKcJshYzdFVeA54q/u1b5n+jJI8lEva0MtbOHnCXQFWrUSxF6uAV2f+OJkiu7CmXjOum5uoTNiZFmZTx5Nr6Ex5FCDXh/ScLfcCK8vM3PYQzXX v8h8ToU/ KMIIH6KlVEc5SbeVP1DOI6kd4pTcB3bXK/hqGLKU7SauOzdIMA6aYk9nXMhL2ECnq/TwDbQWZf7Jj/cZnBkizMT+ah8J7O06G6wsLos7QeVxxNZj63jpTA6ujLdNFbUb/G0HenvpXkgASjltg7iUhydJ6+BmyQU5Kuq1Q+nrK/BqifJi/LELJCoMTijerKapY8dv5ur19ESo+ERAJ3mbPe8rSzXIA+gk/G2bil6yv1nfvzB6iWTaPW4Tcfj4NQM/W7UPFRYgTQPsQ5x1XEqX2hdwBxEPWFRF0T0TVKUvymXBAU/NNezYs3CUpEUledYOrCMqDlNyVsPplvcxvXbZvoVkaxktjHHSilAr6ZJQYF6amZgidUsafOVV+aaT3lATAlqF9TcxmTclm+A92C/2rWORz8y+43As+K0ehwV5IPOVCszlTHvPSeMNnftdjg/qUrBCvJ3yjsHdyC34= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 25.08.25 15:36, Eugen Hristev wrote: > > > On 8/25/25 16:20, David Hildenbrand wrote: >> >>>> >>>> IIRC, kernel/vmcore_info.c is never built as a module, as it also >>>> accesses non-exported symbols. >>> >>> Hello David, >>> >>> I am looking again into this, and there are some things which in my >>> opinion would be difficult to achieve. >>> For example I looked into my patch #11 , which adds the `runqueues` into >>> kmemdump. >>> >>> The runqueues is a variable of `struct rq` which is defined in >>> kernel/sched/sched.h , which is not supposed to be included outside of >>> sched. >>> Now moving all the struct definition outside of sched.h into another >>> public header would be rather painful and I don't think it's a really >>> good option (The struct would be needed to compute the sizeof inside >>> vmcoreinfo). Secondly, it would also imply moving all the nested struct >>> definitions outside as well. I doubt this is something that we want for >>> the sched subsys. How the subsys is designed, out of my understanding, >>> is to keep these internal structs opaque outside of it. >> >> All the kmemdump module needs is a start and a length, correct? So the >> only tricky part is getting the length. > > I also have in mind the kernel user case. How would a kernel programmer > want to add some kernel structs/info/buffers into kmemdump such that the > dump would contain their data ? Having "KMEMDUMP_VAR(...)" looks simple > enough. The other way around, why should anybody have a saying in adding their data to kmemdump? Why do we have that all over the kernel? Is your mechanism really so special? A single composer should take care of that, and it's really just start + len of physical memory areas. > Otherwise maybe the programmer has to write helpers to compute lengths > etc, and stitch them into kmemdump core. > I am not saying it's impossible, but just tiresome perhaps. In your patch set, how many of these instances did you encounter where that was a problem? >> >> One could just add a const variable that holds this information, or even >> better, a simple helper function to calculate that. >> >> Maybe someone else reading along has a better idea. > > This could work, but it requires again adding some code into the > specific subsystem. E.g. struct_rq_get_size() > I am open to ideas , and thank you very much for your thoughts. > >> >> Interestingly, runqueues is a percpu variable, which makes me wonder if >> what you had would work as intended (maybe it does, not sure). > > I would not really need to dump the runqueues. But the crash tool which > I am using for testing, requires it. Without the runqueues it will not > progress further to load the kernel dump. > So I am not really sure what it does with the runqueues, but it works. > Perhaps using crash/gdb more, to actually do something with this data, > would give more insight about its utility. > For me, it is a prerequisite to run crash, and then to be able to > extract the log buffer from the dump. I have the faint recollection that percpu vars might not be stored in a single contiguous physical memory area, but maybe my memory is just wrong, that's why I was raising it. > >> >>> >>> From my perspective it's much simpler and cleaner to just add the >>> kmemdump annotation macro inside the sched/core.c as it's done in my >>> patch. This macro translates to a noop if kmemdump is not selected. >> >> I really don't like how we are spreading kmemdump all over the kernel, >> and adding complexity with __section when really, all we need is a place >> to obtain a start and a length. >> > > I understand. The section idea was suggested by Thomas. Initially I was > skeptic, but I like how it turned out. Yeah, I don't like it. Taste differs ;) I am in particular unhappy about custom memblock wrappers. [...] >>> >>> To have this working outside of printk, it would be required to walk >>> through all the printk structs/allocations and select the required info. >>> Is this something that we want to do outside of printk ? >> >> I don't follow, please elaborate. >> >> How is e.g., log_buf_len_get() + log_buf_addr_get() not sufficient, >> given that you run your initialization after setup_log_buf() ? >> >> > > My initial thought was the same. However I got some feedback from Petr > Mladek here : > > https://lore.kernel.org/lkml/aBm5QH2p6p9Wxe_M@localhost.localdomain/ > > Where he explained how to register the structs correctly. > It can be that setup_log_buf is called again at a later time perhaps. > setup_log_buf() is a __init function, so there is only a certain time frame where it can be called. In particular, once the buddy is up, memblock allocations are impossible and it would be deeply flawed to call this function again. Let's not over-engineer this. Peter is on CC, so hopefully he can share his thoughts. -- Cheers David / dhildenb