From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91CECC10F16 for ; Tue, 30 Apr 2024 13:46:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0FBB26B0093; Tue, 30 Apr 2024 09:46:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0AB4C6B0095; Tue, 30 Apr 2024 09:46:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E675F6B0096; Tue, 30 Apr 2024 09:46:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C54E06B0093 for ; Tue, 30 Apr 2024 09:46:05 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 715AE1408C9 for ; Tue, 30 Apr 2024 13:46:05 +0000 (UTC) X-FDA: 82066321890.11.99F9886 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) by imf15.hostedemail.com (Postfix) with ESMTP id 71554A0004 for ; Tue, 30 Apr 2024 13:46:02 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b="X/xR7WMR"; dmarc=none; spf=pass (imf15.hostedemail.com: domain of axboe@kernel.dk designates 209.85.216.54 as permitted sender) smtp.mailfrom=axboe@kernel.dk ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714484762; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JjNR4wPlgvb/NrdAvCR/ceifiIGObytGntMYaBKjRCU=; b=AL8Q5hY4FcpQWDAJwV8Aj7FBk9F2W64roBJSmfOOlw2w/VwpC0zsQ6f+Mpvqhw95vlJ51C 50viVdgKHSJ4WWzWF3qSYV2S2BpmwMvdbR/wMM56wH+KDN4WJVMlMLM3IX+JZV5QSnBIlB TKIO1LVG3gRhuakp39M7q/kgSBWU/lE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714484762; a=rsa-sha256; cv=none; b=a9HQx7do292MqzgkxN0uJzKshCPYKNdYhn/c7Bvj15EQ6/MhJyVQydeWp7cE1NU/kSGAPn EYSneyhGz675b/G9P1X4fOlh/oTRkZeNG0Bt2mn3/0U5XOWQOuDyH1FQgt7MTS8cJYvbDK Oa2zqhw6kdl6VYXTwxozohmMhCcqY/c= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b="X/xR7WMR"; dmarc=none; spf=pass (imf15.hostedemail.com: domain of axboe@kernel.dk designates 209.85.216.54 as permitted sender) smtp.mailfrom=axboe@kernel.dk Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-2ab48c14334so1379858a91.3 for ; Tue, 30 Apr 2024 06:46:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1714484761; x=1715089561; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=JjNR4wPlgvb/NrdAvCR/ceifiIGObytGntMYaBKjRCU=; b=X/xR7WMRimVrvNrbKJ0MwMFr+tu1JKyr6mYO+4nO/Fyf5StfJfLLq2Xf81zAcrxB32 Q7FAiMJqCZjaX9u+LnN1ll1KnR40I38kgsViIP8gGZwSc2mXByQcSWRlY5u8Sg2O23nq kFTtuCIJWBXZjGug+OZyK74HEkeFLJ1Mq4eincumgX8oVywo2RtoowenOYyntNoTF9Fc yjXkqcimWTr5RuyfOvyakMBSxlPpY73UtZNPuI4sBxUN0nZQFA1CL6ZL2PF64k9dmFcC 1TFsZ6sDhGoxQOjnBhn4UWUDYMdy2tWp8OZZ/f9BShk4FpCvoWdAnRQPwdH1dztCk2AT PneA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714484761; x=1715089561; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JjNR4wPlgvb/NrdAvCR/ceifiIGObytGntMYaBKjRCU=; b=jnRjYzOjh89H0XfBGwkzCFYf6bV/a4z4n4JSH7il/6OHPMUxKl+P/FofbyR/Jgl93v Oj+nJmJNkOkkN3UEldgSllpW3rle4jfhjtnZ6t2bLV2EjRkXGH3eCNWC00Edb5JzlT29 pH3kCx4o743/ggrw+EmRUDiaZbzjJ8YnQsfUlEo7NTQgxwHmW21JMIj00oG2io3Hqgii dVKh4JogZFk8hHYE/DBiqeEYkEHEEJ4024kfNUoy5FBjKUVHteQ2Vi5ohYoo1JqvHmsE dOqD7aLcGNZfBhGHfFtfsko5Mdp1rpJybOKcAX1MpfQPDZJUvuz1Dou85W4O2d+itlb3 mVtA== X-Forwarded-Encrypted: i=1; AJvYcCWUKWpJIepyjI9x398HX9UbBmQkaodltr4XplO2SrOcNFj+Cd0RXpo4BorgaEK7FxaChgICkj/lt0k3BB5TdbYeSz0= X-Gm-Message-State: AOJu0Yz2vIm+y7hFv4TmeWZV5yVjq0rd/dv/7UTDY7T91WCsWIXgw8Rd 95EKd+OAaB3esStbVsCs11DBCLyVC1ruFV9kkwS+9b/LfsSA95sa2Hgvd39CvcQ= X-Google-Smtp-Source: AGHT+IH9R1bNbi/b5An2t0YujuKFT91RDi4jOUG3j3R9m2Jy6nNwhLv9ihFj9tl7tQbksDchw49Kdw== X-Received: by 2002:a05:6a00:1d22:b0:6ed:cc50:36cd with SMTP id a34-20020a056a001d2200b006edcc5036cdmr14955130pfx.2.1714484761068; Tue, 30 Apr 2024 06:46:01 -0700 (PDT) Received: from [192.168.1.150] ([198.8.77.194]) by smtp.gmail.com with ESMTPSA id fe8-20020a056a002f0800b006ed00ea504asm21108186pfb.159.2024.04.30.06.45.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Apr 2024 06:46:00 -0700 (PDT) Message-ID: Date: Tue, 30 Apr 2024 07:45:52 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH net-next v8 07/14] page_pool: devmem support To: Mina Almasry , David Wei Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-alpha@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, sparclinux@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-arch@vger.kernel.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jonathan Corbet , Richard Henderson , Ivan Kokshaysky , Matt Turner , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Andreas Larsson , Jesper Dangaard Brouer , Ilias Apalodimas , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Arnd Bergmann , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Steffen Klassert , Herbert Xu , David Ahern , Willem de Bruijn , Shuah Khan , Sumit Semwal , =?UTF-8?Q?Christian_K=C3=B6nig?= , Amritha Nambiar , Maciej Fijalkowski , Alexander Mikhalitsyn , Kaiyuan Zhang , Christian Brauner , Simon Horman , David Howells , Florian Westphal , Yunsheng Lin , Kuniyuki Iwashima , Arseniy Krasnov , Aleksander Lobakin , Michael Lass , Jiri Pirko , Sebastian Andrzej Siewior , Lorenzo Bianconi , Richard Gobert , Sridhar Samudrala , Xuan Zhuo , Johannes Berg , Abel Wu , Breno Leitao , Pavel Begunkov , Jason Gunthorpe , Shailend Chand , Harshitha Ramamurthy , Shakeel Butt , Jeroen de Borst , Praveen Kaligineedi , linux-mm@kvack.org, Matthew Wilcox References: <20240403002053.2376017-1-almasrymina@google.com> <20240403002053.2376017-8-almasrymina@google.com> <8357256a-f0e9-4640-8fec-23341fc607db@davidwei.uk> Content-Language: en-US From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 71554A0004 X-Stat-Signature: nu7cqzi7zm1jqr5qxsesm9jazjfzazzs X-Rspam-User: X-HE-Tag: 1714484762-931662 X-HE-Meta: U2FsdGVkX19xEKkIz/R3MkKjTW44+vva2J0PBG524mw2w1m+0kjQA5CUxQ7Y39bczXWg4fI5u07J2pItLX5wLUoBJXp0fCSJquyBabKuc9UdGO6BdK8KsgqSEl6tj7xz6aKxXwYz6t3XNn+jyYgAfFxPR7U2Xs7NfGdcwwoIMtbHnOJmxZ4H8hVzBIJzLkMo1nYfV9Qq1oZM/qft6I+RAXxrBynHDVkWfj+95yly5DQkzr4mCisWNBZNBEIbiRSgEUQOntjSHYbVRUWGYcewyFQlF72z2ZuFZyG1PyVu2AcLT4iVBYz8PET69Q6A8rye11BznvpdgDS1H3EhOGhXoLWW+l5Su9d1WLOEqkCBw53bncz1y0s5cl9vJc8551Jki6gdqM6lX/atb+5qaxcutwLHJuk1WKTuVpote4OZPmegqIs6PXUYDvZg4tEyB+Et4Uck43llsbJ7bWWAUtDdBRfPMCSJnxYBy0qAfPL7wMqJAuSDdPvaBSf0be2VBALLoaRQzp6VxBtwsR4ueQkMpX9smhVPpDbXqFP5CKl1d7YbK/xaf7vEP2aotS53ljw39WCLYFibJxvttKTi61slwbagg5rtI5C3q/fCIQkRxRRfK+bSFEgCigAML4BJXKAmMv+dYVUSTjKkpj/B/UdwdwJ9MyUXQTGEmwdeVm6FLb6wSPMKt+Qftl0z9OUqZHOnkd0fwIwb4y4BPrBiLcShbsW7BTOX1x+3JMpog1sdW6tgM1NfFp3pPHf0W7U/BYUVqndSceLecnB8JkqEayx8EEyv+HAmBbODS/Qf6JMroKSIos0nb3onbcNCdGzOlCtat5VuHOZFsO9v+6NVzabjYjp1EPaHeDhaQHg824/dDW03tzr8xSfY+8/bNefObW9dsTAYVZcRl/kXFqQgDFevF7+/muIs+NgMryzOh+4ctTFpj7LVQ4lNpOGeYQVj1E1M0RXcb99YfII3v757wyG 1qzm1WXi pDA5jpvbjNTICH88G8xcx6H6+b2hYQKc46cOag0JbqmbVjcNAmY843Rk3lJRyPCTlPfExbC+4pSJVEq7vYHQYRpxwbcOnz+Oe+rg/W021CqN21YENNJM0K+oeyS5gsVkNV7ulFTFbB4acrsBYhFJwUhIgPpe1xFJsoNt8tmPCXQMnB8gosu/1ZJtOuWmF1qfWG+z3HJJWUR8RCLUKHdhU/sKJYP+65+ceBNAGwvrIO+hl+ZmA3J4QA6EHL77mbtldtfH2x/OTHmN9ZYa78FtcGtq6zBxiTNebocMKvHXd3KkomJjC3AHXbqBd8KCIFuEwTit0Hx1Z8yliP+MrJwMHz7NW5BXX8v1XYbjGonREg1wCv5BnPNT3iUS9d+RYsjr3vZXYJkGcb+SRB0qLM1JKKgsV5QiozxVgo4D1Bbj4oYeNJRpESHvCDiwIU+YT37IeV0pA9ON3vZk1lgeuBLVLgq6wYglxXRUmDRglN1exqoIMdVE05X/RcCv9RYZsxtQbhyE2eS/abKNM14q32loj2tzbko4NkvU88zer X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/26/24 8:11 PM, Mina Almasry wrote: > On Fri, Apr 26, 2024 at 5:18?PM David Wei wrote: >> >> On 2024-04-02 5:20 pm, Mina Almasry wrote: >>> @@ -69,20 +106,26 @@ net_iov_binding(const struct net_iov *niov) >>> */ >>> typedef unsigned long __bitwise netmem_ref; >>> >>> +static inline bool netmem_is_net_iov(const netmem_ref netmem) >>> +{ >>> +#if defined(CONFIG_PAGE_POOL) && defined(CONFIG_DMA_SHARED_BUFFER) >> >> I am guessing you added this to try and speed up the fast path? It's >> overly restrictive for us since we do not need dmabuf necessarily. I >> spent a bit too much time wondering why things aren't working only to >> find this :( > > My apologies, I'll try to put the changelog somewhere prominent, or > notify you when I do something that I think breaks you. > > Yes, this is a by-product of a discussion with regards to the > page_pool benchmark regressions due to adding devmem. There is some > background on why this was added and the impact on the > bench_page_pool_simple tests in the cover letter. > > For you, I imagine you want to change this to something like: > > #if defined(CONFIG_PAGE_POOL) > #if defined(CONFIG_DMA_SHARED_BUFFER) || defined(CONFIG_IOURING) > > or something like that, right? Not sure if this is something I should > do here or if something more appropriate to be in the patches you > apply on top. In general, attempting to hide overhead behind config options is always a losing proposition. It merely serves to say "look, if these things aren't enabled, the overhead isn't there", while distros blindly enable pretty much everything and then you're back where you started. -- Jens Axboe