From: Mike Rapoport <rppt@kernel.org>
To: Chenghao Duan <duanchenghao@kylinos.cn>
Cc: pasha.tatashin@soleen.com, pratyush@kernel.org,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, jianghaoran@kylinos.cn
Subject: Re: [PATCH v1 2/3] mm/memfd_luo: remove unnecessary memset in zero-size memfd path
Date: Fri, 20 Mar 2026 13:37:01 +0200 [thread overview]
Message-ID: <ab0xXX051uk9S1rl@kernel.org> (raw)
In-Reply-To: <20260319012845.29570-3-duanchenghao@kylinos.cn>
On Thu, Mar 19, 2026 at 09:28:44AM +0800, Chenghao Duan wrote:
> The memset(kho_vmalloc, 0, sizeof(*kho_vmalloc)) call in the zero-size
> file handling path is unnecessary because the allocation of the ser
> structure already uses the __GFP_ZERO flag, ensuring the memory is
> already zero-initialized.
>
> Signed-off-by: Chenghao Duan <duanchenghao@kylinos.cn>
Reviewed-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
> ---
> mm/memfd_luo.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/mm/memfd_luo.c b/mm/memfd_luo.c
> index 5ddd3657d8be..413df8c75c1d 100644
> --- a/mm/memfd_luo.c
> +++ b/mm/memfd_luo.c
> @@ -103,7 +103,6 @@ static int memfd_luo_preserve_folios(struct file *file,
> if (!size) {
> *nr_foliosp = 0;
> *out_folios_ser = NULL;
> - memset(kho_vmalloc, 0, sizeof(*kho_vmalloc));
> return 0;
> }
>
> --
> 2.25.1
>
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2026-03-20 11:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-19 1:28 [PATCH v1 0/3] Modify memfd_luo code Chenghao Duan
2026-03-19 1:28 ` [PATCH v1 1/3] mm/memfd_luo: optimize shmem_recalc_inode calls in retrieve path Chenghao Duan
2026-03-19 15:28 ` Pasha Tatashin
2026-03-20 9:53 ` Pratyush Yadav
2026-03-20 10:02 ` Pratyush Yadav
2026-03-19 1:28 ` [PATCH v1 2/3] mm/memfd_luo: remove unnecessary memset in zero-size memfd path Chenghao Duan
2026-03-19 16:20 ` Pasha Tatashin
2026-03-20 10:04 ` Pratyush Yadav
2026-03-20 11:37 ` Mike Rapoport [this message]
2026-03-19 1:28 ` [PATCH v1 3/3] mm/memfd_luo: use i_size_write() to set inode size during retrieve Chenghao Duan
2026-03-19 16:24 ` Pasha Tatashin
2026-03-20 9:51 ` Pratyush Yadav
2026-03-20 11:35 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab0xXX051uk9S1rl@kernel.org \
--to=rppt@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=duanchenghao@kylinos.cn \
--cc=jianghaoran@kylinos.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pasha.tatashin@soleen.com \
--cc=pratyush@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox