From: David Hildenbrand <david@redhat.com>
To: Lance Yang <ioworker0@gmail.com>, akpm@linux-foundation.org
Cc: 21cnbao@gmail.com, ryan.roberts@arm.com,
baolin.wang@linux.alibaba.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH 0/2] mm: introduce per-order mTHP split counters
Date: Wed, 24 Apr 2024 17:00:01 +0200 [thread overview]
Message-ID: <ab18a4b1-bcbf-4417-b43a-5feae3b5ba66@redhat.com> (raw)
In-Reply-To: <20240424135148.30422-1-ioworker0@gmail.com>
On 24.04.24 15:51, Lance Yang wrote:
> Hi all,
>
> At present, the split counters in THP statistics no longer include
> PTE-mapped mTHP. Therefore, we want to introduce per-order mTHP split
> counters to monitor the frequency of mTHP splits. This will assist
> developers in better analyzing and optimizing system performance.
>
> /sys/kernel/mm/transparent_hugepage/hugepages-<size>/stats
> split_page
> split_page_failed
> deferred_split_page
>
> Thanks,
> Lance
> ---
>
> Lance Yang (2):
> mm: add per-order mTHP split counters
> mm: add docs for per-order mTHP split counters
>
> Documentation/admin-guide/mm/transhuge.rst | 16 ----------------
We really have to start documenting these, and what the sementics are.
E.g., is split_page_failed contained in split_page? Is
deferred_split_page contained in split_page?
But also: just don't call it "split_page". Drop the "_page".
split
split_failed
split_deferred
?
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2024-04-24 15:00 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 13:51 [PATCH 0/2] mm: introduce per-order mTHP split counters Lance Yang
2024-04-24 13:51 ` [PATCH 1/2] mm: add " Lance Yang
2024-04-24 15:41 ` Ryan Roberts
2024-06-30 9:48 ` Barry Song
2024-06-30 11:34 ` Lance Yang
2024-07-01 8:16 ` Ryan Roberts
2024-07-01 11:00 ` Lance Yang
2024-08-08 21:27 ` Barry Song
2024-08-09 7:50 ` Ryan Roberts
2024-07-01 8:56 ` David Hildenbrand
2024-07-01 11:06 ` Lance Yang
2024-07-01 11:43 ` Barry Song
2024-07-01 12:21 ` David Hildenbrand
2024-04-24 17:12 ` Bang Li
2024-04-24 17:58 ` Bang Li
2024-04-25 4:47 ` Lance Yang
2024-04-24 19:44 ` Yang Shi
2024-04-25 5:13 ` Lance Yang
2024-04-24 13:51 ` [PATCH 2/2] mm: add docs for " Lance Yang
2024-04-24 15:34 ` Ryan Roberts
2024-04-25 5:26 ` Lance Yang
2024-04-24 15:00 ` David Hildenbrand [this message]
2024-04-24 15:20 ` [PATCH 0/2] mm: introduce " Ryan Roberts
2024-04-24 15:29 ` David Hildenbrand
2024-04-24 15:53 ` Lance Yang
2024-04-24 15:54 ` Lance Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab18a4b1-bcbf-4417-b43a-5feae3b5ba66@redhat.com \
--to=david@redhat.com \
--cc=21cnbao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=ioworker0@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ryan.roberts@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).