From: David Hildenbrand <david@redhat.com>
To: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
"Adrian Huang (Lenovo)" <adrianhuang0701@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Liam.Howlett@oracle.com, Vlastimil Babka <vbabka@suse.cz>,
Mike Rapoport <rppt@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>,
Feng Tang <feng.79.tang@gmail.com>,
ahuang12@lenovo.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] mm: Correct misleading comment on mmap_lock field in mm_struct
Date: Wed, 6 Aug 2025 22:06:45 +0200 [thread overview]
Message-ID: <ab2f8752-6bac-43c6-b889-f5940a6c94af@redhat.com> (raw)
In-Reply-To: <9305bdaf-9455-4c26-befb-471466f952ab@lucifer.local>
On 06.08.25 21:07, Lorenzo Stoakes wrote:
> On Wed, Aug 06, 2025 at 10:59:06PM +0800, Adrian Huang (Lenovo) wrote:
>> The comment previously described the offset of mmap_lock as 0x120 (hex),
>> which is misleading. The correct offset is 56 bytes (decimal) from the
>> last cache line boundary. Using '0x120' could confuse readers trying to
>> understand why the count and owner fields reside in separate cachelines.
>>
>> This change also removes an unnecessary space for improved formatting.
>>
>> Signed-off-by: Adrian Huang (Lenovo) <adrianhuang0701@gmail.com>
>
> LGTM, so:
>
> Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Acked-by: David Hildenbrand <david@redhat.com>
--
Cheers,
David / dhildenb
prev parent reply other threads:[~2025-08-06 20:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-06 14:59 [PATCH v2 1/1] mm: Correct misleading comment on mmap_lock field in mm_struct Adrian Huang (Lenovo)
2025-08-06 19:07 ` Lorenzo Stoakes
2025-08-06 20:06 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab2f8752-6bac-43c6-b889-f5940a6c94af@redhat.com \
--to=david@redhat.com \
--cc=Liam.Howlett@oracle.com \
--cc=adrianhuang0701@gmail.com \
--cc=ahuang12@lenovo.com \
--cc=akpm@linux-foundation.org \
--cc=feng.79.tang@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@suse.com \
--cc=rppt@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).