From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2EF9C4167B for ; Mon, 27 Nov 2023 15:12:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 95D576B026B; Mon, 27 Nov 2023 10:12:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 90BDC6B026D; Mon, 27 Nov 2023 10:12:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 75F526B0279; Mon, 27 Nov 2023 10:12:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 607056B026B for ; Mon, 27 Nov 2023 10:12:02 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 25FA81402B5 for ; Mon, 27 Nov 2023 15:12:02 +0000 (UTC) X-FDA: 81504074484.22.6ABE4BD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf25.hostedemail.com (Postfix) with ESMTP id 4D260A00D4 for ; Mon, 27 Nov 2023 15:11:11 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Tb6xf7qB; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701097871; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wiS/QSHyrQLt30DtgLQ/3a1/rZ4tdJUecrIYLVt9a50=; b=XYrSl8gnHPb1BxDUT3GRsvFjk0u/wr3L8KEVu3wfer8BTbibj/aKNkD0ckdCxusvMRtA6w xGWDbsZX2wQSi/ScGsQoMAUieJehotRzGE6RQR7RzoMCrnuQHT/pDO4vMO9QsYkBmrrs5N YXDRbr7HArX6heRrtUV3FNLjfs5Vp10= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Tb6xf7qB; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701097871; a=rsa-sha256; cv=none; b=KmTX2GUcPSsMb3nHDP6BRSz+mANaLuqak5JG7Bzllt3+bhqA7xGiXSc1XuhuMH0XEI1AIr cc/a3OmT9gF7tlq0fQMxtgMXAPAQsU0K7QyW6YzBNyNfgGJoJIVCUyD2SjhKjBnTaecRxf lyu2T2TemLGrksKWpF46jw2cB+gcq2M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701097870; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=wiS/QSHyrQLt30DtgLQ/3a1/rZ4tdJUecrIYLVt9a50=; b=Tb6xf7qBfg9k6v6Blgef2fjGgkqffdFUZWH8ZAEoZ01lIgSTB7WxHNeDMkrQaxPu5hb9T7 l1vn8qAZ2aFWmUkZXP/+mmsG14uuPyufc4zXbXEOK15g2HRJxpN/OsDh0Pwx3C8IL1zGUV SXS4K9m4u9c9SaA2M8hFHRyws7Fa4U0= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-688-q9-V2OKlO4qC2JaZowQJsQ-1; Mon, 27 Nov 2023 10:11:08 -0500 X-MC-Unique: q9-V2OKlO4qC2JaZowQJsQ-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-332e2e0b98bso3150414f8f.1 for ; Mon, 27 Nov 2023 07:11:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701097867; x=1701702667; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wiS/QSHyrQLt30DtgLQ/3a1/rZ4tdJUecrIYLVt9a50=; b=WiUjroNNbbpwkLrfZfgv0lN9X1MtCMYR2iiJHsFkVFPe4CYPO0WgyWQuREGFR3BujB AiEdDlqPl7+LWTTkpGPs4NZMUniE2DyPuFTCmn9uanLr2/CW+nl/79d54GtKqKzhwQgL LUozPfiGMB6GCaNxpPjppY88c8Q+u8Er2XUawLq7jASo7Kxd7v+XLW+9l1qzOICRbRkb M6GF1/t4XpJac2YrAvtUBtOSmp1hkmPBef6hnnz+peETqm48ndqMpVFYe6y7xuycR++h x2O/zQHYiJOExsmYSADTr9hPPyMy8JNUiYpI/I2XirwuP1Pf8wzmv+dUt+nbReNOqQJC DnMQ== X-Gm-Message-State: AOJu0YzkvjT+xKzGJ6vTX2//vK89s28APDEqYX3mA8zWIWTeWffIzoU6 YG96CdxyPym/5a//fvWmyEpcsb1ciNkL76jm5v08D5JIgny/IKRJizMJPrzUGUaONnCyg9M/yEz yZ2UBX1ec4U9bUwrqxeE= X-Received: by 2002:a5d:4843:0:b0:332:fa75:a8ed with SMTP id n3-20020a5d4843000000b00332fa75a8edmr3467274wrs.24.1701097867280; Mon, 27 Nov 2023 07:11:07 -0800 (PST) X-Google-Smtp-Source: AGHT+IG8pSZb/HQRWFQziCuTdC0qDXsah32JbJGmIDFW/3g6eHxXGGPPndHyglepnJOARh/1WN0Nww== X-Received: by 2002:a5d:4843:0:b0:332:fa75:a8ed with SMTP id n3-20020a5d4843000000b00332fa75a8edmr3467240wrs.24.1701097866715; Mon, 27 Nov 2023 07:11:06 -0800 (PST) Received: from ?IPV6:2003:cb:c745:2a00:d74a:a8c5:20b6:3ec3? (p200300cbc7452a00d74aa8c520b63ec3.dip0.t-ipconnect.de. [2003:cb:c745:2a00:d74a:a8c5:20b6:3ec3]) by smtp.gmail.com with ESMTPSA id v10-20020adff68a000000b00332c0e934aasm12144905wrp.44.2023.11.27.07.11.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Nov 2023 07:11:06 -0800 (PST) Message-ID: Date: Mon, 27 Nov 2023 16:11:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 4/5] s390/mm: implement MEM_PREPARE_ONLINE/MEM_FINISH_OFFLINE notifiers To: Sumanth Korikkar , linux-mm , Andrew Morton Cc: Oscar Salvador , Michal Hocko , "Aneesh Kumar K.V" , Anshuman Khandual , Gerald Schaefer , Alexander Gordeev , Heiko Carstens , Vasily Gorbik , linux-s390 , LKML References: <20231127082023.2079810-1-sumanthk@linux.ibm.com> <20231127082023.2079810-5-sumanthk@linux.ibm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20231127082023.2079810-5-sumanthk@linux.ibm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4D260A00D4 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: gfazuxjbagcah7chhodkmsnr1erdqgam X-HE-Tag: 1701097871-534518 X-HE-Meta: U2FsdGVkX19DhMOjVQs9/QlBhEUxb+OGWMGa/NLzpkNRqq2TtgRivdRksnCQul83ABAcvrsFuWCHurECo4idZY2/uiA/vVU5ySTO8N90h9o1h7+hsWLvJjebU1+UmqbF6XUdGxmOX6oz+68rHYBLYPRhirq1dxl0AIgOeGdxgMTT9FZVsocDbcMmKeVlqrI5/IDm/EZcCbjPcGxU7rouzAHGlBxSYWv6LcQns6MTI+2zdRUDoBnkDSGBgOi2SVgCBFm5cQRTEbIEII1JBHaCTRMSMBGgBjscfUPsIu456JmDeD8ZSsL+o+Ldu2frMZU/bzhatFOtRCMkwwAw8rxb6Toz01iRBC593Y1aygkIsmoOcXgBZuIgnNVPWZFmRQBWe3N3hqtfUfC9qJlP3ftD3bp9Ux14G24Kqo8qDGZjXSyymlHwZUwe1fFcPVwsCHM/Ew3fk/SH9I7sAbodKK7U1SJJhikuYpGSmhKI94iHKhMaioRIKU8TRQDJhJi2BwNGqaNkBTJkV7Kknz5k7vQyM5lU7+NTqO6Y5WLplJFMgCYiho1duaET/Es3kWwumCR2BWN6rXZMUoEEWkFv8ODmOGsEiRaLgXFgCRnOsdiC4ehZjjKnvziwEOAmo1SGeole1JtKoeT0ec0oZIOkOWkzfr8JivL6o3DsxQ1G4JJjQJfpra46O9y8/ipNSB2oxI/IaLhO/PZUeUvZj/nw8PxaaHs0+uIo3iuYlef9SshLYyEpg0ULAPVHf20mBQOx4Lvr3PuCR0RZdnqd7LswmPzzJcPgGjYRQFh/nusX3eS3AiHPfLA9EotIba/qJmguvawIgVEXirn3HLGGAYuCQsRYZUjYi4iCRtiji3+xjVt8uW5BYVIdoKmBwMwiwv5osMuK5RmSBsP9TiMwyK4g+W9yj0IAY29ljhAuX7WhA998BiJ10qm3Dps7Mxje86Eg8wCHOE0mvGuW4VXCQ5eJ26i ywK6sMq4 RqLJ8dfKJ/PJZS5lV2qZQ/CdM8VWG1j09Eez2pkhSKbhiqWQ1nNEMHp/3tdQK97i3oxN4JQ8z+2VpNzNpmRPG4u1h7k/njQ1nuKM4lnuzkeEAhSnyLlAqmezdFgExRgOSRCfcolwtl18Krc6DYdd+qted90eOCocZoXG4jyMoM+e2xPorDL22JaUgKOTnlD+A934yLWmVuterUv35/+n7Q5lUDOHI0dPra+cFEi/tVvQBESk7y7LPq6uHU0DxFPqRbZFDZBP3bZW2b5DoGYKFKVQOPIXP9YmzIeNmKdiq7qPfsLH0uDkhmSOIrKUUQDv31DRNiLzUMM5leylmjldikiFCz5jKe+ymTVpMcCPlKC8hcf8J/vaVfWmdQgVQOcXpfDxQdgun86RfbS+g6w59hIJeEMm+nd27L+G1AGty30j3a4AeuW2W2XcI3MZ+wOMuYHxixmRp9B0sjd94+mxgZKA1T9m+JWW39QZNWe0H6X99xAd87dig1JFyPg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 27.11.23 09:20, Sumanth Korikkar wrote: > MEM_PREPARE_ONLINE memory notifier makes memory block physical > accessible via sclp assign command. The notifier ensures self-contained > memory maps are accessible and hence enabling the "memmap on memory" on > s390. > > MEM_FINISH_OFFLINE memory notifier shifts the memory block to an > inaccessible state via sclp unassign command. > > Implementation considerations: > * When MHP_MEMMAP_ON_MEMORY is disabled, the system retains the old > behavior. This means the memory map is allocated from default memory. > * If MACHINE_HAS_EDAT1 is unavailable, MHP_MEMMAP_ON_MEMORY is > automatically disabled. This ensures that vmemmap pagetables do not > consume additional memory from the default memory allocator. > * The MEM_GOING_ONLINE notifier has been modified to perform no > operation, as MEM_PREPARE_ONLINE already executes the sclp assign > command. > * The MEM_CANCEL_ONLINE/MEM_OFFLINE notifier now performs no operation, as > MEM_FINISH_OFFLINE already executes the sclp unassign command. > > Reviewed-by: Gerald Schaefer > Signed-off-by: Sumanth Korikkar > --- > drivers/s390/char/sclp_cmd.c | 28 ++++++++++++++++++++++------ > 1 file changed, 22 insertions(+), 6 deletions(-) > > diff --git a/drivers/s390/char/sclp_cmd.c b/drivers/s390/char/sclp_cmd.c > index 355e63e44e95..30b829e4c052 100644 > --- a/drivers/s390/char/sclp_cmd.c > +++ b/drivers/s390/char/sclp_cmd.c > @@ -18,6 +18,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -26,6 +27,7 @@ > #include > #include > #include > +#include > > #include "sclp.h" > > @@ -319,6 +321,7 @@ static bool contains_standby_increment(unsigned long start, unsigned long end) > static int sclp_mem_notifier(struct notifier_block *nb, > unsigned long action, void *data) > { > + struct memory_block *memory_block; > unsigned long start, size; > struct memory_notify *arg; > unsigned char id; > @@ -340,18 +343,29 @@ static int sclp_mem_notifier(struct notifier_block *nb, > if (contains_standby_increment(start, start + size)) > rc = -EPERM; > break; > - case MEM_GOING_ONLINE: > + case MEM_PREPARE_ONLINE: > + memory_block = find_memory_block(pfn_to_section_nr(arg->start_pfn)); > + if (!memory_block) { > + rc = -EINVAL; > + goto out; > + } > rc = sclp_mem_change_state(start, size, 1); > + if (rc || !memory_block->altmap) > + goto out; > + /* > + * Set CMMA state to nodat here, since the struct page memory > + * at the beginning of the memory block will not go through the > + * buddy allocator later. > + */ > + __arch_set_page_nodat((void *)__va(start), memory_block->altmap->free); Looking up the memory block and grabbing the altmap from there is a bit unfortunate. Why can't we do that when adding the altmap? Will the hypervisor scream at us? ... would we want to communicate any altmap start+size via the memory notifier instead? -- Cheers, David / dhildenb