From: Mike Rapoport <rppt@kernel.org>
To: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
kernel-dev@igalia.com, kernel@gpiccoli.net,
Andrew Morton <akpm@linux-foundation.org>,
Steven Rostedt <rostedt@goodmis.org>,
SeongJae Park <sj@kernel.org>
Subject: Re: [PATCH v3 2/2] mm/memblock: Add reserve_mem debugfs info
Date: Thu, 19 Mar 2026 20:01:43 +0200 [thread overview]
Message-ID: <abw6ByiCi9mOZQof@kernel.org> (raw)
In-Reply-To: <9066d011-7dd6-4d2e-26b0-72f83d3e5862@igalia.com>
On Thu, Mar 19, 2026 at 02:14:00PM -0300, Guilherme G. Piccoli wrote:
> On 19/03/2026 13:34, Mike Rapoport wrote:
> > [...]
> >> {
> >> - struct dentry *root = debugfs_create_dir("memblock", NULL);
> >> -
> >> - debugfs_create_file("memory", 0444, root,
> >> - &memblock.memory, &memblock_debug_fops);
> >> - debugfs_create_file("reserved", 0444, root,
> >> - &memblock.reserved, &memblock_debug_fops);
> >> #ifdef CONFIG_HAVE_MEMBLOCK_PHYS_MAP
> >> debugfs_create_file("physmem", 0444, root, &physmem,
> >> &memblock_debug_fops);
> >> #endif
> >> + debugfs_create_file("memory", 0444, root,
> >> + &memblock.memory, &memblock_debug_fops);
> >> + debugfs_create_file("reserved", 0444, root,
> >> + &memblock.reserved, &memblock_debug_fops);
> >
> > No need to move these after PHYS_MAP attribute
> >
>
> OK, your call, will change it in the respin as well.
> Thanks,
That's actually more of a rule in the kernel: don't introduce unnecessary
changes :)
> Guilherme
>
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2026-03-19 18:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-18 18:56 [PATCH v3 0/2] Small improvements to reserve_mem, 3rd attempt Guilherme G. Piccoli
2026-03-18 18:56 ` [PATCH v3 1/2] mm/memblock: Print out errors on reserve_mem parser Guilherme G. Piccoli
2026-03-18 18:56 ` [PATCH v3 2/2] mm/memblock: Add reserve_mem debugfs info Guilherme G. Piccoli
2026-03-19 16:34 ` Mike Rapoport
2026-03-19 17:14 ` Guilherme G. Piccoli
2026-03-19 18:01 ` Mike Rapoport [this message]
2026-03-24 1:22 ` [PATCH v4 1/2] mm/memblock: Print out errors on reserve_mem parser Guilherme G. Piccoli
2026-03-24 1:22 ` [PATCH v4 2/2] mm/memblock: Add reserve_mem debugfs info Guilherme G. Piccoli
2026-03-25 1:24 ` SeongJae Park
2026-03-24 15:17 ` [PATCH v3 0/2] Small improvements to reserve_mem, 3rd attempt Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abw6ByiCi9mOZQof@kernel.org \
--to=rppt@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=gpiccoli@igalia.com \
--cc=kernel-dev@igalia.com \
--cc=kernel@gpiccoli.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rostedt@goodmis.org \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox