From: "Harry Yoo (Oracle)" <harry@kernel.org>
To: Mike Rapoport <rppt@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andrea Arcangeli <aarcange@redhat.com>,
Andrei Vagin <avagin@google.com>,
Axel Rasmussen <axelrasmussen@google.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
David Hildenbrand <david@kernel.org>,
Hugh Dickins <hughd@google.com>,
James Houghton <jthoughton@google.com>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
"Lorenzo Stoakes (Oracle)" <ljs@kernel.org>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
Michal Hocko <mhocko@suse.com>,
Muchun Song <muchun.song@linux.dev>,
Nikita Kalyazin <kalyazin@amazon.com>,
Oscar Salvador <osalvador@suse.de>,
Paolo Bonzini <pbonzini@redhat.com>, Peter Xu <peterx@redhat.com>,
Sean Christopherson <seanjc@google.com>,
Shuah Khan <shuah@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Vlastimil Babka <vbabka@suse.cz>,
kvm@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH v4 02/15] userfaultfd: introduce struct mfill_state
Date: Fri, 3 Apr 2026 20:19:48 +0900 [thread overview]
Message-ID: <ac-iVOJZ8B8MLOl4@hyeyoo> (raw)
In-Reply-To: <20260402041156.1377214-3-rppt@kernel.org>
On Thu, Apr 02, 2026 at 07:11:43AM +0300, Mike Rapoport wrote:
> From: "Mike Rapoport (Microsoft)" <rppt@kernel.org>
>
> mfill_atomic() passes a lot of parameters down to its callees.
>
> Aggregate them all into mfill_state structure and pass this structure to
> functions that implement various UFFDIO_ commands.
>
> Tracking the state in a structure will allow moving the code that retries
> copying of data for UFFDIO_COPY into mfill_atomic_pte_copy() and make the
> loop in mfill_atomic() identical for all UFFDIO operations on PTE-mapped
> memory.
>
> The mfill_state definition is deliberately local to mm/userfaultfd.c,
> hence shmem_mfill_atomic_pte() is not updated.
>
> [harry.yoo@oracle.com: properly initialize mfill_state.len to fix
> folio_add_new_anon_rmap() WARN]
> Link: https://lkml.kernel.org/r/abehBY7QakYF9bK4@hyeyoo
> Signed-off-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
> Signed-off-by: Harry Yoo <harry.yoo@oracle.com>
> Acked-by: David Hildenbrand (Arm) <david@kernel.org>
Looks good to me,
Reviewed-by: Harry Yoo (Oracle) <harry@kernel.org>
--
Cheers,
Harry / Hyeonggon
next prev parent reply other threads:[~2026-04-03 11:19 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-02 4:11 [PATCH v4 00/15] mm, kvm: allow uffd support in guest_memfd Mike Rapoport
2026-04-02 4:11 ` [PATCH v4 01/15] userfaultfd: introduce mfill_copy_folio_locked() helper Mike Rapoport
2026-04-02 4:11 ` [PATCH v4 02/15] userfaultfd: introduce struct mfill_state Mike Rapoport
2026-04-03 11:19 ` Harry Yoo (Oracle) [this message]
2026-04-02 4:11 ` [PATCH v4 03/15] userfaultfd: introduce mfill_establish_pmd() helper Mike Rapoport
2026-04-02 4:11 ` [PATCH v4 04/15] userfaultfd: introduce mfill_get_vma() and mfill_put_vma() Mike Rapoport
2026-04-03 12:54 ` Harry Yoo (Oracle)
2026-04-02 4:11 ` [PATCH v4 05/15] userfaultfd: retry copying with locks dropped in mfill_atomic_pte_copy() Mike Rapoport
2026-04-06 1:54 ` Harry Yoo (Oracle)
2026-04-02 4:11 ` [PATCH v4 06/15] userfaultfd: move vma_can_userfault out of line Mike Rapoport
2026-04-02 4:11 ` [PATCH v4 07/15] userfaultfd: introduce vm_uffd_ops Mike Rapoport
2026-04-02 19:32 ` Tal Zussman
2026-04-02 4:11 ` [PATCH v4 08/15] shmem, userfaultfd: use a VMA callback to handle UFFDIO_CONTINUE Mike Rapoport
2026-04-02 4:11 ` [PATCH v4 09/15] userfaultfd: introduce vm_uffd_ops->alloc_folio() Mike Rapoport
2026-04-02 4:11 ` [PATCH v4 10/15] shmem, userfaultfd: implement shmem uffd operations using vm_uffd_ops Mike Rapoport
2026-04-02 4:11 ` [PATCH v4 11/15] userfaultfd: mfill_atomic(): remove retry logic Mike Rapoport
2026-04-02 13:47 ` Mike Rapoport
2026-04-02 18:23 ` Andrew Morton
2026-04-02 4:11 ` [PATCH v4 12/15] mm: generalize handling of userfaults in __do_fault() Mike Rapoport
2026-04-02 4:11 ` [PATCH v4 13/15] KVM: guest_memfd: implement userfaultfd operations Mike Rapoport
2026-04-02 22:05 ` Sean Christopherson
2026-04-02 4:11 ` [PATCH v4 14/15] KVM: selftests: test userfaultfd minor for guest_memfd Mike Rapoport
2026-04-02 4:11 ` [PATCH v4 15/15] KVM: selftests: test userfaultfd missing " Mike Rapoport
2026-04-02 4:35 ` [PATCH v4 00/15] mm, kvm: allow uffd support in guest_memfd Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac-iVOJZ8B8MLOl4@hyeyoo \
--to=harry@kernel.org \
--cc=Liam.Howlett@oracle.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=avagin@google.com \
--cc=axelrasmussen@google.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@kernel.org \
--cc=hughd@google.com \
--cc=jthoughton@google.com \
--cc=kalyazin@amazon.com \
--cc=kvm@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=muchun.song@linux.dev \
--cc=osalvador@suse.de \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=rppt@kernel.org \
--cc=seanjc@google.com \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox