* [PATCH] mm: Fix a comment typo
@ 2020-03-18 3:42 brookxu
2020-03-18 3:59 ` James Bottomley
0 siblings, 1 reply; 3+ messages in thread
From: brookxu @ 2020-03-18 3:42 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-mm, linux-kernel
Signed-off-by: Chunguang Xu <brookxu@tencent.com>
---
mm/page-writeback.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/page-writeback.c b/mm/page-writeback.c
index 2caf780..2acf754 100644
--- a/mm/page-writeback.c
+++ b/mm/page-writeback.c
@@ -1271,7 +1271,7 @@ static void wb_update_dirty_ratelimit(struct dirty_throttle_control *dtc,
*/
/*
- * dirty_ratelimit will follow balanced_dirty_ratelimit iff
+ * dirty_ratelimit will follow balanced_dirty_ratelimit if
* task_ratelimit is on the same side of dirty_ratelimit, too.
* For example, when
* - dirty_ratelimit > balanced_dirty_ratelimit
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mm: Fix a comment typo
2020-03-18 3:42 [PATCH] mm: Fix a comment typo brookxu
@ 2020-03-18 3:59 ` James Bottomley
2020-03-18 4:26 ` brookxu
0 siblings, 1 reply; 3+ messages in thread
From: James Bottomley @ 2020-03-18 3:59 UTC (permalink / raw)
To: brookxu, Andrew Morton; +Cc: linux-mm, linux-kernel
On Wed, 2020-03-18 at 11:42 +0800, brookxu wrote:
> Signed-off-by: Chunguang Xu <brookxu@tencent.com>
>
> ---
> mm/page-writeback.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/page-writeback.c b/mm/page-writeback.c
> index 2caf780..2acf754 100644
> --- a/mm/page-writeback.c
> +++ b/mm/page-writeback.c
> @@ -1271,7 +1271,7 @@ static void wb_update_dirty_ratelimit(struct
> dirty_throttle_control *dtc,
> */
>
> /*
> - * dirty_ratelimit will follow balanced_dirty_ratelimit iff
> + * dirty_ratelimit will follow balanced_dirty_ratelimit if
Are you sure it's a mistake? iff means if and only if which would be
reasonable unless the condition is only implies.
James
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mm: Fix a comment typo
2020-03-18 3:59 ` James Bottomley
@ 2020-03-18 4:26 ` brookxu
0 siblings, 0 replies; 3+ messages in thread
From: brookxu @ 2020-03-18 4:26 UTC (permalink / raw)
To: James Bottomley, Andrew Morton; +Cc: linux-mm, linux-kernel
Thank you very much for your reply, it should be my misunderstanding, thanks again~
James Bottomley wrote on 2020/3/18 11:59:
> On Wed, 2020-03-18 at 11:42 +0800, brookxu wrote:
>> Signed-off-by: Chunguang Xu <brookxu@tencent.com>
>>
>> ---
>> mm/page-writeback.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/mm/page-writeback.c b/mm/page-writeback.c
>> index 2caf780..2acf754 100644
>> --- a/mm/page-writeback.c
>> +++ b/mm/page-writeback.c
>> @@ -1271,7 +1271,7 @@ static void wb_update_dirty_ratelimit(struct
>> dirty_throttle_control *dtc,
>> */
>>
>> /*
>> - * dirty_ratelimit will follow balanced_dirty_ratelimit iff
>> + * dirty_ratelimit will follow balanced_dirty_ratelimit if
> Are you sure it's a mistake? iff means if and only if which would be
> reasonable unless the condition is only implies.
>
> James
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-18 4:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-18 3:42 [PATCH] mm: Fix a comment typo brookxu
2020-03-18 3:59 ` James Bottomley
2020-03-18 4:26 ` brookxu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).