Re: [sj:damon/next 27/30] mm/damon/sysfs-schemes.c:1409:26: error: invalid use of undefined type 'struct mem_cgroup'

Re: [sj:damon/next 27/30] mm/damon/sysfs-schemes.c:1409:26: error: invalid use of undefined type 'struct mem_cgroup'

[SeongJae Park]

Hi Robot,


Thank you always for the report!

On Sat, 26 Nov 2022 18:26:31 +0800 kernel test robot <lkp@intel.com> wrote:

> [-- Attachment #1: Type: text/plain, Size: 1887 bytes --]
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/sj/linux.git damon/next
> head:   61742c95d33e74cf64b7d5b8e51f12adef425b3e
> commit: d768680bbe8153f2b79382bd2cd5d6734b6f5c42 [27/30] mm/damon/sysfs-schemes: implement scheme filters
> config: xtensa-randconfig-r014-20221124
> compiler: xtensa-linux-gcc (GCC) 12.1.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://git.kernel.org/pub/scm/linux/kernel/git/sj/linux.git/commit/?id=d768680bbe8153f2b79382bd2cd5d6734b6f5c42
>         git remote add sj https://git.kernel.org/pub/scm/linux/kernel/git/sj/linux.git
>         git fetch --no-tags sj damon/next
>         git checkout d768680bbe8153f2b79382bd2cd5d6734b6f5c42
>         # save the config file
>         mkdir build_dir && cp config build_dir/.config
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=xtensa SHELL=/bin/bash mm/damon/

I couldn't reproduce this issue as the last command above gives me below error.

    $ COMPILER_INSTALL_PATH=$HOME/0day make.cross W=1 O=../build_test ARCH=xtensa SHELL=/bin/bash mm/damon/
    Compiler will be installed in /home/xxxx/0day
    Please update: libc6
    ldd /home/xxxx/0day/gcc-12.1.0-nolibc/xtensa-linux/bin/xtensa-linux-gcc
    /home/xxxx/0day/gcc-12.1.0-nolibc/xtensa-linux/bin/xtensa-linux-gcc: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.32' not found (required by /home/xxxx/0day/gcc-12.1.0-nolibc/xtensa-linux/bin/xtensa-linux-gcc)
    /home/xxxx/0day/gcc-12.1.0-nolibc/xtensa-linux/bin/xtensa-linux-gcc: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.33' not found (required by /home/xxxx/0day/gcc-12.1.0-nolibc/xtensa-linux/bin/xtensa-linux-gcc)
    setup_crosstool failed

> 
> If you fix the issue, kindly add following tag where applicable
> | Reported-by: kernel test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>):
> 
>    mm/damon/sysfs-schemes.c: In function 'damon_sysfs_memcg_path_eq':
> >> mm/damon/sysfs-schemes.c:1409:26: error: invalid use of undefined type 'struct mem_cgroup'
>     1409 |         cgroup_path(memcg->css.cgroup, memcg_path_buf, PATH_MAX);
>          |                          ^~

Nevertheless, seems the issue was due to missed inclusion of memcontrol.h,
which defines the 'struct mem_cgroup'.  Fixed and pushed[1].

[1] https://git.kernel.org/pub/scm/linux/kernel/git/sj/linux.git/commit/?h=damon/next&id=7eaaa606788b0766ece3c105fdcf963aba8511ef


Thanks,
SJ

[...]

Re: [sj:damon/next 27/30] mm/damon/sysfs-schemes.c:1409:26: error: invalid use of undefined type 'struct mem_cgroup'

[Chen, Rong A]

On 11/28/2022 2:52 AM, SeongJae Park wrote:
> Hi Robot,
> 
> 
> Thank you always for the report!
> 
> On Sat, 26 Nov 2022 18:26:31 +0800 kernel test robot <lkp@intel.com> wrote:
> 
>> [-- Attachment #1: Type: text/plain, Size: 1887 bytes --]
>>
>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/sj/linux.git damon/next
>> head:   61742c95d33e74cf64b7d5b8e51f12adef425b3e
>> commit: d768680bbe8153f2b79382bd2cd5d6734b6f5c42 [27/30] mm/damon/sysfs-schemes: implement scheme filters
>> config: xtensa-randconfig-r014-20221124
>> compiler: xtensa-linux-gcc (GCC) 12.1.0
>> reproduce (this is a W=1 build):
>>          wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>>          chmod +x ~/bin/make.cross
>>          # https://git.kernel.org/pub/scm/linux/kernel/git/sj/linux.git/commit/?id=d768680bbe8153f2b79382bd2cd5d6734b6f5c42
>>          git remote add sj https://git.kernel.org/pub/scm/linux/kernel/git/sj/linux.git
>>          git fetch --no-tags sj damon/next
>>          git checkout d768680bbe8153f2b79382bd2cd5d6734b6f5c42
>>          # save the config file
>>          mkdir build_dir && cp config build_dir/.config
>>          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=xtensa SHELL=/bin/bash mm/damon/
> 
> I couldn't reproduce this issue as the last command above gives me below error.
> 
>      $ COMPILER_INSTALL_PATH=$HOME/0day make.cross W=1 O=../build_test ARCH=xtensa SHELL=/bin/bash mm/damon/
>      Compiler will be installed in /home/xxxx/0day
>      Please update: libc6

Hi SeongJae,

It may be due to the old version of libc6 in your environment,
could you update it?

Best Regards,
Rong Chen


>      ldd /home/xxxx/0day/gcc-12.1.0-nolibc/xtensa-linux/bin/xtensa-linux-gcc
>      /home/xxxx/0day/gcc-12.1.0-nolibc/xtensa-linux/bin/xtensa-linux-gcc: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.32' not found (required by /home/xxxx/0day/gcc-12.1.0-nolibc/xtensa-linux/bin/xtensa-linux-gcc)
>      /home/xxxx/0day/gcc-12.1.0-nolibc/xtensa-linux/bin/xtensa-linux-gcc: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.33' not found (required by /home/xxxx/0day/gcc-12.1.0-nolibc/xtensa-linux/bin/xtensa-linux-gcc)
>      setup_crosstool failed
> 
>>
>> If you fix the issue, kindly add following tag where applicable
>> | Reported-by: kernel test robot <lkp@intel.com>
>>
>> All errors (new ones prefixed by >>):
>>
>>     mm/damon/sysfs-schemes.c: In function 'damon_sysfs_memcg_path_eq':
>>>> mm/damon/sysfs-schemes.c:1409:26: error: invalid use of undefined type 'struct mem_cgroup'
>>      1409 |         cgroup_path(memcg->css.cgroup, memcg_path_buf, PATH_MAX);
>>           |                          ^~
> 
> Nevertheless, seems the issue was due to missed inclusion of memcontrol.h,
> which defines the 'struct mem_cgroup'.  Fixed and pushed[1].
> 
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/sj/linux.git/commit/?h=damon/next&id=7eaaa606788b0766ece3c105fdcf963aba8511ef
> 
> 
> Thanks,
> SJ
> 
> [...]
>