From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC10CC77B7C for ; Wed, 25 Jun 2025 23:57:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 89E0B6B0096; Wed, 25 Jun 2025 19:57:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 875566B00A5; Wed, 25 Jun 2025 19:57:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 78B416B00A6; Wed, 25 Jun 2025 19:57:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 66D2F6B0096 for ; Wed, 25 Jun 2025 19:57:41 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C346580804 for ; Wed, 25 Jun 2025 23:57:40 +0000 (UTC) X-FDA: 83595587880.03.11BC58E Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by imf09.hostedemail.com (Postfix) with ESMTP id 812EC140003 for ; Wed, 25 Jun 2025 23:57:38 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b="k/KCcCyG" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750895859; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=c+rrrcFg6u66Hnzut5Z/WroFwVDDLyZyn8hntHme06U=; b=gRnUBSaOpcsaqX8cxjkfI9XhEcRXAMst2iY83Y+Mx844/HhOHj4wYHdtICb0jDo/gUtcHK A4pPJn83iZ7IU/d7lkFHLkeRf1XfJWdl9v2jaFRx9M4lcmA+1uliYOfaF1+7uRRY7rNUgd LHDZyRUebJopnrpleEuauJjCQLIa8VA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750895859; a=rsa-sha256; cv=none; b=aBJAmsblUP10Y9VP7k84/tfJNmBlze5B9noBVlSswY+hvGZ9eBRlhosA4NcaS3SHOprZVl n+XoC2qbWbscZpTmcp1/Vq+Ss4T1rLt7tSarKaY2a8VBasp85iHzc6auZ2PtGd2mNCXZ3a 26NprdEj/+5F89aj3Ce8sIgOFLzT2Mg= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b="k/KCcCyG"; spf=none (imf09.hostedemail.com: domain of rdunlap@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=rdunlap@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :In-Reply-To:From:References:To:Subject:MIME-Version:Date:Message-ID:Sender: Reply-To:Cc:Content-ID:Content-Description; bh=c+rrrcFg6u66Hnzut5Z/WroFwVDDLyZyn8hntHme06U=; b=k/KCcCyGyqyAaxFb2ZKA9rh+VF Tw6VTBokl/pf0DZqNobcHM6gtVorsZFwjF1thuG8hsHpYkkudmmJQG7E68zAW5xoaM4FTkmbKJE2x O9iRP4tpW1WALUETZlhq3OfEb/qnSTosMFfwVxhZmeTX6c+Z7aA1j+BjwzIegrJUroKPvl+XDbjec 7uAUmnu7eIXy0AOot45E+8K+/ItaML7t/oFzCCNLc5L2DH6fSZw2wwRtScDNRq2Vdxs3Yw5RQiyBf XBS/At592eesDjQ0OjCaWqPi4H4KI6ntoWqNb46K4fPxwU/iHzZ5XEqTDG6ZtNeDN3uHJPjmae4n+ RjiP4REg==; Received: from [50.53.25.54] (helo=[192.168.254.17]) by desiato.infradead.org with esmtpsa (Exim 4.98.2 #2 (Red Hat Linux)) id 1uUZzD-000000060Zf-0xuo; Wed, 25 Jun 2025 23:57:03 +0000 Message-ID: Date: Wed, 25 Jun 2025 16:56:48 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 03/32] kho: warn if KHO is disabled due to an error To: Pasha Tatashin , pratyush@kernel.org, jasonmiu@google.com, graf@amazon.com, changyuanl@google.com, rppt@kernel.org, dmatlack@google.com, rientjes@google.com, corbet@lwn.net, ilpo.jarvinen@linux.intel.com, kanie@linux.alibaba.com, ojeda@kernel.org, aliceryhl@google.com, masahiroy@kernel.org, akpm@linux-foundation.org, tj@kernel.org, yoann.congal@smile.fr, mmaurer@google.com, roman.gushchin@linux.dev, chenridong@huawei.com, axboe@kernel.dk, mark.rutland@arm.com, jannh@google.com, vincent.guittot@linaro.org, hannes@cmpxchg.org, dan.j.williams@intel.com, david@redhat.com, joel.granados@kernel.org, rostedt@goodmis.org, anna.schumaker@oracle.com, song@kernel.org, zhangguopeng@kylinos.cn, linux@weissschuh.net, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, gregkh@linuxfoundation.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, rafael@kernel.org, dakr@kernel.org, bartosz.golaszewski@linaro.org, cw00.choi@samsung.com, myungjoo.ham@samsung.com, yesanishhere@gmail.com, Jonathan.Cameron@huawei.com, quic_zijuhu@quicinc.com, aleksander.lobakin@intel.com, ira.weiny@intel.com, andriy.shevchenko@linux.intel.com, leon@kernel.org, lukas@wunner.de, bhelgaas@google.com, wagi@kernel.org, djeffery@redhat.com, stuart.w.hayes@gmail.com, ptyadav@amazon.de, lennart@poettering.net, brauner@kernel.org, linux-api@vger.kernel.org, linux-fsdevel@vger.kernel.org References: <20250625231838.1897085-1-pasha.tatashin@soleen.com> <20250625231838.1897085-4-pasha.tatashin@soleen.com> Content-Language: en-US From: Randy Dunlap In-Reply-To: <20250625231838.1897085-4-pasha.tatashin@soleen.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 812EC140003 X-Stat-Signature: aqdhpo84jjabii7tch8tdgu5sorfobon X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1750895858-979091 X-HE-Meta: U2FsdGVkX18OXdcnjEB3cMUOP+Icv5nEqFJHiSZy7BcyhuYJQ2zrSS0bk5koBbiSzOQpG6WfFg53ub5vTyL0Mhr/FBl246nxq6eqNz8B79XySk4HUmzjxnqQ/oHX6uvWn1m2AnBu+bXbYEmZHuNa8DKuUL9T2gLp+Zgt1JcEAg8/qouN3r0c1GtEr+Ba8z4DHVnMVO6mjWQoJwQK8TiM8QYo+WY47qyhhJ7gkJ8yAI0aW9/aFcL6gfZN3VgZvibYbZJbicJrNj6d5ww7CHlIwvif9Jz/fVXtcpehw505tMPi8fD6wN9lvEWoueYCRNfboi/1WkQnaCbUYUU6IxGjeabEnVLYY8mVL44RPXINuUdLCV2n1i7/l++ahVbOKhYkotSNMKSmMwszpvggnhDaaLB0tuf2HAvln85rVipy3Utidn8B804sNjdxf6ErpW3hJ/XNdhuTNjH8ImUIDovUvflO6PIrr08vfdpLW16ZVCBu4T6TJBeZaxLTRVD5+yJuvUNAa6hdYqiAJH0X+f409+bQafNb4YZxtZRoZFRKskWuSfxIw4+ow/yDpSwDqGZbScGyvmT+nmPsheHwyYgS7k14e2yb2huNoyTk57iG9ZDCDjzlsurOwayuJBS6WZKgB5ob9ATIkbDAvWCFuUFbwaPacCIQ/k5LMGgcGjVidjpwl2eMm25YIo/FtjoGMtSBkIuzde50SoPuXNPAM0mYA3IEVSjHyQIYljL3OkGpfxVqf7aPyUY6LF7TKZXO2swukHLt7bAiE10uL1wTdxfs2oEebzZK2IGrbmV0KBN2DA1S5Z72tHmhGDHgNDrc/4tjgJmSta3JutXvFwWYqACNDdk9Pv+kRDvk/al+Ie2f1qR5cU/3HJDgMSwK/IZgD7WHqzeThz2awpExvK0YjrW7EauAAzC6Rm5THPpOypsUF6m3n7VGY60xsbhOJI8oqln38MKsBe4iL8iv1bWaHhN 7rn5vZ5k 7XtNVHNrYm6eg2WLP7HPDsv9R8r02iHgGBvt4TnYCnkfemNBUL3qMy7/neq72TICvqvkxXWd/32GSvuHciXLrDVBrxwsqfU9QuBEOW8ugZ9VQanuQTmJKVU7QKSFkfc955kC9fwpgU/GEeqOXd3OZgkrogYN75pdz61g9Ju6JCaoY6SAAZ4yYsr6RfJRU9aXpNMaTpdWTQVpk+I5yn5sedTBsuhHpRmQYTJM89G2IxDbqhdefL9M4efYshgb8+5tri4IBwv2YSHvikiCnPp3LqjVhzlvqPiLtj9bzPysyh5OabJcDImVmBbvZLB0aaQXdQ2QzaFqZk8fCBWGx4cuI/MH8Jgt8HZ3j650mG/sruEWZb+Q1BkR3iGhYdAP9M/wONYHI X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/25/25 4:17 PM, Pasha Tatashin wrote: > During boot scratch area is allocated based on command line > parameters or auto calculated. However, scratch area may fail > to allocate, and in that case KHO is disabled. Currently, > no warning is printed that KHO is disabled, which makes it > confusing for the end user to figure out why KHO is not > available. Add the missing warning message. Are users even going to know what "KHO" means in the warning message? > > Signed-off-by: Pasha Tatashin > --- > kernel/kexec_handover.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/kernel/kexec_handover.c b/kernel/kexec_handover.c > index 1ff6b242f98c..069d5890841c 100644 > --- a/kernel/kexec_handover.c > +++ b/kernel/kexec_handover.c > @@ -565,6 +565,7 @@ static void __init kho_reserve_scratch(void) > err_free_scratch_desc: > memblock_free(kho_scratch, kho_scratch_cnt * sizeof(*kho_scratch)); > err_disable_kho: > + pr_warn("Failed to reserve scratch area, disabling KHO\n"); > kho_enable = false; > } > -- ~Randy