From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D075C83038 for ; Tue, 1 Jul 2025 19:34:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EBCE26B00B9; Tue, 1 Jul 2025 15:34:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E9A416B00BA; Tue, 1 Jul 2025 15:34:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D83206B00BB; Tue, 1 Jul 2025 15:34:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C81626B00B9 for ; Tue, 1 Jul 2025 15:34:51 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 68E1580232 for ; Tue, 1 Jul 2025 19:34:51 +0000 (UTC) X-FDA: 83616698382.04.04430B3 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf24.hostedemail.com (Postfix) with ESMTP id 03EEC180008 for ; Tue, 1 Jul 2025 19:34:48 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fMMs7P47; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751398489; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gw1ZFU7fseKrRoTgl7UAAoDGCdFd91K7Vdf4y+yHx50=; b=RGMH/cIkyhG5QPurrOuA5BdAPIBoEicPnQF9eRN2Tf6+WpIUR7PufJcr5TeGJ+ltKzpM30 bpF0ol8i2Cbz6JVSYI50FcmWEo7gERXJhJES1Mjdlz9XoIi0423KSHxjr+Gxf67QdZv5+6 mQ8B1tWSZyuAe0XjCz9OhxKXfiLbJuM= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fMMs7P47; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751398489; a=rsa-sha256; cv=none; b=FIcPHapt9TxJScNdRhdweT8i9bo8tL8roCasdwTmp94FRcO6/rlOjP5JPSYmuCJMLRBlQP 3FqGYN4tko7HyVdqiowARExOx5kwDPacrF1n93FgrL/g4Kh4XW/cSiIwfGn9ey3oUo7gnj PZLynUR222HAH0tbsLu/xvS1oCfxf1Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751398488; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=gw1ZFU7fseKrRoTgl7UAAoDGCdFd91K7Vdf4y+yHx50=; b=fMMs7P47Kf+15xnAbaFPRW79Dkjfiz/TqMXDJqJ+oD1qitaega8a81aiotapjiEF6HN+0B s4i7JcQ777y65VOoj2xGz58bM40fsx3zNtUhDpW4pcgPWiCdzBxZew8dOD2g6gWxksiyN3 E/5b4IvNXtyGtjRibx3o9Spr8aqH9BY= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-648-2882KjeFNGi4LROlwJQ-9Q-1; Tue, 01 Jul 2025 15:34:47 -0400 X-MC-Unique: 2882KjeFNGi4LROlwJQ-9Q-1 X-Mimecast-MFC-AGG-ID: 2882KjeFNGi4LROlwJQ-9Q_1751398486 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4532ff43376so33646655e9.3 for ; Tue, 01 Jul 2025 12:34:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751398486; x=1752003286; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=gw1ZFU7fseKrRoTgl7UAAoDGCdFd91K7Vdf4y+yHx50=; b=M1tKTXKiLlAdfkDNgvhU01fl9a8LPrvkdkOF1cBtMFkAedVX6qWV3IY1NwzHJywI51 R7z+FzDHMwBumiLEc3EFW2YAw0jdPISeJB4iC6PbTtLDSX+2nC4HmUHhzaD+yeXnGMrl IVpxajsTbvIl7fVZnpBlsjVqI91+YltLxdgGf8Sm0RKi3WNN6VdCIdzt2UPqB2SDOC9B JHWRkyoVb4kxPZtZOhZ8tLMNznTiqHNTDCA1W/BLfQI+v6n1XYquDJCoPcF5EBKF+EYd mUzYZBzD7xLgDItAWVOlHH2VDE0KnR3I79zqYRGfpTBsyGcJzGakjxLrZVXR43gfTg2q iX1A== X-Forwarded-Encrypted: i=1; AJvYcCWLgLQt6Un0+9f3faKSZriX5UPUE04SZa/2W+UNezL8bOOqL4FePaF3MOVEBPFWlfb6xOIjCRSFtw==@kvack.org X-Gm-Message-State: AOJu0YxCkusnnODbe3cH0emUAK6APvvqDYWnamSm36IgpW3oUtroNg1W RpKPNMnPFp3YX4UDpqhwvi5ynLsHj18x3rk1lmY6Kkucvhjt7Uzl8NH4pUxMgvgOtdqcvkCz/sK bDfNna2fGXqxSvZQZsBSeuvMLuHofB7ZZvf2ua7P1jzgWdZK8sAL5 X-Gm-Gg: ASbGnctDJkQ8GD43w4KwiqNYEmE/rs4/O31UFtxfv+avcEVgnW3x3P0ZjbbquGpxKUu xMQTMuETSsxk3qMzlRly1ctrbCCmnquLEzSYSV9/qZ4XfD/PDT+dHf6yz6oBnrYFRQN597UQv1S xmkdaP3vIDTS1/304TmksOykBSAbHGc4Am5WlWHEXZEVylmE38oH0+CIyBsEzLcGv6b+iScXvbk YAm7Zkmd91uMd6X6jHOmwYnUUJ16aWLrHd8vVIZLYS5Ile5N+Bu6WlmTnn/J8B5Utq02CrM6f1P YlM8cPI7nPpXa36jBB8svxEHKj+0rlievjA/eQxuxWLRkm78ZYWLwHaeuDW6Ol2noOVu3z+yhCf 4GPsAKXjYXybr4rn425jLpdX47dQ4zD7S0X9cBxwmpF1z1xLq/g== X-Received: by 2002:a05:600c:1549:b0:453:6146:1172 with SMTP id 5b1f17b1804b1-454a36d8d1amr4351725e9.3.1751398485615; Tue, 01 Jul 2025 12:34:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGhEuTg4M0PQbefUA1jZ0F5TAuHLHbTJ/BFBL6Gk20G74uE8iX4U0pj6is7luyXAnqTfNAkbQ== X-Received: by 2002:a05:600c:1549:b0:453:6146:1172 with SMTP id 5b1f17b1804b1-454a36d8d1amr4351025e9.3.1751398485099; Tue, 01 Jul 2025 12:34:45 -0700 (PDT) Received: from ?IPV6:2003:d8:2f18:7500:202e:b0f1:76d6:f9af? (p200300d82f187500202eb0f176d6f9af.dip0.t-ipconnect.de. [2003:d8:2f18:7500:202e:b0f1:76d6:f9af]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-453823c57d7sm215278035e9.40.2025.07.01.12.34.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Jul 2025 12:34:44 -0700 (PDT) Message-ID: Date: Tue, 1 Jul 2025 21:34:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 23/29] mm/page-alloc: remove PageMappingFlags() To: Lorenzo Stoakes Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux.dev, linux-fsdevel@vger.kernel.org, Andrew Morton , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Jerrin Shaji George , Arnd Bergmann , Greg Kroah-Hartman , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Alexander Viro , Christian Brauner , Jan Kara , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , "Matthew Wilcox (Oracle)" , Minchan Kim , Sergey Senozhatsky , Brendan Jackman , Johannes Weiner , Jason Gunthorpe , John Hubbard , Peter Xu , Xu Xin , Chengming Zhou , Miaohe Lin , Naoya Horiguchi , Oscar Salvador , Rik van Riel , Harry Yoo , Qi Zheng , Shakeel Butt References: <20250630130011.330477-1-david@redhat.com> <20250630130011.330477-24-david@redhat.com> <8ff24777-988a-4d1d-be97-e7184abfa998@lucifer.local> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <8ff24777-988a-4d1d-be97-e7184abfa998@lucifer.local> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: HHCKnKt2fG47lwC6kMer2PfAp7sHobRY_HjKJsLmPmE_1751398486 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: ej9qjxmq8ft8kric8s4wkx6rdk48b5p3 X-Rspamd-Queue-Id: 03EEC180008 X-Rspamd-Server: rspam11 X-Rspam-User: X-HE-Tag: 1751398488-518972 X-HE-Meta: U2FsdGVkX1+/vAnG6UtBf1t3xUVl4sPf8GtE3PEHQ5h3A+iSJ2XUzWxWAoaGo8tliSfixLNlAmVVPUHod53Zg89D6/3SVqim74wzEC2se02kI5AFFICcWCqJe+DWXcblWXIW4IDztSmJmZEbSh0BBNJwj/uqmIjxPqjE5J+Latn+GG30dmr16J/PhGDXWicCcZxYk1ATGCU2xvC3h6iPr8bYS/IEwUmrHovOVygRz8kZ21SymxaLc88F5DYLabL7w7A5vO/y2YAP6p/lX2+Fbu9ckqe4xWzPH8etAZG0ovr5yF7Y7qqOJPIqxTDAnL6mM+GF5mmyp9fQjjbalhACY/AGNaHaeafaiwylouoP4pGTlhOc9bSwbSJxrcg1pi+7fY/8cSKaLR78hPFfuM35x7AOwj3TvdN3SrHqXqkT3eTKfF9UQ7jNJlXy5wr3wurAppKLbQFQqZFWTetWuih8l2hbOiUX8TrdZJXL1JZf28pudKV2R7yEINXPJaFs1GPMnXS/jsjmfA1UaobtA3vfLujWYGsktfM1XsApN6ELtStwId9wlHipr5a0D0Y6hYLalqhVWM/W+Dj9wJNmW7I51tTfE6hO8kajkb6Y64rSiQCV6aptFZozkDRJrI3cmnKDdLimu1tSDxc55wfxMHDj7dkBpedjjONjCWyQ5UVQJ4sylRMXtGoLfJO8z+iPfwAx5BKCT37r8dcxCCK/EPB76wgHWOdgiDqv0x+iMPMbVYg0kMzNIonpyen0C6Go57rEnymrEV+L15AhuSiwd2b2FRQfgUzGUG/4yz+gnrIHUbQFxwWKkcFYWbOmF6nlqQsuPlzK+AGYtigCawPK+b0UE1SdQ95nT2ZX6gU/Q6uhkHBgzIgdPif6sa6KKigpt5oOUp5Pq5WEoxUQSo+SBxmu92SoZ2wE9g4rlZsfhQMJOK1yiysaCNz4SeINhHwKSIUYpzDdDAQkCeWNmsWsVdt sdDNRahU mGtbW0DO+mWODybQnxKXj+vhgKCsuITAk4di8ZRVCT+RGQtwdxKV67Yy+rk1ObgOMFh0ur4zBrGX4s+oVtrmavVkXZRVsjdQVVN0m/1vTK5zhGjkc9MTYMXb5y/DcTS2qc0291EOuwrbSpgasYhiDN39S9ysnxlq+j85CBctf0o+U4wYT5ShF84xmSulFTSiEZNEdLxcWjNOa7LQkjtF1ypDZa3IYgpTEwrMoy2g3kz+cSTznEfNyrd5IoNBs5Pb61uzkLhXqTzzVpAhHIwYtvtnHcvO6fNcnYp918sND/GLsf7/uCNxQ1Qa4szcoW7nrHZWIGgmCeobQKCbWJnobOjow501hhtoTojT2TOXtjvpFwrDX7lcUFuIeVzTjr9FdZkUEnlfbPnqeeYyVCd43ROA/99PmtmIncPQJb1j7X1tAM/FKdzXM0VH8zhMtj9fTnK2+MUebt7yHMoDdtFL+QMs8M68ENS1FzT2YJLvYuz8/SkykC8FfoxXUJFL8UmIDGQrAM/a0e5djSfUjbuyK6aKYKtsfPaZ6rIL8pVBjdHrI0M0h1O/3kQg1Nvm2rFTjWszC X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 01.07.25 15:02, Lorenzo Stoakes wrote: > On Mon, Jun 30, 2025 at 03:00:04PM +0200, David Hildenbrand wrote: >> We can now simply check for PageAnon() and remove PageMappingFlags(). >> >> ... and while at it, use the folio instead and operate on >> folio->mapping. > > Probably worth mentioning to be super crystal clear that this is because > now it's either an anon folio or a KSM folio, both of which set the > FOLIO_MAPPING_ANON flag. "As PageMappingFlags() now only indicates anon (incl. ksm) folios, we can now simply check for PageAnon() and remove PageMappingFlags()." > > I wonder if there's other places that could be fixed up similarly that do > folio_test_anon() || folio_test_ksm() or equivalent? I think you spotted the one in patch #25 :) I looked for others while crafting this patch, but there might be more hiding that I didn't catch. > >> >> Reviewed-by: Zi Yan >> Signed-off-by: David Hildenbrand > > LGTM, so: > > Reviewed-by: Lorenzo Stoakes > Thanks! -- Cheers, David / dhildenb