Re: [PATCH 01 of 12] Core of mmu notifiers

Christoph Lameter
2008-04-22T20:19:29Z

Thanks for adding most of my enhancements. But

1. There is no real need for invalidate_page(). Can be done with
invalidate_start/end. Needlessly complicates the API. One
of the objections by Andrew was that there mere multiple
callbacks that perform similar functions.

2. The locks that are used are later changed to semaphores. This is
f.e. true for mm_lock / mm_unlock. The diffs will be smaller if the
lock conversion is done first and then mm_lock is introduced. The
way the patches are structured means that reviewers cannot review the
final version of mm_lock etc etc. The lock conversion needs to come
first.

3. As noted by Eric and also contained in private post from yesterday by
me: The cmp function needs to retrieve the value before
doing comparisons which is not done for the == of a and b.