Re: [PATCH 04 of 12] Moves all mmu notifier methods outside the PT lock (first and not last

Avi Kivity
2008-04-23T21:05:45Z

Robin Holt wrote:
>> an hurry like we are, we can't progress without this. Infact we can
>>
>
> SGI is under an equally strict timeline. We really needed the sleeping
> version into 2.6.26. We may still be able to get this accepted by
> vendor distros if we make 2.6.27.
>

The difference is that the non-sleeping variant can be shown not to
affect stability or performance, even if configed in, as long as its not
used. The sleeping variant will raise performance and stability concerns.

I have zero objections to sleeping mmu notifiers; I only object to tying
the schedules of the two together.

--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.