Re: [PATCH 10 of 12] Convert mm_lock to use semaphores after i_mmap_lock and anon_vma_lock

Christoph Lameter
2008-04-22T23:19:06Z

On Wed, 23 Apr 2008, Andrea Arcangeli wrote:

> The right patch ordering isn't necessarily the one that reduces the
> total number of lines in the patchsets. The mmu-notifier-core is
> already converged and can go in. The rest isn't converged at
> all... nearly nobody commented on the other part (the few comments so
> far were negative), so there's no good reason to delay indefinitely
> what is already converged, given it's already feature complete for
> certain users of the code. My patch ordering looks more natural to
> me. What is finished goes in, the rest is orthogonal anyway.

I would not want to review code that is later reverted or essentially
changed in later patches. I only review your patches because we have a
high interest in the patch. I suspect that others will be more willing to
review this material if it would be done the right way.

If you cannot produce an easily reviewable and properly formatted patchset
that follows conventions then I will have to do it because we really need
to get this merged.