From: Matthew Wilcox <willy@infradead.org>
To: "David Hildenbrand (Arm)" <david@kernel.org>
Cc: Shivank Garg <shivankg@amd.com>,
Andrew Morton <akpm@linux-foundation.org>,
Zi Yan <ziy@nvidia.com>, Matthew Brost <matthew.brost@intel.com>,
Joshua Hahn <joshua.hahnjy@gmail.com>,
Rakie Kim <rakie.kim@sk.com>, Byungchul Park <byungchul@sk.com>,
Gregory Price <gourry@gourry.net>,
Ying Huang <ying.huang@linux.alibaba.com>,
Alistair Popple <apopple@nvidia.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/migrate: rename PAGE_ migration flags to FOLIO_MF_
Date: Mon, 23 Mar 2026 18:57:31 +0000 [thread overview]
Message-ID: <acGNG1T-4UBdvgYB@casper.infradead.org> (raw)
In-Reply-To: <a6f19c86-4c6a-48c8-9dc6-26f66bb6dd88@kernel.org>
On Mon, Mar 23, 2026 at 04:36:38PM +0100, David Hildenbrand (Arm) wrote:
> On 3/23/26 15:46, Matthew Wilcox wrote:
> >> if (folio_test_mlocked(src))
> >> - old_page_state |= PAGE_WAS_MLOCKED;
> >> + old_folio_state |= FOLIO_MF_WAS_MLOCKED;
> >
> > I mean, this doesn't make sense any more. PAGE_WAS_MLOCKED is a
> > sentence that means something. FOLIO_MF_WAS_MLOCKED doesn't ... unless
> > you imagine Samuel L Jackson saying it ...
>
> :)
>
> PAGE_WAS_MLOCKED was suboptimal given that the names overlap with things
> like PAGE_SHARED or even PAGE_IS_PRESENT.
PAGE_SHARED (and friends) are misnamed because really they're PTE flags,
not page flags. Then PAGE_IS_* form a namespace for pagemap, which I
think is fine. These are PAGE_WAS, so a distinct namespace already.
> So using some prefix to indicate that these flag belong logically
> together makes sense. Even if it's not a beautiful sentence.
FOLIO_WAS_ seems like a fine namespace. Especially since it's local to
this file.
next prev parent reply other threads:[~2026-03-23 18:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 14:19 [PATCH] mm/migrate: rename PAGE_ migration flags to FOLIO_MF_ Shivank Garg
2026-03-23 14:46 ` Matthew Wilcox
2026-03-23 15:36 ` David Hildenbrand (Arm)
2026-03-23 18:57 ` Matthew Wilcox [this message]
2026-03-23 19:21 ` David Hildenbrand (Arm)
2026-03-24 5:04 ` Garg, Shivank
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acGNG1T-4UBdvgYB@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=byungchul@sk.com \
--cc=david@kernel.org \
--cc=gourry@gourry.net \
--cc=joshua.hahnjy@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=matthew.brost@intel.com \
--cc=rakie.kim@sk.com \
--cc=shivankg@amd.com \
--cc=ying.huang@linux.alibaba.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox