From: Christoph Hellwig <hch@infradead.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: Tal Zussman <tz2294@columbia.edu>, Jens Axboe <axboe@kernel.dk>,
Christian Brauner <brauner@kernel.org>,
"Darrick J. Wong" <djwong@kernel.org>,
Carlos Maiolino <cem@kernel.org>,
Alexander Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.cz>,
Christoph Hellwig <hch@infradead.org>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH RFC v4 2/3] iomap: use BIO_COMPLETE_IN_TASK for dropbehind writeback
Date: Thu, 26 Mar 2026 23:03:22 -0700 [thread overview]
Message-ID: <acYdqqe6sahnfH7c@infradead.org> (raw)
In-Reply-To: <acRDyJrkJhnHHMSe@casper.infradead.org>
On Wed, Mar 25, 2026 at 08:21:28PM +0000, Matthew Wilcox wrote:
> > + if (ioend_flags & IOMAP_IOEND_DONTCACHE)
> > + bio_set_flag(bio, BIO_COMPLETE_IN_TASK);
> > wbc_init_bio(wpc->wbc, bio);
> > wpc->nr_folios = 0;
> > return iomap_init_ioend(wpc->inode, bio, pos, ioend_flags);
>
> Can't we delete IOMAP_IOEND_DONTCACHE, and just do:
>
> if (folio_test_dropbehind(folio))
> bio_set_flag(&ioend->io_bio, BIO_COMPLETE_IN_TASK);
>
> It'd need to move down a few lines in iomap_add_to_ioend() to after
> bio_add_folio() succeeds.
Yes, that sounds sensible.
next prev parent reply other threads:[~2026-03-27 6:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-25 18:42 [PATCH RFC v4 0/3] block: enable RWF_DONTCACHE for block devices Tal Zussman
2026-03-25 18:43 ` [PATCH RFC v4 1/3] block: add BIO_COMPLETE_IN_TASK for task-context completion Tal Zussman
2026-03-25 19:54 ` Matthew Wilcox
2026-03-25 20:14 ` Jens Axboe
2026-03-25 20:26 ` Dave Chinner
2026-03-25 20:39 ` Matthew Wilcox
2026-03-26 2:44 ` Dave Chinner
2026-03-25 21:03 ` Bart Van Assche
2026-03-26 3:18 ` Dave Chinner
2026-03-27 6:01 ` Christoph Hellwig
2026-03-25 18:43 ` [PATCH RFC v4 2/3] iomap: use BIO_COMPLETE_IN_TASK for dropbehind writeback Tal Zussman
2026-03-25 20:21 ` Matthew Wilcox
2026-03-27 6:03 ` Christoph Hellwig [this message]
2026-03-25 20:34 ` Dave Chinner
2026-03-27 6:08 ` Christoph Hellwig
2026-03-27 6:24 ` Gao Xiang
2026-03-27 6:27 ` Christoph Hellwig
2026-03-27 6:45 ` Gao Xiang
2026-03-25 18:43 ` [PATCH RFC v4 3/3] block: enable RWF_DONTCACHE for block devices Tal Zussman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acYdqqe6sahnfH7c@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=tz2294@columbia.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox