From: Dmitry Ilvokhin <d@ilvokhin.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Vlastimil Babka <vbabka@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>,
Brendan Jackman <jackmanb@google.com>,
Johannes Weiner <hannes@cmpxchg.org>, Zi Yan <ziy@nvidia.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
kernel-team@meta.com, Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH v2 0/8] mm: use spinlock guards for zone lock
Date: Mon, 30 Mar 2026 16:47:58 +0000 [thread overview]
Message-ID: <acqpPkXKnyB4Oqci@shell.ilvokhin.com> (raw)
In-Reply-To: <20260327131120.591770a2aa63abbaa7bbeadc@linux-foundation.org>
On Fri, Mar 27, 2026 at 01:11:20PM -0700, Andrew Morton wrote:
> On Fri, 27 Mar 2026 16:14:40 +0000 Dmitry Ilvokhin <d@ilvokhin.com> wrote:
>
> > This series uses spinlock guard for zone lock across several mm
> > functions to replace explicit lock/unlock patterns with automatic
> > scope-based cleanup.
> >
> > This simplifies the control flow by removing 'flags' variables, goto
> > labels, and redundant unlock calls.
> >
> > Patches are ordered by decreasing value. The first six patches simplify
> > the control flow by removing gotos, multiple unlock paths, or 'ret'
> > variables. The last two are simpler lock/unlock pair conversions that
> > only remove 'flags' and can be dropped if considered unnecessary churn.
>
> Thanks, you've been busy.
>
> I'm not wanting to move new, non-fix, non-speedup things into mm.git
> until after -rc1 so there's your target. But now is a good time to be
> sending out material for people to look at. Let's not have a gigantic
> flood of new stuff the day after -rc1!
>
> I think progress here is totally dependent on whether those who
> regularly work on this code want guard() in there. A
> preference/familiarity/style choice, mainly. At present the adoption
> of guard() in mm/*.c is very small.
>
Thanks for taking a look, Andrew.
I'm not aiming for any particular merge window here. I had some time to
revisit the previous version and rework it, so I sent this now mainly to
keep the discussion going.
I agree this probably comes down to whether people are comfortable with
using guard() in this code. It'd be great to hear what others working in
mm, and in page_alloc in particular, think.
prev parent reply other threads:[~2026-03-30 16:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-27 16:14 [PATCH v2 0/8] mm: use spinlock guards for zone lock Dmitry Ilvokhin
2026-03-27 16:14 ` [PATCH v2 1/8] mm: use zone lock guard in reserve_highatomic_pageblock() Dmitry Ilvokhin
2026-03-27 16:14 ` [PATCH v2 2/8] mm: use zone lock guard in unset_migratetype_isolate() Dmitry Ilvokhin
2026-03-27 16:14 ` [PATCH v2 3/8] mm: use zone lock guard in unreserve_highatomic_pageblock() Dmitry Ilvokhin
2026-03-27 16:14 ` [PATCH v2 4/8] mm: use zone lock guard in set_migratetype_isolate() Dmitry Ilvokhin
2026-03-27 16:14 ` [PATCH v2 5/8] mm: use zone lock guard in take_page_off_buddy() Dmitry Ilvokhin
2026-03-27 16:14 ` [PATCH v2 6/8] mm: use zone lock guard in put_page_back_buddy() Dmitry Ilvokhin
2026-03-27 16:14 ` [PATCH v2 7/8] mm: use zone lock guard in free_pcppages_bulk() Dmitry Ilvokhin
2026-03-27 16:14 ` [PATCH v2 8/8] mm: use zone lock guard in __offline_isolated_pages() Dmitry Ilvokhin
2026-03-27 20:11 ` [PATCH v2 0/8] mm: use spinlock guards for zone lock Andrew Morton
2026-03-30 16:47 ` Dmitry Ilvokhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acqpPkXKnyB4Oqci@shell.ilvokhin.com \
--to=d@ilvokhin.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=jackmanb@google.com \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=rostedt@goodmis.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox