From: Li Wang <liwang@redhat.com>
To: "David Hildenbrand (Arm)" <david@kernel.org>
Cc: akpm@linux-foundation.org, rppt@kernel.org, ljs@kernel.org,
Liam.Howlett@oracle.com, vbabka@kernel.org, surenb@google.com,
mhocko@suse.com, shuah@kernel.org, aubaker@redhat.com,
linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v4] selftests/mm: skip hugetlb_dio tests when DIO alignment is incompatible
Date: Wed, 1 Apr 2026 16:44:32 +0800 [thread overview]
Message-ID: <acza8JhtGD6sE3N9@redhat.com> (raw)
In-Reply-To: <b9625c60-2b1a-4890-a703-49e31aaaa168@kernel.org>
On Wed, Apr 01, 2026 at 10:34:40AM +0200, David Hildenbrand (Arm) wrote:
> On 4/1/26 02:39, Li Wang wrote:
> >>> +static void run_test(int fd, unsigned int start_off,
> >>> + unsigned int end_off, unsigned int align)
> >>
> >> Nit: prefer to-tab alignment in MM land.
> >
> > Yes, I noticed Andrew (thanks!) corrected it and added to -mm mm-new branch.
> >
> >>> +{
> >>> + if (!check_dio_alignment(start_off, end_off, align))
> >>> + return;
> >>
> >> Is there a reason we just perform that at the beginning of
> >> run_dio_using_hugetlb(), avoiding run_test() entirely?
> >
> > That will make the run_dio_using_hugetlb() have too many args and
> > uncomfortable to read, yes, it's more likely personal preference.
>
> Nah, just squash it. There is no need for this separate function, really.
Okay, let me do it in patch v5.
--
Regards,
Li Wang
prev parent reply other threads:[~2026-04-01 8:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-30 12:53 [PATCH v4] selftests/mm: skip hugetlb_dio tests when DIO alignment is incompatible Li Wang
2026-03-30 14:24 ` David Hildenbrand (Arm)
2026-04-01 0:39 ` Li Wang
2026-04-01 8:34 ` David Hildenbrand (Arm)
2026-04-01 8:44 ` Li Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acza8JhtGD6sE3N9@redhat.com \
--to=liwang@redhat.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=aubaker@redhat.com \
--cc=david@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=rppt@kernel.org \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox