From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83FCFC3DA6D for ; Fri, 23 May 2025 12:23:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D6CD46B00AF; Fri, 23 May 2025 08:23:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D1CCF6B00B3; Fri, 23 May 2025 08:23:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C0C406B00B7; Fri, 23 May 2025 08:23:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A000F6B00AF for ; Fri, 23 May 2025 08:23:07 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 162E558207 for ; Fri, 23 May 2025 12:23:07 +0000 (UTC) X-FDA: 83474087214.22.3FCA537 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf14.hostedemail.com (Postfix) with ESMTP id 0987B10000F for ; Fri, 23 May 2025 12:23:03 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=Fam9uvvz; spf=pass (imf14.hostedemail.com: domain of zaslonko@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=zaslonko@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748002984; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Mv27RnkmPikA+dNN5lMrWWVazp6Le4oxa7GInuekgfs=; b=0IKNstVIkymJVRCfcmfqmuZhWZn23vT85VE86xk1nRxwdy5LAG36/9/Ab7aWbUT55qPTj7 v5TPd/80GSg0dLKhSZegDYulFMqSH/oXsRk3Gm86xyUVQDMGqF/qWnjJwKgINfxYCGYNM0 +AsOyqpPa8s6k1yzs9y6Swm2vH89d2M= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748002984; a=rsa-sha256; cv=none; b=tKyXF5aGGNG/dK7cUIBvGHCTMbxQKgPOL0itMOV6+docCLUkMFVbdVwekuwmfoinCh3HPW Dq0rXUv8PLIq52dOv3h5SC8y1lp4nv9KNTKPWFC+QkI9lN6/vMSgpME7PHY8jE1f+VMSnK DXo3AaUf7/0qZ3UiKltDwIfH+6nFSvA= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=Fam9uvvz; spf=pass (imf14.hostedemail.com: domain of zaslonko@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=zaslonko@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 54NC7TI2024630; Fri, 23 May 2025 12:22:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=Mv27Rn kmPikA+dNN5lMrWWVazp6Le4oxa7GInuekgfs=; b=Fam9uvvztkQVl6hAO0xAbe +lmcBR1E0+Vd3DxlCeuKdCmoTeOYPEpoktkQQheX7wUl751ii7wi9F8NNQp7fSyj 5F3CvcAXHNbgTteN27wPxZ/yHF5psAsvROFP9XCraHH4IiFKtm/Ky1XrIGXLDn9F k6X//ngx5/p0qQ64SZBURMx7G9H3qwOIAxyUyhy4yTfR0fVuAkOlFIdcETrhs6tq VrYMUp6pACr9KaIz2iMEwFzZj+OofsdxJ8qZZWArzMknw1jtwVTDjC/Eqj5PDs6T tzx5S5HPJOy0Ig4mtVhCF6ijhuIGX1uGtTg/cSKFxKiLj+6Xkq2V1AaFYo9+fyXw == Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 46sxhwfm6v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 23 May 2025 12:22:58 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 54NAwmfi020713; Fri, 23 May 2025 12:22:57 GMT Received: from smtprelay07.wdc07v.mail.ibm.com ([172.16.1.74]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 46rwkq6fr3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 23 May 2025 12:22:57 +0000 Received: from smtpav01.wdc07v.mail.ibm.com (smtpav01.wdc07v.mail.ibm.com [10.39.53.228]) by smtprelay07.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 54NCMtSt15401478 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 23 May 2025 12:22:55 GMT Received: from smtpav01.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 883FC58059; Fri, 23 May 2025 12:22:55 +0000 (GMT) Received: from smtpav01.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6864C5804B; Fri, 23 May 2025 12:22:53 +0000 (GMT) Received: from [9.87.148.238] (unknown [9.87.148.238]) by smtpav01.wdc07v.mail.ibm.com (Postfix) with ESMTPS; Fri, 23 May 2025 12:22:53 +0000 (GMT) Message-ID: Date: Fri, 23 May 2025 14:22:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Zaslonko Mikhail Subject: Re: [PATCH 2/2] zram: support deflate-specific params To: Sergey Senozhatsky Cc: Andrew Morton , Minchan Kim , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Heiko Carstens , Ilya Leoshkevich , Herbert Xu References: <20250514024825.1745489-1-senozhatsky@chromium.org> <20250514024825.1745489-3-senozhatsky@chromium.org> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTIzMDEwNiBTYWx0ZWRfX7gZyliZNFwXF qW1DmWB/PGXZcq3A+N2ScMUfWZPTH730bCxyxEAjuT9dYlWG+8cYazRed6UZk9nOpH5rz/RW4OX 14vY7LbEKQSVpgBw7QS/WsMhnKdt45Z2EtHH9Sfq7/PUA8x3cHRuZJERAvYaBqvcmv6r5DXQlIl AyxHtfj7V+u/1K9nGkkJS1rnWx9vl57B2c0J4R3CSNigAQ8271kYPQYcg/5nWjis2e5+XI4F2BG O5+JywZkY8Aw4mTz3+0qdN5F14oIT62w/PQareKA2ODn6TJWpTlq16kaNJX3ESpX/rj2VEDHgWX Ip1FePTwyoV8Tt4f/fwDhdlkQjuy5HHPpKVDPSrMXhCYjsXkhLKCbqogDDjTKMylctXrr3SBNHw t+f3xENcRahBtNr2lt0CCtV8biDVYln4p39lhkl7R+Ty/gQ0wAKhXo3l1398EJajRLmkSm/c X-Proofpoint-GUID: pniA40CTIlxMhhHTF1GgFVpc--QfoHea X-Authority-Analysis: v=2.4 cv=O685vA9W c=1 sm=1 tr=0 ts=683068a2 cx=c_pps a=AfN7/Ok6k8XGzOShvHwTGQ==:117 a=AfN7/Ok6k8XGzOShvHwTGQ==:17 a=IkcTkHD0fZMA:10 a=dt9VzEwgFbYA:10 a=VnNF1IyMAAAA:8 a=anLjIrP37XIjfVduPqUA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-ORIG-GUID: pniA40CTIlxMhhHTF1GgFVpc--QfoHea X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-23_03,2025-05-22_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 mlxlogscore=999 spamscore=0 mlxscore=0 phishscore=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 impostorscore=0 clxscore=1015 malwarescore=0 suspectscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505160000 definitions=main-2505230106 X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 0987B10000F X-Stat-Signature: huqwoo8kxk985hafey6bc68kwtymfk6n X-Rspam-User: X-HE-Tag: 1748002983-212164 X-HE-Meta: U2FsdGVkX1/D+j8Wdv89/OPvVJzO2qNGpz1exKbD+nZp2DzS3zN6INJT4cbfqDZr1AaKHQuf4gQE0dp3wrcDviLpx67xg0zxV5Ay/7DFX6cMjwpUFfQWifwSQOoiCgVePU72PbCF8vfqur6Y6iMbW2oQc9vgSqtGUV4cwF+twYXS0t6fjm8HnEA7IvgqBcQNYccJ32BGDBjy0GpNiOY5+cZ+aOgN1D7VVxcgwPUEIlYcccRZIH40NdbB8kQBIMQ3C0kRrOrrqoYL709mEfE9+DQ5jUQr51TMVKkrf5xbmYVbGePH96KWR8h93kn1HGWD7Usw63CSG23ttAKrLrrHT4DLY9vlZu4CrC6qVhGrN5se06ctq/0f0e5vXA2RjO50V7CvCD2g7aZPll0cVwGLJ7Kg5QRDE5GD5cm47HuzEdEL0njTpbWv6F2TMF5HcJLr1qG6u2DpMVnaAHA9VpP9eqFFJ9awoopZu69XTFJzSp9VZ6EZI114Y/y2Yg81Bq4DIB5QiEGwSIWQ4fq8z2YH3YmU5RjrgaAWruK48nAjRLxF3ZQbZ+MvDQjq3qWJx4j+w5KrgEYVdHZxM8Ju9AtANlMlujrmQhB84EuGBDToIwpIrVivkmeNQo1C79Xj20+DROW+DvVAW1mhoTIBtcCISU8isr4zhJZP9LrRAEYkzVo4dm3nDpsQ3WaylOwaiFkbrYtQfaEUrMbyM70cZwasZNpDErxMJwxACIUR3mwny3+JRX+f3NAjW4iujo7ySIWOTbxrS+CMtbVEYj8DUraTky33QSqWC62t9h/qE058rxiyh7Lp++6/+97YtlqLoWKYw0rx/RV/nynv3N/RuqGye9604LcyqlNgZR7sJIPGO9NCohYkou2qPVA3jKfapa/tr8W1/5YIEX1GdvM3zCnJ+aRVQHotSNxirp7aCS4bjDEJDvIsvNtmVAFBCprZ0COgLMgPQ/5L1A/7OudOzyQ ue7Qvlka cREy+DG3hN1F3zwnI6aH1cVwZCyW6hkU0UutDGDHejtaE4W2BIjMAzNa+BbMD9hfsgzvYEKSRu9pN4Q5bgBQTUiV9HN7qJ4E9sH1KIXW5vK26aXV2sJTBppv6xcdl50xINpcky10BB6QnhF5EFHGKzjIEtqf62MmbgEWQRuh9xur0XMtiAFtyRQbOBZdyYm4OezPrBh3R5+9uP9/qNS/LFINkeW+Nj1u7Fiew7wYzEKMuozYeqap1uvlNUXOBRk/sr86T9wiWg4yfBYlJ2q61degnn6U+xS0Qzhm5fP97w7Mt3KH6spFSgRWPdAG+W3azfAW8OsCv0yZjwA7gWj9pOqx32g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hello, On 15.05.2025 05:14, Sergey Senozhatsky wrote: > Cc-ing Herbert > > On (25/05/14 12:58), Zaslonko Mikhail wrote: >> Looks good to me. >> >> Also, here is another patch suggestion from my side on top of this one. >> Let me know what you think. >> >> ---8<--- >> >> zram: Utilize s390 hardware deflate acceleration for zram >> >> Utilize s390 hardware deflate acceleration for zram deflate compression >> by default when the facility is available. >> >> Signed-off-by: Mikhail Zaslonko >> >> diff --git a/drivers/block/zram/backend_deflate.c b/drivers/block/zram/backend_deflate.c >> index b75016e0e654..5bfc57522e3a 100644 >> --- a/drivers/block/zram/backend_deflate.c >> +++ b/drivers/block/zram/backend_deflate.c >> @@ -22,10 +22,23 @@ static void deflate_release_params(struct zcomp_params *params) >> >> static int deflate_setup_params(struct zcomp_params *params) >> { >> - if (params->level == ZCOMP_PARAM_NOT_SET) >> - params->level = Z_DEFAULT_COMPRESSION; >> - if (params->deflate.winbits == ZCOMP_PARAM_NOT_SET) >> - params->deflate.winbits = DEFLATE_DEF_WINBITS; >> + /* >> + * In case of s390 zlib hardware support available, >> + * use maximum window size and level one as default compression >> + * parameters in order to utilize hardware deflate acceleration. >> + */ >> + if (params->level == ZCOMP_PARAM_NOT_SET) { >> + if (zlib_deflate_dfltcc_enabled()) >> + params->level = Z_BEST_SPEED; >> + else >> + params->level = Z_DEFAULT_COMPRESSION; >> + } >> + if (params->deflate.winbits == ZCOMP_PARAM_NOT_SET) { >> + if (zlib_deflate_dfltcc_enabled()) >> + params->deflate.winbits = -MAX_WBITS; >> + else >> + params->deflate.winbits = DEFLATE_DEF_WINBITS; >> + } > > I'm not sure if we want this much of s390 specific code in the generic > zram/Crypto API code. Both of these params can be configured by user-space > via the algorithm_params device attribute. I understand the concern. My intention was to use special defaults for s390 when no algorithm_params configured by the user (which is the common case, I assume). Do you see other way of doing so without touching zram generic code? Thanks, Mikhail