From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0CE2C433FE for ; Wed, 30 Nov 2022 10:16:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3B6966B0074; Wed, 30 Nov 2022 05:16:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 367BD6B0075; Wed, 30 Nov 2022 05:16:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2558B6B0078; Wed, 30 Nov 2022 05:16:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 122CD6B0074 for ; Wed, 30 Nov 2022 05:16:06 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id D86FD1205DA for ; Wed, 30 Nov 2022 10:16:05 +0000 (UTC) X-FDA: 80189703090.11.EEB46DB Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf29.hostedemail.com (Postfix) with ESMTP id 4486212001F for ; Wed, 30 Nov 2022 10:16:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669803364; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PfIaBuBbISWu50WkIObdwLry5Mhmx0Lt/bXwxdM+I/4=; b=Ua/4XvZ7fzYBS/P4cphmNQb6FoOnDt05lWYfdUqNCLtPGcznt4QyMk3oXoWtsoHPAfUL4o r76raZJDnR+zFHbSK+VzPezrA/pMMRDhQTy/k9qRkQZTa/Pva0t893WgfZ2Zv8NZNw1d3i uXFJ8vpDWuUTaVTqanC45xD9+0Zb7Nc= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-84-jsWLPrrqOaSQaWCkL6ksNQ-1; Wed, 30 Nov 2022 05:15:59 -0500 X-MC-Unique: jsWLPrrqOaSQaWCkL6ksNQ-1 Received: by mail-wr1-f69.google.com with SMTP id m24-20020adfa3d8000000b00242168ce9d1so2155539wrb.15 for ; Wed, 30 Nov 2022 02:15:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PfIaBuBbISWu50WkIObdwLry5Mhmx0Lt/bXwxdM+I/4=; b=14iaeZKhZBtYlkNezMOmaPk03kK2MqF+TUQzi8oYDAHc9fBsEAKW7BjnwM3gvaQ412 bdhP6NU0RMwOKIDBFPXwlikmpwHyhCjGqvpZgXRNoXuQ4ems+87JZvhG/7hAiXVwrO6M XgcXDYtBAjPNAqZYo2uHaceJhdM5INZljibgO0K8Ij0FlHW5ianjr9EqHaB2yKQnqA1V 1nU1DlXab1BT2P/eobqUF9Puyd/uweY3AHGRVx+rcrUniHw1UwPt5k0EOlOWLCY3TGMs AXqB3dPBFouXvBRIm8XIs6eSYAA6lz/TbjGyeyTm+maos+A08PZ7I+UQJmNjkhtyWbhf NC5Q== X-Gm-Message-State: ANoB5plGto9PG0bh75kI6TwPqnoWf4569B69mWW645RGvzIOhHbRZMsV ZB2y4TynlBGbRVk5+lcHlxRy0sHCYiey8bPD+D+60/tQDETzSrI4oTLtOnrPlTZ7sXpl+QFZJiT LmRcsxJjqrz4= X-Received: by 2002:a5d:594b:0:b0:242:213a:7f96 with SMTP id e11-20020a5d594b000000b00242213a7f96mr4602854wri.155.1669803358840; Wed, 30 Nov 2022 02:15:58 -0800 (PST) X-Google-Smtp-Source: AA0mqf7pBJBJ77zHfI+tM9lu2Kp4Kjcet0/UGqV40kRAYLTnaZOGCa9/Os5YU8PtMospqTVwMmzkNg== X-Received: by 2002:a5d:594b:0:b0:242:213a:7f96 with SMTP id e11-20020a5d594b000000b00242213a7f96mr4602835wri.155.1669803358582; Wed, 30 Nov 2022 02:15:58 -0800 (PST) Received: from [192.168.3.108] (p5b0c6655.dip0.t-ipconnect.de. [91.12.102.85]) by smtp.gmail.com with ESMTPSA id u15-20020a05600c210f00b003cf7292c553sm1395364wml.13.2022.11.30.02.15.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Nov 2022 02:15:57 -0800 (PST) Message-ID: Date: Wed, 30 Nov 2022 11:15:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 02/10] mm/hugetlb: Don't wait for migration entry during follow page To: Peter Xu , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: James Houghton , Jann Horn , Andrew Morton , Andrea Arcangeli , Rik van Riel , Nadav Amit , Miaohe Lin , Muchun Song , Mike Kravetz References: <20221129193526.3588187-1-peterx@redhat.com> <20221129193526.3588187-3-peterx@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20221129193526.3588187-3-peterx@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Ua/4XvZ7"; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669803365; a=rsa-sha256; cv=none; b=wXlBSiMxlwL5y1soqiNiwHc1Bd7jKrFJHPXw0vFa95RsvLNLe4EvSYVCr04TcrpSurenwP CyoFdTv0C+oO1YAlG9hmyOJm0pysNURkGrn8Bf5bhHnexrvwmKt1b7GF6LpFkiCQJtk+uu CKt10d1uI7e2bSJBuKFxsNUoVzhCk9M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669803365; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PfIaBuBbISWu50WkIObdwLry5Mhmx0Lt/bXwxdM+I/4=; b=QZ2vrPlxEzZg8PSMt83D1tO0sY6ta31M4jPMWHoBW5jd887KuLJblPs75Au7ZDU2JnxFeN BOPCkON7oK1Ni0ntWRvjCJ9AK3012eQr3r30KUrxkQMx0DjPTy8PXcZd/Uc5pJBuuv3+p7 tjSFwxPiQ8ppKYKQPJO258igVDXYmaY= Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Ua/4XvZ7"; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 4486212001F X-Stat-Signature: ka99o49bod58zzhiud5midyz6p3i6tkg X-Rspam-User: X-HE-Tag: 1669803365-683695 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 29.11.22 20:35, Peter Xu wrote: > That's what the code does with !hugetlb pages, so we should logically do > the same for hugetlb, so migration entry will also be treated as no page. > > This is probably also the last piece in follow_page code that may sleep, > the last one should be removed in cf994dd8af27 ("mm/gup: remove > FOLL_MIGRATION", 2022-11-16). We only have a handful of follow_page() calls left. Most relevant for hugetlb should only be the ones from mm/migrate.c. So this is now just consistent with ordinary pages/THP. Happy so see that gone. Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb